Consider adding choice of direct/buffered IO as parameter

[itzsimpl]

Consider adding

    ag.add_argument(
        "--direct", help=f"Override the default IO mode for benchmark \
            (default: {settings['direct']})", type=int, default=settings['direct'])

at line 251 of benchmark_script/bench_fio.

For example ZFS does not support direct IO mode (see openzfs/zfs#224), so in order to run tests on ZFS one needs to be able to disable it.

[louwrentius]

Done, commited to master branch.

…

On 28 Jun 2020, at 13:13, Iztok Lebar Bajec ***@***.***> wrote:  Consider adding ag.add_argument( "--direct", help=f"Override the default IO mode for benchmark \ (default: {settings['direct']})", type=int, default=settings['direct']) at line 251 of benchmark_script/bench_fio. For example ZFS does not support direct IO mode (see openzfs/zfs#224), so in order to run tests on ZFS one needs to be able to disable it. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe.