From 8801b530fc456b82869ef9d2c1afbe5b36caa201 Mon Sep 17 00:00:00 2001 From: Benjamin Riedel Date: Thu, 10 Oct 2019 10:53:51 +0200 Subject: [PATCH] revert in memory locks --- storage/memory.go | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/storage/memory.go b/storage/memory.go index b09450fd..40150fa6 100644 --- a/storage/memory.go +++ b/storage/memory.go @@ -4,7 +4,6 @@ import ( "bytes" "fmt" "strings" - "sync" "github.com/syndtr/goleveldb/leveldb/util" ) @@ -71,8 +70,6 @@ type memory struct { storage map[string][]byte offset *int64 recovered bool - // mutex to protect map reads/writes - rwm sync.RWMutex } // NewMemory returns a new in-memory storage. @@ -84,16 +81,12 @@ func NewMemory() Storage { } func (m *memory) Has(key string) (bool, error) { - m.rwm.RLock() _, has := m.storage[key] - m.rwm.RUnlock() return has, nil } func (m *memory) Get(key string) ([]byte, error) { - m.rwm.RLock() value, _ := m.storage[key] - m.rwm.RUnlock() return value, nil } @@ -101,16 +94,12 @@ func (m *memory) Set(key string, value []byte) error { if value == nil { return fmt.Errorf("cannot write nil value") } - m.rwm.Lock() m.storage[key] = value - m.rwm.Unlock() return nil } func (m *memory) Delete(key string) error { - m.rwm.Lock() delete(m.storage, key) - m.rwm.Unlock() return nil }