Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some code in OpenTitan uses "import" at top-level in a class #26001

Open
rswarbrick opened this issue Jan 24, 2025 · 0 comments · May be fixed by #26002
Open

Some code in OpenTitan uses "import" at top-level in a class #26001

rswarbrick opened this issue Jan 24, 2025 · 0 comments · May be fixed by #26002
Labels
Component:DV DV issue: testbench, test case, etc. Component:RTL

Comments

@rswarbrick
Copy link
Contributor

Description

This isn't allowed (see footnote 11 in section A.10 of the 1800 spec). It turns out that many EDA tools don't mind, which is why we hadn't noticed. But Questa generates an error.

I believe that there are just two instances of this, with potential examples found by searching for files that contain "class" and an "import" line:

git grep -l 'import ' '*.sv' >with-import.lst
grep <with-import.lst -v autogen | xargs grep -l '^\s*class' | sort -u >both.lst

There were 26 hits and I think two genuine examples.

@rswarbrick rswarbrick added Component:DV DV issue: testbench, test case, etc. Component:RTL labels Jan 24, 2025
@rswarbrick rswarbrick linked a pull request Jan 24, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component:DV DV issue: testbench, test case, etc. Component:RTL
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant