[spi_device] Pending tasks for D2

[eunchan]

Pending

• Change Upload Command Interrupt [spi_device] When and how should SW read cmdfifo, addrfifo, and payload buffer for correct data? #11871
• Change CMD_INFO [spi_device] Read Status, Read JEDEC ID, Read SFDP to have fixed value (read-only) in CMD_INFO #10009 (Future Release)
• CG on SCK to control the sys reset release (discussed in [spi_device] Connect watermark event to the interrupt source #9344 ) (Not Yet Implemented)
• Adding CSRs
  • Interrupts
  • Read address update by SW (next_addr) (Future Release)
• Direct tests (lower priority now)
  • Upload
  • Read SFDP
  • EN4B/ EX4B
  • WREN/ WRDI
  • Read Cmd
  • Mailbox
  • Passthrough
    • Command Filtering
    • Addr Manipulation
    • Payload direction (In/ Out/ Dummy)
    • Write status manipulation
    • Mailbox hi-jack
    • Read Status hi-jack

Done

• Read Buffer Management
  • Last Read Addr from ReadCmd
  • Interrupt : Buffer Threshold.
    [spi_device] Connect watermark event to the interrupt source #9344 addresses watermark
    [spi_device] Connect Readbuffer flip event to interrupt #9354 addresses flip
• Passthrough timing violation on addr_swap_en / payload_swap_en [spi_device] Passthrough to use outclock-ed addr_swap_en, payload_swap_en #9741
  • Addressed in [spi_device] latch swap configs at outclk #9936
• JEDEC ID return : [spi_device] Continuous Code in JEDEC ID #9609
  • Change CSR to have Continuous Code (1B) + Count (repeating Continous Code) + JEDEC ID (1B) + Additional bytes (2B? or more?)
  • Connect CSR to JEDEC module
  • Implement counter and continous code logic
• Flash/ Passthrough Technical Specification
  • Address Manipulation
  • Data Manipulation
  • Updated CMD_INFO
  • BUSY control
  • Output Enable control
  • Add pointer to TPM_ACCESS_x.activeLocality (Table 39 in TPM PC Client spec)
  • CMD_INFO fixed index table (0-2 for Read Status, 3 for Read JEDEC, 4 for Read SFDP). Add desc that the sub fields won't affect in Flash mode (only in Passthrough mode)
• upload interrupts [spi_device] Connect upload interrupt #9300
• Write Status Data filtering (Manipulation)
  • Adding CSR [spi_device] Add payload_swp_en bit field in CMD_INFO #9054
  • Passthrough port change (data_swap_mask & data_swap_data) [spi_device] Add data swap port in passthrough #9060
  • Adding first byte detection logic [spi_device] Data manipulation logic in Passthrough mode #9071
  • Adding data swap logic (similar with addr_swap) [spi_device] Data manipulation logic in Passthrough mode #9071
  • Adding control of data_swap in FSM [spi_device] Data manipulation logic in Passthrough mode #9071
• Addr 4B forced in CMD_INFO [spi_device] addr_mode in CMD_INFO to support forced 3B/4B address #9157
  • Revise address mode fields in CMD_INFO multireg
    • Change addr_4b_affected and addr_en to addr_mode
      • 00: addr field does not exist
      • 01: addr size is affected by cfg_addr_4b_en_i
      • 10: addr size is 3 bytes regardless of cfg_addr_4b_en_i
      • 11: addr size is 4 bytes regardless of cfg_addr_4b_en_i
  • Tie unused_ in cmdparse, readcmd, upload modules
  • Add condition in passthrough to enable 4B regardless of cfg_addr_4b_en_i
• Passthrough Intercept
  With SW configurations, one of SPID Flash modules (Read Status, Read JEDEC, Read Cmd) is able to intercept SPI Passthrough and processes the command (returning data).
  • Add CSR: INTERCEPT_EN {status, jedec, mailbox, sfdp} [spi_device] Passthrough Intercept CSR #9226
  • Revise Flash modules to check spi_mode
    When spi_mode is Passthrough, the submodule shall stop returning data if INTERCEPT_EN bit is not set. [spi_device] Cmdparse to intercept Passthrough #9258
  • Passthrough logic to cancel the ongoing transaction by de-asserting CSb. No need of gating SCK [spi_device] Passthrough logic to see intercept #9177
  • Revise SPID top to shift from Passthrough to internal flash for SPI towards the host system. [spi_device] Cmdparse to intercept Passthrough #9258 [spi_device] Mailbox Intercept Logic #9260

[eunchan]

Created a PR #9054 for the Data swap feature CSR

[eunchan]

Created a PR #9060 for the port change in the passthrough module.

[eunchan]

Revise address configurations in CMD_INFO:

• Change addr_4b_affected and addr_en to addr_mode
  - 00: addr field does not exist
  - 01: addr size is affected by cfg_addr_4b_en_i
  - 10: addr size is 3 bytes regardless of cfg_addr_4b_en_i
  - 11: addr size is 4 bytes regardless of cfg_addr_4b_en_i

[eunchan]

Created a PR #9157 to support forced 4B address

[eunchan]

Created a PR #9177 to revise passthrough datapath to observe the intercept event then drop the transaction.

[eunchan]

JEDEC return datapath has been revised in PR #9609

[eunchan]

Issue #9741 is added. Need to resolve

[eunchan]

Updated to the latest status.

[tjaychen]

@eunchan just a gentle ping, i think all the items for passthrough are already done, can we close this issue?

[eunchan]

@eunchan just a gentle ping, i think all the items for passthrough are already done, can we close this issue?

Not yet. Have a couple of items are pending.