Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move this repository to kiedtl/ #81

Closed
7 of 8 tasks
kiedtl opened this issue May 28, 2021 · 20 comments
Closed
7 of 8 tasks

Move this repository to kiedtl/ #81

kiedtl opened this issue May 28, 2021 · 20 comments

Comments

@kiedtl
Copy link
Member

kiedtl commented May 28, 2021

I created the lptstr repository a few years ago to store my "serious" projects. The idea was to have a place where I could keep side projects I intended for broader use, and keep other things (dotfiles, random scripts, experiments) in my user profile.

However, it's become a bit tedious to follow this pattern and this rule hasn't held true for a while. There are plenty of half-assed junk projects in lptstr and a few "serious" projects in kiedtl, so I've decided to move everything from lptstr to kiedtl and just get rid of that pseudo-organization.

Of course, this will be easy to do for things like chmap, but not so easy for Winfetch, as the repository names are baked into a lot of places. I'm making a list of these places; once I believe I've gotten everything down, I'll transfer the repository and change all the URL references.

List of things to be changed/done before move:

  • README
  • Choose new name for PowerShell Gallery package
  • winfetch.ps1 metadata

After:

  • v2.1.0 release
  • Chocolatey package
  • Scoop package
  • PSGallery Package
  • wiki

@jcwillox @rashil2000 Let me know if the repository transfer will affect anything else. Of course, all maintainers will continue to have access after the transfer.

@rashil2000
Copy link
Member

As long as all the issues, history, redirects from the old URL (for git remote/upstream stuff) get transferred properly I think we would be fine. Github should automatically handle all of that as far as I'm aware.

However I have one doubt, the (long proposed) yet to be published package in the PowerShell Gallery was supposed to be named lptstr-winfetch. Will we be changing this, as a result of the transfer?

@kiedtl
Copy link
Member Author

kiedtl commented May 29, 2021

Uhg, that's a rough side. winfetch was taken IIRC... I guess we could go along with kiedtl-winfetch? or pwsh-winfetch?

@jcwillox
Copy link
Member

Sounds like it should be fine, we should also let the chocolatey thread know (#38), as @jakublevy is maintaining a package for that. There are also some references to the URL in the winfetch.ps1 file.

@jakublevy
Copy link

I will push URL changes to chocolatey with the next version.

@rashil2000
Copy link
Member

We can probably release 3.0 after the shift (couple of new stuff - weather info, native image printing etc.)

@jcwillox
Copy link
Member

Agreed, I've had a look over at the codebase and everything looks good, we'll wait for the move and then create a new release, which should really be v2.1.0, as it's not a major overhaul. Also when we update the scoop manifest this would also be a good time to address #77.

@kiedtl
Copy link
Member Author

kiedtl commented Jun 10, 2021

We'll use pwsh-winfetch for the PowerShell gallery package.

@kiedtl
Copy link
Member Author

kiedtl commented Jun 10, 2021

ScoopInstaller/Extras#6318

@kiedtl
Copy link
Member Author

kiedtl commented Jun 10, 2021

The v2.1.0 release can be done now, after which the Choco and wiki updates can be done.

@kiedtl
Copy link
Member Author

kiedtl commented Jun 18, 2021

@rashil2000 Can we do the release now? The Scoop maintainers seem to be busy; I don't think we should wait for the PR merge any longer.

@jcwillox
Copy link
Member

Sure, I've already done the release notes, pretty sure I mentioned everything, was just waiting for them to merge the PR first, but you're right there's no point in waiting any longer. You may want to update the PR to point to the new release once we create it.

@rashil2000
Copy link
Member

Looks good, all green from me!

@jcwillox
Copy link
Member

Done v2.1.0 released 🎉

@jakublevy
Copy link

Chocolatey package updated.
https://community.chocolatey.org/packages/winfetch/2.1.0

@rashil2000
Copy link
Member

@jcwillox The script metadata is out of date (still shows v2.0.0)

Is there a way to correct it in the 2.1.0 tag branch itself? The updated metadata is necessary for publishing pwshfetch-test-1 to PSGallery.

@jakublevy I think you'll need to update the file checksum once this change is made.

@jakublevy
Copy link

jakublevy commented Jun 19, 2021

Oh, I didn't inspect the actual file, @rashil2000, you're right, thanks.
I will re-push with an updated checksum later after metadata corrections.

@jcwillox
Copy link
Member

Haha we totally missed that, I'm not aware of any way to update the tag, especially without breaking things, we're probably best just creating v2.1.1

@rashil2000
Copy link
Member

rashil2000 commented Jun 19, 2021

https://stackoverflow.com/a/21466838

It is generally not a good idea to update tags, but I don't think we have any infra in place that would break if we just do it. Correct me if I'm wrong.

@jcwillox
Copy link
Member

The scoop manifest won't update and it'll have the wrong hash, honestly just safer to create a patch release (which is basically what that stackoverflow answer says)

@rashil2000
Copy link
Member

This issue can be closed - the only item left was the PSGallery package. It is being tracked in #13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants