Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Key value formatting #30

Closed
olanod opened this issue Apr 29, 2021 · 0 comments · Fixed by #36
Closed

Key value formatting #30

olanod opened this issue Apr 29, 2021 · 0 comments · Fixed by #36

Comments

@olanod
Copy link

olanod commented Apr 29, 2021

Current released version of femme lacks quoting around extra kv pairs, I see the it got solved after a recent-ish PR(needs to be released) but I was wondering if writing those kv pairs could be smarter, if I have a string-like value then be quoted but a number-like value for example remain unquoted. Is it something that maybe serde_json that is already used could solve?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Serialize log values to json simao/femme
1 participant
@olanod