diff --git a/src/main/java/de/tum/cit/aet/artemis/quiz/service/QuizExerciseImportService.java b/src/main/java/de/tum/cit/aet/artemis/quiz/service/QuizExerciseImportService.java index 4cfc0c557509..1b26865c641b 100644 --- a/src/main/java/de/tum/cit/aet/artemis/quiz/service/QuizExerciseImportService.java +++ b/src/main/java/de/tum/cit/aet/artemis/quiz/service/QuizExerciseImportService.java @@ -114,6 +114,7 @@ private QuizExercise copyQuizExerciseBasis(QuizExercise importedExercise) { newExercise.setRandomizeQuestionOrder(importedExercise.isRandomizeQuestionOrder()); newExercise.setAllowedNumberOfAttempts(importedExercise.getAllowedNumberOfAttempts()); newExercise.setRemainingNumberOfAttempts(importedExercise.getRemainingNumberOfAttempts()); + // The new exercise should not immediately be open for practice newExercise.setIsOpenForPractice(false); newExercise.setQuizMode(importedExercise.getQuizMode()); newExercise.setDuration(importedExercise.getDuration()); diff --git a/src/test/java/de/tum/cit/aet/artemis/quiz/QuizExerciseIntegrationTest.java b/src/test/java/de/tum/cit/aet/artemis/quiz/QuizExerciseIntegrationTest.java index e787ee1533a0..d7a9a6c523a4 100644 --- a/src/test/java/de/tum/cit/aet/artemis/quiz/QuizExerciseIntegrationTest.java +++ b/src/test/java/de/tum/cit/aet/artemis/quiz/QuizExerciseIntegrationTest.java @@ -1242,6 +1242,7 @@ void testUpdateQuizExerciseWithNotificationText() throws Exception { void importQuizExerciseToSameCourse() throws Exception { ZonedDateTime now = ZonedDateTime.now(); QuizExercise quizExercise = quizExerciseUtilService.createQuiz(now.plusHours(2), null, QuizMode.SYNCHRONIZED); + quizExercise.setIsOpenForPractice(true); quizExerciseService.handleDndQuizFileCreation(quizExercise, List.of(new MockMultipartFile("files", "dragItemImage2.png", MediaType.IMAGE_PNG_VALUE, "dragItemImage".getBytes()), new MockMultipartFile("files", "dragItemImage4.png", MediaType.IMAGE_PNG_VALUE, "dragItemImage".getBytes()))); @@ -1261,6 +1262,7 @@ void importQuizExerciseToSameCourse() throws Exception { .isEqualTo(quizExercise.getCourseViaExerciseGroupOrCourseMember().getId()); assertThat(importedExercise.getCourseViaExerciseGroupOrCourseMember()).isEqualTo(quizExercise.getCourseViaExerciseGroupOrCourseMember()); assertThat(importedExercise.getQuizQuestions()).as("Imported exercise has same number of questions").hasSameSizeAs(quizExercise.getQuizQuestions()); + assertThat(importedExercise.isIsOpenForPractice()).as("Imported exercise is not open for practice").isFalse(); } /**