Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance: Scores page creates many API requests to the ide-settings endpoint #9559

Open
b-fein opened this issue Oct 22, 2024 · 3 comments
Open

Performance: Scores page creates many API requests to the ide-settings endpoint #9559

b-fein opened this issue Oct 22, 2024 · 3 comments
Labels
bug performance priority:critical programming Pull requests that affect the corresponding module

Comments

@b-fein
Copy link
Contributor

b-fein commented Oct 22, 2024 •
edited
Loading

Describe the bug

The scores page for programming exercises contains the </> Code button for every student. Every one of those buttons makes a request to the /api/ide-settings endpoint.

To Reproduce

  • Instructor
  • Programming exercise with a few participants
  1. Open the Network tab of the browser dev console.
  2. Go to the Scores page for the exercise.
  3. Observe the many REST calls to the API.

Expected behavior

Only requested once by the client as part of the user information or similar and cached.

Screenshots

No response

Which version of Artemis are you seeing the problem on?

7.5.6

What browsers are you seeing the problem on?

Firefox

Additional context

No response

Relevant log output

No response
@b-fein b-fein added bug performance programming Pull requests that affect the corresponding module labels Oct 22, 2024
@github-actions github-actions bot added assessment Pull requests that affect the corresponding module core Pull requests that affect the corresponding module exercise Pull requests that affect the corresponding module iris Pull requests that affect the corresponding module text Pull requests that affect the corresponding module labels Oct 22, 2024
@b-fein b-fein removed assessment Pull requests that affect the corresponding module core Pull requests that affect the corresponding module exercise Pull requests that affect the corresponding module iris Pull requests that affect the corresponding module text Pull requests that affect the corresponding module labels Oct 22, 2024
@github-actions github-actions bot added assessment Pull requests that affect the corresponding module core Pull requests that affect the corresponding module exercise Pull requests that affect the corresponding module iris Pull requests that affect the corresponding module text Pull requests that affect the corresponding module labels Oct 22, 2024
@b-fein
Copy link
Contributor Author

b-fein commented Oct 22, 2024

Related PR #9201

/cc @janthoXO

@b-fein b-fein removed assessment Pull requests that affect the corresponding module core Pull requests that affect the corresponding module exercise Pull requests that affect the corresponding module iris Pull requests that affect the corresponding module text Pull requests that affect the corresponding module labels Oct 22, 2024
@janthoXO janthoXO self-assigned this Oct 23, 2024
@krusche krusche assigned krusche and unassigned janthoXO Oct 25, 2024
@krusche
Copy link
Member

krusche commented Oct 25, 2024

Fixed in d3ddb92

@krusche krusche closed this as completed Oct 25, 2024
@janthoXO
Copy link
Contributor

d3ddb92 was only a temporary fix. i will provide a fix in an upcoming PR

@janthoXO janthoXO reopened this Oct 25, 2024
@janthoXO janthoXO assigned janthoXO and unassigned krusche Oct 25, 2024
@janthoXO janthoXO mentioned this issue Oct 25, 2024
Closed
25 tasks
@janthoXO janthoXO linked a pull request Oct 25, 2024 that will close this issue
Programming exercises: Fix performance bug of ide preferences in scores page #9596
Closed
25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug performance priority:critical programming Pull requests that affect the corresponding module
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Programming exercises: Fix performance bug of ide preferences in scores page ls1intum/Artemis
3 participants
@krusche @b-fein @janthoXO