Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Intervals KS test for distribution fit is one-sided, should be two-sided? #108

Closed
brews opened this issue Sep 8, 2017 · 2 comments
Closed

Intervals KS test for distribution fit is one-sided, should be two-sided? #108

brews opened this issue Sep 8, 2017 · 2 comments
Assignees
@brews
Labels
bug Something isn't working
Milestone
v0.2.1

Comments

@brews
Copy link
Member

brews commented Sep 8, 2017

Intervals KS test for distribution fit is one-sided. Need to correct and confirm that it should be two-sided, in alignment with the original Henry papers/code.
@brews brews added the bug Something isn't working label Sep 8, 2017
@brews brews self-assigned this Sep 8, 2017
@brews brews added this to the v0.2.1 milestone Sep 8, 2017
@brews
Copy link
Member Author

brews commented Sep 8, 2017

Yo @chguiterman,
I pushed these changes to the dev branch along with fixes for #109. This deals with the immediate issues found in our last meet. Would you kindly check the KS test output when printing intervals objects and be sure that we have the alt. hypothesis correct?

Let me know how that goes. It would be nice to have this patch out before Sept 18th.

@brews
Copy link
Member Author

brews commented Sep 8, 2017

Note that I also changed the explanation text when printing intervals. It should be more explicit now.

@brews brews closed this as completed in 3213d34 Sep 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brews brews

Labels
bug Something isn't working
Projects
None yet
Milestone
v0.2.1
Development

No branches or pull requests
1 participant
@brews