Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch data format issues in sea()? #112

Closed
chguiterman opened this issue Oct 28, 2017 · 1 comment
Closed

Catch data format issues in sea()? #112

chguiterman opened this issue Oct 28, 2017 · 1 comment
Assignees
Labels
bug Something isn't working
Milestone

Comments

@chguiterman
Copy link
Contributor

Currently there is no catch if a user inputs data in an unexpected format to sea().

For example, if x is a tree-ring reconstruction with two columns "Year" and "Recon", and with normally ascending row names, the function will log an error code pointing to line 177 in sea.R.

The x variable needs to have row names as years that match those in the event list.

Also, if a user provides a data.frame for event, sea will not function. The event variable needs to be either a vector or an fhx object with a single series.

Should catch functions be included to either adjust for these inputs or flag them meaningfully for the user?

@brews brews added the bug Something isn't working label Oct 30, 2017
@brews
Copy link
Member

brews commented Oct 30, 2017

Yes. We should be careful about this. Maybe add code to catch the worse-cases of bad formatting. Also might be good to be more explicit about this in the documentation.

@brews brews added this to the v0.2.2 milestone Oct 30, 2017
@brews brews self-assigned this Jan 1, 2018
@brews brews closed this as completed in c3bc1b4 Jan 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants