Add new dormant fire scar factors

[chguiterman]

Increasingly, we're realizing that the generic D for dormant_fs is not adequate in systems wit fall dormant scars, or where we want to differentiate fall from spring season dormant scars. Importantly, in the Northern Hemisphere this changes the year of the fire,and has meaningful ecological ramifications everywhere.

The FHX codes are F for fall dormant, and S for spring dormant. Need to add these t the levels recognized by burnr.

[brews]

Sorry for the delay to reply, been at AGU.

General question for @chguiterman, how likely is it that we're going to have more of these unique seasons pop up? I think we'd have to change some seasonal calculations and aggregations...

Thinking long term: is there any point in generalizing this to the point were people can just define their own symbols or would that be too generalized?

[brews]

Idea: We would need to have R spit out a warning if a user write an FHX object to an FHX file with these new seasons. The warning would need to explain how the file might not be compatible with other fire history software.

[petebrew]

Just to chip in here... adding bespoke event designations makes me terribly sad. Tinkering with file formats to work around deficiencies is why the Tucson format is so fubar. There are dozens of reasons why the FHX format is not good enough, that's why we had the PAGES meeting back in August to discuss ways forward. Forking the FHX format is definitely not the way forward in my opinion!

[brews]

Yeah, I hear you @petebrew . But, I'm not going to stop people from doing the research they want just because we don't have a suitable, standard file format.

What if we prevented people from writing an FHX2 format file if it doesn't fit the format? -- Print a clear error message. People who want to experiment or try new stuff can write the data to a dumb CSV (basically a list of series names, years, and events). This would preserve the FHX format.

[petebrew]

I think refusing to write FHX files that don't fit the format would be a very good compromise and makes the most sense. If you were writing a new word processor you wouldn't have it create DOCX files that couldn't be read by MS Word or other word processors. So if they attempt to write an FHX file with information above and beyond that which the format supports, then either refuse, or make it a 'lossy' write where it only includes the data that the format does support.

[brews]

New seasons to consider:

• Fall dormant: F, falldormant_fs
• Spring dormant: S, springdormant_fs
• Transition: T, transition_fs
• Early latewood: Y, earlylw_fs
• Late latewood: W, latelw_fs
  These should be matched by injuries (*_fi) in addition to scars.

[brews]

Closing this for now due to lack of interest.