Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Landmark icon #358

Closed
connium opened this issue Jul 17, 2021 · 16 comments · Fixed by #406
Closed

Landmark icon #358

connium opened this issue Jul 17, 2021 · 16 comments · Fixed by #406

Comments

@connium
Copy link
Contributor

connium commented Jul 17, 2021

Icon Request

  • Icon name: bank, landmark
  • Use case: bank, building, business, capitol, landmark
  • Screenshots of similar icons:

In #347 and #350 bank icons are provided. AFAICS the icons do not fully match the Icon Design Guide.

I adapted the proposed icons, but I'm not quite sure which one fits best. So I present them here before creating a PR. Any hints are welcome!

  1. Square base, 1px spacing
    landmark-1px

  2. Square base, 2px spacing
    landmark-2px

  3. Single base line, 2px spacing
    landmark-base-1-2px

  4. Double base line, 1px spacing
    landmark-base-2-1px

  5. Double base line, 2px spacing
    landmark-base-2-2px

  6. Double base line, 2px spacing, 1px baseline spacing (one could argue that the two base lines belong to the same structural element)
    landmark-base-2-1px-2px

Please let me know for which one I should create a PR.

@BeezBeez
Copy link

Thanks for the time spent on the bank icon !

@BeezBeez
Copy link

I personally prefer the 4th icon (Double base line, 1px spacing)

@ghost
Copy link

ghost commented Aug 2, 2021

the icon guidelines actually say that

Distinct elements must have 2 pixels of spacing between each other.

so I would go with the 5

@ericfennis
Copy link
Member

I like number 4th or the 5th one the most.

@lukas-schaetzle
Copy link
Contributor

I like number 6 the most.

@ghost
Copy link

ghost commented Aug 4, 2021

but the 1, the 4 and the 6 break the 2px spacing rule

@connium
Copy link
Contributor Author

connium commented Aug 4, 2021

The guidelines say that

Distinct elements must have 2 pixels of spacing between each other.

I created the 1px versions because to me it is not clear what is meant with "distinct elements".

  • If each SVG element, that does not touch another element, counts as a distinct element, then 2, 3, 5 are the only valid ones.
  • If base, pillars and roof of the building count as distinct elements, then 2, 3, 5, 6 are valid.
  • If the building itself is a distinct element (in this case a building and a mountain in the same icon are two distinct elements), then all variants adhere to the guidelines.

Since I am unsure what is meant to be a distinct element and which is the best variant, I leave the decision to the community ;-)

@ghost
Copy link

ghost commented Aug 5, 2021

I think that each path that does not touch another element counts as a distinct element

@ericfennis
Copy link
Member

What @delnyn says. So 2,3 and 5 are valid according to the guidelines. Maybe 6 can be allowed (because the stairs)🤔 , but that's only if it is a 'better' option.

@ericfennis
Copy link
Member

Are the icons from #347 and #350 also in this list?

@ericfennis ericfennis changed the title Bank icon Landmark icon Aug 12, 2021
@ghost
Copy link

ghost commented Aug 12, 2021

my favorite is the 3

@connium
Copy link
Contributor Author

connium commented Aug 21, 2021

Are the icons from #347 and #350 also in this list?

Not exactly. The one from #347 is similar to 4 but doesn't use the full height of the view box. The icon from #350 is close to 2.

@connium
Copy link
Contributor Author

connium commented Aug 21, 2021

Counting the votes in the comments before gives me

  • 3: 1 vote
  • 4: 2 votes
  • 5: 1 vote
  • 6: 1 vote

Considering that icon 4 is not a valid option, I still don't know for which icon I should create a PR 😕

@ghost
Copy link

ghost commented Aug 21, 2021

I really think the 3 fits better with the rest of the set

@ericfennis
Copy link
Member

@connium We discussed this in the discord channel, and we're in for number 3. You okay with that?

@connium
Copy link
Contributor Author

connium commented Sep 22, 2021

@ericfennis I'm totally fine with this decision. Thanks for taking care of it!

I just created a pull request for the icon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants