-
-
Notifications
You must be signed in to change notification settings - Fork 595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Landmark icon #358
Comments
Thanks for the time spent on the bank icon ! |
I personally prefer the 4th icon (Double base line, 1px spacing) |
the icon guidelines actually say that
so I would go with the 5 |
I like number 4th or the 5th one the most. |
I like number 6 the most. |
but the 1, the 4 and the 6 break the 2px spacing rule |
The guidelines say that
I created the 1px versions because to me it is not clear what is meant with "distinct elements".
Since I am unsure what is meant to be a distinct element and which is the best variant, I leave the decision to the community ;-) |
I think that each path that does not touch another element counts as a distinct element |
What @delnyn says. So 2,3 and 5 are valid according to the guidelines. Maybe 6 can be allowed (because the stairs)🤔 , but that's only if it is a 'better' option. |
my favorite is the 3 |
Counting the votes in the comments before gives me
Considering that icon 4 is not a valid option, I still don't know for which icon I should create a PR 😕 |
I really think the 3 fits better with the rest of the set |
@connium We discussed this in the discord channel, and we're in for number 3. You okay with that? |
@ericfennis I'm totally fine with this decision. Thanks for taking care of it! I just created a pull request for the icon. |
Icon Request
In #347 and #350 bank icons are provided. AFAICS the icons do not fully match the Icon Design Guide.
I adapted the proposed icons, but I'm not quite sure which one fits best. So I present them here before creating a PR. Any hints are welcome!
Square base, 1px spacing
![landmark-1px](https://user-images.githubusercontent.com/3909302/126034433-0c13061b-3671-48e3-95f7-7530dc703a38.png)
Square base, 2px spacing
![landmark-2px](https://user-images.githubusercontent.com/3909302/126034476-cf1b23bf-7595-4d50-b915-b477ae060f3a.png)
Single base line, 2px spacing
![landmark-base-1-2px](https://user-images.githubusercontent.com/3909302/126034485-26d0fae2-0f18-4c08-b2a8-bc2d0d03c670.png)
Double base line, 1px spacing
![landmark-base-2-1px](https://user-images.githubusercontent.com/3909302/126034494-01ed5137-54fc-418f-887f-3d60d124f4b7.png)
Double base line, 2px spacing
![landmark-base-2-2px](https://user-images.githubusercontent.com/3909302/126034500-695a39af-3602-4679-93ec-9b0de88a8bdf.png)
Double base line, 2px spacing, 1px baseline spacing (one could argue that the two base lines belong to the same structural element)
![landmark-base-2-1px-2px](https://user-images.githubusercontent.com/3909302/126034561-763128b4-14fa-4d48-b9e5-5d4af1ca24b2.png)
Please let me know for which one I should create a PR.
The text was updated successfully, but these errors were encountered: