Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicit casting instead of autocasting #35

Open
lminer opened this issue Sep 12, 2024 · 0 comments
Open

Explicit casting instead of autocasting #35

lminer opened this issue Sep 12, 2024 · 0 comments

Comments

@lminer
Copy link

lminer commented Sep 12, 2024

torch.compile doesn't play nicely with amp autocasting and occasionally there are issues when exporting to onnx or other formats. Would explicit fasting to float and back be preferrable. This appears to be the torchtune approach: https://pytorch.org/torchtune/stable/_modules/torchtune/modules/position_embeddings.html
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lminer