fix: pipeline with transactions causes unhandled warnings #884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pipeline#exec() is a little tricky: it has a init process when called first time (indicated by whether Pipeline#nodeifiedPromise is true). Transaction#exec() is similar to that, it has a init process that parse the result from Pipeline#exec before returning to users. However, #nodeifiedPromise is not checked here. Closes: #883
luin
force-pushed
the
fix/transaction-cluster-retries
branch
from
f805e2d to
7b3489f
Compare
|
The patch resolves the issue with my reproduction setup, but the new test passes with and without the change. |
|
@jstewmon You're right. Just fixed. |
|
LGTM! Thanks for addressing so quickly! |
|
🎉 This PR is included in version 4.10.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
janus-dev87
added a commit
to janus-dev87/ioredis-work
that referenced
this pull request
Mar 1, 2024
## [4.10.2](redis/ioredis@v4.10.1...v4.10.2) (2019-06-08) ### Bug Fixes * pipeline with transactions causes unhandled warnings ([#884](redis/ioredis#884)) ([bbfd2fc](redis/ioredis@bbfd2fc)), closes [#883](redis/ioredis#883)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pipeline#exec()is a little tricky: it has an init process when called first time (indicated by whetherPipeline#nodeifiedPromiseis true).Transaction#exec()is similar to that, it also has an init process that parse the result fromPipeline#exec()before returning to users. However,#nodeifiedPromiseis not checked here, so it may fail which causes the unhandled warnings when retries.Closes: #883.
To be frank, it also take me a lot of time in order to understand the code, especially the complex relation between Pipeline & Transaction. We indeed need to do a refactor on this.