-
-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] TypeError: path.dirname is not a function #25
Comments
Honestly, not seeing that issue happen in the given repro. It seems to be working fine for me. |
Thanks for taking a look! You don't see the error in the DevTools console? I see it using Edge & Chrome browsers. |
Yeah, see it now. Had some wrong filters set in devtools console 🤦 |
Just ran into this, I'm using vite as well (with svelte kit). |
Same problem for me :( |
@miraries can you please share what exactly and how did you use from that gist? I am looking into it but there are so much stuff that I cannot understand what I should take from it... |
@valerii15298 Do export default defineConfig({
resolve: {
alias: {
path: 'rollup-plugin-node-polyfills/polyfills/path'
}
}
}); this just adds a polyfill for the |
@miraries thank you very much!!! |
@miraries btw, I made it work by installing only |
I'm also having the error as #9, 'path.dirname is not a function'. I have tried importing from 'monaco-editor-auto-typings/custom-editor' and passing in a monaco instance.
I am using Lit, TS & Vite and the latest version of monaco-editor-auto-typings.
Here's a minimal repro
I am not savvy when it comes to build processes, so maybe there is a Vite/Rollup setting I'm missing.
Any tips appreciated! :)
The text was updated successfully, but these errors were encountered: