Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: migrate to mason.nvim #2880

Merged
merged 7 commits into from
Aug 9, 2022
Merged

refactor!: migrate to mason.nvim #2880

merged 7 commits into from
Aug 9, 2022

Conversation

kylo252
Copy link
Collaborator

@kylo252 kylo252 commented Aug 5, 2022

Description

mason.nvim is the next generation version of nvim-lsp-installer. It builds on
top of the very same foundation as nvim-lsp-installer, but with a majority of
internals refactored to improve extensibility and testability.

fixes #2850

TODOs

  • replace nvim-lsp-installer completely
  • ensure that template generation still works
  • fix data-race on server install (on_server_ready has been removed..)
  • make sure no deprecated/outdated commands exist (how to replace LspInstallInfo?)
  • add null-ls integration (requires a separate PR)
  • add DAP integration (requires a separate PR)

@kylo252 kylo252 marked this pull request as ready for review August 6, 2022 10:14
@kylo252 kylo252 force-pushed the mason-integration branch from 52fbf93 to 7162cf3 Compare August 9, 2022 08:37
@kylo252 kylo252 merged commit eefde00 into rolling Aug 9, 2022
@kylo252 kylo252 deleted the mason-integration branch August 9, 2022 08:41
@ghost
Copy link

ghost commented Aug 10, 2022

This completely broke my rust-tools configuration which is 1:1 from https://www.lunarvim.org/languages/rust.html#extra-plugins.

Are those random breaking changes supposed to happen in rolling? Then a more suited branch name would be 'unstable' instead.

@kylo252
Copy link
Collaborator Author

kylo252 commented Aug 10, 2022

This completely broke my rust-tools configuration which is 1:1 from https://www.lunarvim.org/languages/rust.html#extra-plugins.

just remove all references to lsp-installer and it should work.

Are those random breaking changes supposed to happen in rolling? Then a more suited branch name would be 'unstable' instead.

there's a reason why the master branch exists along with its version releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

migrate to mason.nvim
2 participants