Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(telecope): set show_untracked by default #2984

Merged
merged 2 commits into from
Sep 20, 2022

Conversation

pschmitt
Copy link
Contributor

@pschmitt pschmitt commented Sep 3, 2022

Description

  • add the ability to display untracked files by default when invoking find_project_files
  • can be turned off by setting the show_untracked to false.

How Has This Been Tested?

-- show untracked files
require('lvim.core.telescope.custom-finders').find_project_files()

-- skip untracked files
require('lvim.core.telescope.custom-finders').find_project_files({show_untracked = false})

Copy link
Collaborator

@kylo252 kylo252 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm in favor of making this a default behavior actually! in that case, we'd have it set in telescope's config table, and it could still be overridden.

cc: @abzcoding, @rebuilt

@chris-ricketts
Copy link

I agree this should be the default. I'm actually pretty sure it used to be for the default <space>-f "find files" keybinding but it was changed at some point.

@kylo252 kylo252 changed the title feat: optionally show untracked files with find_project_files feat(telecope): set show_untracked by default Sep 15, 2022
@kylo252 kylo252 force-pushed the git-opt-show-untracked branch 4 times, most recently from 995f917 to d19b667 Compare September 15, 2022 13:03
@kylo252 kylo252 force-pushed the git-opt-show-untracked branch from d19b667 to 7bb7806 Compare September 15, 2022 13:04
@kylo252 kylo252 requested a review from lvimuser September 15, 2022 13:06
Copy link
Member

@abzcoding abzcoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@abzcoding abzcoding merged commit 03ec312 into LunarVim:rolling Sep 20, 2022
@pschmitt pschmitt deleted the git-opt-show-untracked branch September 20, 2022 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants