Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cosmos address component #1173

Closed
jbibla opened this issue Aug 21, 2018 · 13 comments
Closed

Cosmos address component #1173

jbibla opened this issue Aug 21, 2018 · 13 comments
Assignees

Comments

@jbibla
Copy link
Collaborator

jbibla commented Aug 21, 2018

the UI can abbreviate addresses and pubkeys for a friendlier and less cluttered UI.

though, bech32 prefixes have made our address a bit more readable - they are still for computers (let's be honest).

i'd like to propose that we abbreviate addresses and pubkeys - the tooltip could display the full address. see below.

this will result in a more readable, less overwhelming, cleaner UI. 🥇

cosmosvalpub12ztjt9nfj20cxw4w4fdg5g0lak83mc23csqzgx
cosmosvalpub...qzgx

cosmosaccaddr1qk2q3l28t6qhzyc7psdffsdf832ep8uwdaer
cosmosaccaddr...daer
@faboweb
Copy link
Collaborator

faboweb commented Aug 28, 2018

I vote yes. We probably need to show some letters in the beginning and some in the end.

@jbibla
Copy link
Collaborator Author

jbibla commented Aug 28, 2018

are you proposing the following? not sure if i agree. would like others to weigh in. we have these nifty bech32 prefixes which might be "enough".

cosmosvalpub12zt...qzgx
cosmosaccaddr1qk2...daer

@faboweb
Copy link
Collaborator

faboweb commented Aug 28, 2018

Yes this is what I mean. Just for a sense of security.

@NodeGuy
Copy link
Contributor

NodeGuy commented Aug 30, 2018

Do you mean "elide" instead of "concatenate"?

@jbibla
Copy link
Collaborator Author

jbibla commented Aug 31, 2018

update from SDK (can't find the issue):

cosmosval12zt...qzgx
cosmos1qk2...daer

or

cosmosval...qzgx
cosmos...daer

Do you mean "elide" instead of "concatenate"?

hard to say.

@faboweb
Copy link
Collaborator

faboweb commented Aug 31, 2018

Hö? They renamed cosmosaccaddr to cosmos?

@jbibla
Copy link
Collaborator Author

jbibla commented Aug 31, 2018

i believe so - @jackzampolin can you link the ticket? i'm sorry, i can't find it 😞

@NodeGuy
Copy link
Contributor

NodeGuy commented Aug 31, 2018

Do you mean this PR? cosmos/cosmos-sdk#2103

@NodeGuy
Copy link
Contributor

NodeGuy commented Aug 31, 2018

This proposal is about abbreviating addresses. Concatenate means to link together in a series or chain.

@NodeGuy NodeGuy changed the title should we concatenate addresses and pubkeys? should we abbreviate addresses and pubkeys? Aug 31, 2018
@NodeGuy
Copy link
Contributor

NodeGuy commented Aug 31, 2018

Sounds good to me.

@jackzampolin
Copy link

@jbibla cosmos/cosmos-sdk#2103 🙇

@faboweb faboweb changed the title should we abbreviate addresses and pubkeys? Cosmos address component Sep 11, 2018
@faboweb faboweb removed the discuss label Sep 11, 2018
@faboweb
Copy link
Collaborator

faboweb commented Sep 11, 2018

add copying #1174

@fedekunze
Copy link
Contributor

fedekunze commented Oct 4, 2018

@jbibla I'm not fully understanding what are we suppose to implement on the component and what are the functionalities of it. Does it just need an additional tooltip ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants