Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate linting job on CircleCI #1842

Closed
sabau opened this issue Jan 16, 2019 · 2 comments
Closed

Separate linting job on CircleCI #1842

sabau opened this issue Jan 16, 2019 · 2 comments
Labels
refactor

Comments

@sabau
Copy link
Contributor

sabau commented Jan 16, 2019

Thanks to @fedekunze review I was thinking we have some low hanging fruits improvement:

  • Separation of concerns: Having a separate job could make it easier to read the outcome.
  • Fast failure: It allows us also to do static file check quickly and not even run other jobs if we know that this will fail anyway
@sabau sabau added discuss low priority has been discussed, will be addressed later refactor labels Jan 16, 2019
@fedekunze
Copy link
Contributor

we already agreed to implement this on the other issue (this is a dup)

@fedekunze fedekunze removed discuss low priority has been discussed, will be addressed later labels Jan 16, 2019
@faboweb faboweb closed this as completed Jan 17, 2019
@faboweb faboweb reopened this Jan 17, 2019
@faboweb
Copy link
Collaborator

faboweb commented Jan 17, 2019

#1221

@faboweb faboweb closed this as completed Jan 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sabau @faboweb @fedekunze