Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache user address for querying accounts #1953

Closed
fedekunze opened this issue Feb 11, 2019 · 3 comments
Closed

Cache user address for querying accounts #1953

fedekunze opened this issue Feb 11, 2019 · 3 comments

Comments

@fedekunze
Copy link
Contributor

Description:

we should cache the user.address to query the account balance, delegations, transactions, etc as stated in #1638

Note that it's different from the wallet.address as the first can change for different address look up (See #1719), while the 2 is the ledger/ keystore address for signing txs

@faboweb
Copy link
Collaborator

faboweb commented Feb 12, 2019

Note that it's different from the wallet.address as the first can change for different address look up (See #1719), while the 2 is the ledger/ keystore address for signing txs

we need to redesign transaction lookup. wallet.address will probably not be used when we implement this.

@fedekunze
Copy link
Contributor Author

we use it to send txs (eg: from ledger.pubKey() get the account address and set it to wallet.address)

@faboweb
Copy link
Collaborator

faboweb commented Feb 12, 2019

wallet.address should probably not be used for sending either but user.address as a single source of truth for the session a user is logged in with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants