From d11b33406269511332c79adf0e45acc6388ea124 Mon Sep 17 00:00:00 2001
From: Federico Kunze <fekunze@berkeley.edu>
Date: Fri, 30 Nov 2018 15:59:00 +0100
Subject: [PATCH 01/20] gov params tab

---
 .../components/governance/PageGovernance.vue  |   2 +-
 .../components/governance/TabParameters.vue   | 272 ++++++++++++++++++
 app/src/renderer/routes.js                    |   5 +
 app/src/renderer/vuex/getters.js              |   3 +-
 4 files changed, 280 insertions(+), 2 deletions(-)
 create mode 100644 app/src/renderer/components/governance/TabParameters.vue

diff --git a/app/src/renderer/components/governance/PageGovernance.vue b/app/src/renderer/components/governance/PageGovernance.vue
index ebb5f6449b..cf2471c684 100644
--- a/app/src/renderer/components/governance/PageGovernance.vue
+++ b/app/src/renderer/components/governance/PageGovernance.vue
@@ -49,7 +49,7 @@ export default {
   },
   data: () => ({
     query: ``,
-    tabs: [`Proposals`],
+    tabs: [`Proposals`, `Parameters`],
     showModalPropose: false
   }),
   computed: {
diff --git a/app/src/renderer/components/governance/TabParameters.vue b/app/src/renderer/components/governance/TabParameters.vue
new file mode 100644
index 0000000000..569c64b525
--- /dev/null
+++ b/app/src/renderer/components/governance/TabParameters.vue
@@ -0,0 +1,272 @@
+<template>
+  <div v-if="config.devMode">
+    <div>
+      <h3>
+        Deposit Parameters
+        <i
+          v-tooltip.top="depositTooltips.description"
+          class="material-icons info-button"
+          >info_outline</i
+        >
+      </h3>
+      <div class="parameters__details parameters__section">
+        <div class="row">
+          <div class="column">
+            <dl class="info_dl">
+              <dt>
+                Minimum Deposit
+                <i
+                  v-tooltip.top="depositTooltips.min_deposit"
+                  class="material-icons info-button"
+                  >info_outline</i
+                >
+              </dt>
+              <dd>
+                {{
+                  govParameters.deposit.min_deposit
+                    ? govParameters.deposit.min_deposit
+                    : `n/a`
+                }}
+              </dd>
+            </dl>
+          </div>
+          <div class="column">
+            <dl class="info_dl">
+              <dt>
+                Maximum Deposit Period
+                <i
+                  v-tooltip.top="depositTooltips.max_deposit_period"
+                  class="material-icons info-button"
+                  >info_outline</i
+                >
+              </dt>
+              <dd>
+                {{
+                  parameters.parameters.max_deposit_period
+                    ? depositPeriodInDays + ` days`
+                    : `n/a`
+                }}
+              </dd>
+            </dl>
+          </div>
+        </div>
+      </div>
+    </div>
+    <div>
+      <h3>
+        Tally Parameters
+        <i
+          v-tooltip.top="tallyingTooltips.description"
+          class="material-icons info-button"
+          >info_outline</i
+        >
+      </h3>
+      <div class="parameters__details parameters__section">
+        <div class="row">
+          <div class="column">
+            <dl class="info_dl">
+              <dt>
+                Threshold
+                <i
+                  v-tooltip.top="tallyingTooltips.threshold"
+                  class="material-icons info-button"
+                  >info_outline</i
+                >
+              </dt>
+              <dd>
+                {{
+                  parameters.parameters.threshold
+                    ? parameters.parameters.threshold
+                    : `n/a`
+                }}
+              </dd>
+            </dl>
+            <dl class="info_dl">
+              <dt>
+                Veto
+                <i
+                  v-tooltip.top="tallyingTooltips.veto"
+                  class="material-icons info-button"
+                  >info_outline</i
+                >
+              </dt>
+              <dd>
+                {{
+                  parameters.parameters.veto
+                    ? parameters.parameters.veto
+                    : `n/a`
+                }}
+              </dd>
+            </dl>
+          </div>
+          <div class="column">
+            <dl class="info_dl">
+              <dt>
+                Governance Penalty
+                <i
+                  v-tooltip.top="tallyingTooltips.governance_penalty"
+                  class="material-icons info-button"
+                  >info_outline</i
+                >
+              </dt>
+              <dd>
+                {{
+                  parameters.parameters.governance_penalty
+                    ? parameters.parameters.governance_penalty
+                    : `n/a`
+                }}
+              </dd>
+            </dl>
+          </div>
+        </div>
+      </div>
+    </div>
+    <div>
+      <h3>
+        Voting Parameters
+        <i
+          v-tooltip.top="votingTooltips.description"
+          class="material-icons info-button"
+          >info_outline</i
+        >
+      </h3>
+      <div class="parameters__details parameters__section">
+        <div class="row">
+          <div class="column">
+            <dl class="info_dl">
+              <dt>
+                Voting Period
+                <i
+                  v-tooltip.top="depositTooltips.voting_period"
+                  class="material-icons info-button"
+                  >info_outline</i
+                >
+              </dt>
+              <dd>
+                {{
+                  govParameters.voting.voting_period
+                    ? votingPeriodInDays + ` days`
+                    : `n/a`
+                }}
+              </dd>
+            </dl>
+          </div>
+          <div class="column"></div>
+        </div>
+      </div>
+    </div>
+  </div>
+</template>
+
+<script>
+import { mapGetters } from "vuex"
+import { TmBtn, TmListItem, TmPage, TmPart, TmToolBar } from "@tendermint/ui"
+export default {
+  name: `tab-staking-parameters`,
+  components: {
+    TmBtn,
+    TmListItem,
+    TmPage,
+    TmPart,
+    TmToolBar
+  },
+  data: () => ({
+    depositTooltips: {
+      description: `Parameters around proposals' deposits on governance`,
+      min_deposit: `Minimum deposit for a proposal to enter voting period`,
+      max_deposit_period: `Maximum period for token holders to deposit on a proposal`
+    },
+    tallyingTooltips: {
+      description: `Parameters around tallying votes in governance`,
+      threshold: `Minimum propotion of Yes votes for proposal to pass`,
+      veto: `Minimum value of Veto votes to Total votes ratio for proposal to be vetoed`,
+      governance_penalty: `Penalty if validator does not vote`
+    },
+    votingTooltips: {
+      description: `Parameters around voting on governance proposals`,
+      voting_period: `Length of the voting period`
+    }
+  }),
+  computed: {
+    ...mapGetters([`config`, `govParameters`]),
+    // TODO: a minimum deposit may consist of multiple coin denoms
+    minumimDeposit() {
+      let coin = this.govParameters.deposit.min_deposit[0]
+      return `${coin.amount} ${coin.denom}`
+    },
+    depositPeriodInDays() {
+      return (
+        parseInt(this.govParameters.deposit.max_deposit_period) /
+        (10 ** 9 * 60 * 60 * 24)
+      )
+    },
+    votingPeriodInDays() {
+      return (
+        parseInt(this.govParameters.voting.voting_period) /
+        (10 ** 9 * 60 * 60 * 24)
+      )
+    }
+  },
+  async mounted() {
+    this.$store.dispatch(`getGovParameters`)
+  }
+}
+</script>
+<style>
+.parameters__details > .row > .column {
+  flex: 1;
+}
+
+.parameters__section {
+  background-color: var(--app-fg);
+  display: flex;
+  margin-bottom: 1rem;
+  padding: 2rem;
+  width: 100%;
+}
+
+h3 {
+  margin: 1em auto;
+}
+
+.info-button {
+  color: var(--link);
+}
+
+.column {
+  display: flex;
+  flex-flow: column;
+  position: relative;
+}
+
+.row {
+  display: flex;
+  flex-direction: row;
+  width: 100%;
+}
+
+.info_dl {
+  display: flex;
+  flex-flow: column;
+  margin-bottom: 1.5rem;
+  margin-right: 1rem;
+}
+
+.info_dl dt {
+  color: var(--dim);
+  font-size: small;
+  margin-bottom: 4px;
+}
+
+.info_dl dd {
+  border: 1px solid var(--white-fade-2);
+  border-radius: 2px;
+  font-size: 1rem;
+  line-height: 1rem;
+  padding: 0.5rem;
+}
+
+.info_dl dd.info_dl__text-box {
+  min-height: 6.91rem;
+}
+</style>
diff --git a/app/src/renderer/routes.js b/app/src/renderer/routes.js
index 779e36a253..ceb681e5b9 100644
--- a/app/src/renderer/routes.js
+++ b/app/src/renderer/routes.js
@@ -18,6 +18,11 @@ export default [
         path: `proposals`,
         name: `Proposals`,
         component: require(`./components/governance/TabProposals`).default
+      },
+      {
+        path: `governance-parameters`,
+        name: `Parameters`,
+        component: require(`./components/governance/TabParameters`).default
       }
     ]
   },
diff --git a/app/src/renderer/vuex/getters.js b/app/src/renderer/vuex/getters.js
index 181686f54d..01cbc1d1ab 100644
--- a/app/src/renderer/vuex/getters.js
+++ b/app/src/renderer/vuex/getters.js
@@ -64,12 +64,13 @@ export const shoppingCart = state => state.delegation.delegates
 export const validators = state => state.validators.validators
 export const keybase = state => state.keybase.identities
 export const pool = state => state.pool
-export const parameters = state => state.parameters
+export const stakingParameters = state => state.stakingParameters
 
 // governance
 export const proposals = state => state.proposals.proposals
 export const votes = state => state.votes.votes
 export const deposits = state => state.deposits.deposits
+export const governanceParameters = state => state.governanceParameters
 
 // status
 export const approvalRequired = state => state.connection.approvalRequired

From fa7e4816d1f024a6c57bb34f603094cca3e988a2 Mon Sep 17 00:00:00 2001
From: Federico Kunze <fekunze@berkeley.edu>
Date: Mon, 3 Dec 2018 15:40:33 +0100
Subject: [PATCH 02/20] keep fixing params

---
 .../components/governance/TabParameters.vue   | 18 +++----
 .../components/governance/TableProposals.vue  |  2 +-
 .../components/staking/TabParameters.vue      | 30 +++++++----
 app/src/renderer/connectors/lcdClientMock.js  | 14 +++---
 .../vuex/modules/governance/parameters.js     |  4 +-
 app/src/renderer/vuex/modules/index.js        |  3 +-
 app/src/renderer/vuex/modules/parameters.js   |  1 +
 .../components/staking/TabParameters.spec.js  | 13 ++---
 test/unit/specs/lcdClientMock.spec.js         | 16 +++---
 .../specs/store/governance/parameters.spec.js | 18 ++++---
 test/unit/specs/store/parameters.spec.js      | 50 +++++++++----------
 11 files changed, 90 insertions(+), 79 deletions(-)

diff --git a/app/src/renderer/components/governance/TabParameters.vue b/app/src/renderer/components/governance/TabParameters.vue
index 569c64b525..d3b5c77585 100644
--- a/app/src/renderer/components/governance/TabParameters.vue
+++ b/app/src/renderer/components/governance/TabParameters.vue
@@ -1,5 +1,5 @@
 <template>
-  <div v-if="config.devMode">
+  <div>
     <div>
       <h3>
         Deposit Parameters
@@ -23,8 +23,8 @@
               </dt>
               <dd>
                 {{
-                  govParameters.deposit.min_deposit
-                    ? govParameters.deposit.min_deposit
+                  governanceParameters.deposit.min_deposit
+                    ? governanceParameters.deposit.min_deposit
                     : `n/a`
                 }}
               </dd>
@@ -144,7 +144,7 @@
               </dt>
               <dd>
                 {{
-                  govParameters.voting.voting_period
+                  governanceParameters.voting.voting_period
                     ? votingPeriodInDays + ` days`
                     : `n/a`
                 }}
@@ -188,27 +188,27 @@ export default {
     }
   }),
   computed: {
-    ...mapGetters([`config`, `govParameters`]),
+    ...mapGetters([`config`, `governanceParameters`]),
     // TODO: a minimum deposit may consist of multiple coin denoms
     minumimDeposit() {
-      let coin = this.govParameters.deposit.min_deposit[0]
+      let coin = this.governanceParameters.deposit.min_deposit[0]
       return `${coin.amount} ${coin.denom}`
     },
     depositPeriodInDays() {
       return (
-        parseInt(this.govParameters.deposit.max_deposit_period) /
+        parseInt(this.governanceParameters.deposit.max_deposit_period) /
         (10 ** 9 * 60 * 60 * 24)
       )
     },
     votingPeriodInDays() {
       return (
-        parseInt(this.govParameters.voting.voting_period) /
+        parseInt(this.governanceParameters.voting.voting_period) /
         (10 ** 9 * 60 * 60 * 24)
       )
     }
   },
   async mounted() {
-    this.$store.dispatch(`getGovParameters`)
+    this.$store.dispatch(`getgovernanceParameters`)
   }
 }
 </script>
diff --git a/app/src/renderer/components/governance/TableProposals.vue b/app/src/renderer/components/governance/TableProposals.vue
index 56811eb86a..7ffa46044e 100644
--- a/app/src/renderer/components/governance/TableProposals.vue
+++ b/app/src/renderer/components/governance/TableProposals.vue
@@ -45,7 +45,7 @@ export default {
   },
   props: {
     proposals: {
-      type: Array,
+      type: Object,
       required: true
     },
     loading: {
diff --git a/app/src/renderer/components/staking/TabParameters.vue b/app/src/renderer/components/staking/TabParameters.vue
index 4a776d951f..b365f2c1ba 100644
--- a/app/src/renderer/components/staking/TabParameters.vue
+++ b/app/src/renderer/components/staking/TabParameters.vue
@@ -1,5 +1,5 @@
 <template>
-  <div v-if="config.devMode">
+  <div>
     <div>
       <h3 class="staking-pool">
         Staking Pool
@@ -14,7 +14,12 @@
           <div class="column">
             <dl class="info_dl">
               <dt>
-                Loose {{ parameters.parameters.bond_denom }}
+                Loose
+                {{
+                  stakingParameters.parameters.bond_denom
+                    ? stakingParameters.parameters.bond_denom
+                    : `atoms`
+                }}
                 <i
                   v-tooltip.top="poolTooltips.loose_tokens"
                   class="material-icons info-button"
@@ -29,7 +34,12 @@
           <div class="column">
             <dl class="info_dl">
               <dt>
-                Delegated {{ parameters.parameters.bond_denom }}
+                Delegated
+                {{
+                  stakingParameters.parameters.bond_denom
+                    ? stakingParameters.parameters.bond_denom
+                    : `atoms`
+                }}
                 <i
                   v-tooltip.top="poolTooltips.bonded_tokens"
                   class="material-icons info-button"
@@ -67,7 +77,7 @@
               </dt>
               <dd id="unbonding_time">
                 {{
-                  parameters.parameters.unbonding_time
+                  stakingParameters.parameters.unbonding_time
                     ? unbondingTimeInDays + ` days`
                     : `n/a`
                 }}
@@ -77,8 +87,8 @@
               <dt>Current Staking Coin Denomination</dt>
               <dd id="bond_denom">
                 {{
-                  parameters.parameters.bond_denom
-                    ? parameters.parameters.bond_denom
+                  stakingParameters.parameters.bond_denom
+                    ? stakingParameters.parameters.bond_denom
                     : `n/a`
                 }}
               </dd>
@@ -89,8 +99,8 @@
               <dt>Maximum Number of Validators</dt>
               <dd id="max_validators">
                 {{
-                  parameters.parameters.max_validators
-                    ? parameters.parameters.max_validators
+                  stakingParameters.parameters.max_validators
+                    ? stakingParameters.parameters.max_validators
                     : `n/a`
                 }}
               </dd>
@@ -128,10 +138,10 @@ export default {
     }
   }),
   computed: {
-    ...mapGetters([`config`, `parameters`, `pool`]),
+    ...mapGetters([`config`, `stakingParameters`, `pool`]),
     unbondingTimeInDays() {
       return (
-        parseInt(this.parameters.parameters.unbonding_time) /
+        parseInt(this.stakingParameters.parameters.unbonding_time) /
         (10 ** 9 * 60 * 60 * 24)
       )
     }
diff --git a/app/src/renderer/connectors/lcdClientMock.js b/app/src/renderer/connectors/lcdClientMock.js
index c83b800ef6..1adf144456 100644
--- a/app/src/renderer/connectors/lcdClientMock.js
+++ b/app/src/renderer/connectors/lcdClientMock.js
@@ -301,12 +301,12 @@ let state = {
     loose_tokens: `100.0000000000`,
     bonded_tokens: `50.0000000000`
   },
-  parameters: {
+  stakingParameters: {
     unbonding_time: `259200000000000`,
     max_validators: 100,
     bond_denom: `steak`
   },
-  govParameters: {
+  governanceParameters: {
     deposit: {
       min_deposit: [
         {
@@ -752,7 +752,7 @@ module.exports = {
 
       // update sender balance
       let coinBalance = fromAccount.coins.find(
-        c => c.denom === state.parameters.bond_denom
+        c => c.denom === state.stakingParameters.bond_denom
       )
 
       coinBalance.amount = String(parseInt(coinBalance.amount) + amount)
@@ -869,7 +869,7 @@ module.exports = {
       // add redelegation object
       let coins = {
         amount: tx.shares, // in mock mode we assume 1 share = 1 token
-        denom: state.parameters.bond_denom
+        denom: state.stakingParameters.bond_denom
       }
       let minTime = Date.now()
       red = {
@@ -1271,13 +1271,13 @@ module.exports = {
     )
   },
   async getGovDepositParameters() {
-    return state.govParameters.deposit
+    return state.governanceParameters.deposit
   },
   async getGovTallyingParameters() {
-    return state.govParameters.tallying
+    return state.governanceParameters.tallying
   },
   async getGovVotingParameters() {
-    return state.govParameters.voting
+    return state.governanceParameters.voting
   },
   // exports to be used in tests
   state,
diff --git a/app/src/renderer/vuex/modules/governance/parameters.js b/app/src/renderer/vuex/modules/governance/parameters.js
index 8b2595c774..fda1e17808 100644
--- a/app/src/renderer/vuex/modules/governance/parameters.js
+++ b/app/src/renderer/vuex/modules/governance/parameters.js
@@ -2,7 +2,7 @@ import Raven from "raven-js"
 
 export default ({ node }) => {
   const emptyState = {
-    govParameters: {
+    parameters: {
       deposit: {},
       tallying: {},
       voting: {}
@@ -14,7 +14,7 @@ export default ({ node }) => {
 
   const mutations = {
     setGovParameters(state, parameters) {
-      state.govParameters = parameters
+      state.parameters = parameters
     }
   }
 
diff --git a/app/src/renderer/vuex/modules/index.js b/app/src/renderer/vuex/modules/index.js
index fd4bc39486..eeb8d8523b 100644
--- a/app/src/renderer/vuex/modules/index.js
+++ b/app/src/renderer/vuex/modules/index.js
@@ -13,12 +13,13 @@ export default opts => ({
   proposals: require(`./governance/proposals.js`).default(opts),
   votes: require(`./governance/votes.js`).default(opts),
   deposits: require(`./governance/deposits.js`).default(opts),
+  governanceParameters: require(`./governance/parameters.js`).default(opts),
   send: require(`./send.js`).default(opts),
   themes: require(`./themes.js`).default(opts),
   user: require(`./user.js`).default(opts),
   validators: require(`./validators.js`).default(opts),
   wallet: require(`./wallet.js`).default(opts),
   keybase: require(`./keybase.js`).default(opts),
-  parameters: require(`./parameters.js`).default(opts),
+  stakingParameters: require(`./parameters.js`).default(opts),
   pool: require(`./pool.js`).default(opts)
 })
diff --git a/app/src/renderer/vuex/modules/parameters.js b/app/src/renderer/vuex/modules/parameters.js
index 6a24ebc93f..5cd0b58cdf 100644
--- a/app/src/renderer/vuex/modules/parameters.js
+++ b/app/src/renderer/vuex/modules/parameters.js
@@ -9,6 +9,7 @@ export default ({ node }) => {
 
   const mutations = {
     setStakingParameters(state, parameters) {
+      console.log(parameters)
       state.parameters = parameters
     }
   }
diff --git a/test/unit/specs/components/staking/TabParameters.spec.js b/test/unit/specs/components/staking/TabParameters.spec.js
index 9268fee03a..4b0f22c9b9 100644
--- a/test/unit/specs/components/staking/TabParameters.spec.js
+++ b/test/unit/specs/components/staking/TabParameters.spec.js
@@ -4,8 +4,7 @@ import htmlBeautify from "html-beautify"
 import TabParameters from "renderer/components/staking/TabParameters"
 import lcdClientMock from "renderer/connectors/lcdClientMock.js"
 
-let pool = lcdClientMock.state.pool
-let parameters = lcdClientMock.state.parameters
+let { pool, stakingParameters } = lcdClientMock.state
 
 describe(`TabParameters`, () => {
   let wrapper, store
@@ -17,7 +16,7 @@ describe(`TabParameters`, () => {
     dispatch: jest.fn(),
     getters: {
       pool,
-      parameters,
+      stakingParameters,
       totalAtoms: 100,
       user: { atoms: 42 }
     }
@@ -28,12 +27,13 @@ describe(`TabParameters`, () => {
       localVue,
       doBefore: ({ store }) => {
         store.commit(`setPool`, pool)
-        store.commit(`setStakingParameters`, parameters)
+        store.commit(`setStakingParameters`, stakingParameters)
       },
       $store
     })
     wrapper = instance.wrapper
     store = instance.store
+    console.log(store.state.stakingParameters.parameters)
     store.commit(`setConnected`, true)
     wrapper.update()
   })
@@ -44,8 +44,9 @@ describe(`TabParameters`, () => {
     expect(htmlBeautify(wrapper.html())).toMatchSnapshot()
   })
 
-  it(`shows the staking parameters and pool`, () => {
-    expect(store.state.parameters.parameters).toEqual(parameters)
+  it.only(`shows the staking parameters and pool`, () => {
+    console.log(store.state.stakingParameters.parameters)
+    expect(store.state.stakingParameters.parameters).toEqual(stakingParameters)
     expect(store.state.pool.pool).toEqual(pool)
   })
 
diff --git a/test/unit/specs/lcdClientMock.spec.js b/test/unit/specs/lcdClientMock.spec.js
index feefd98b74..0e2a0717a9 100644
--- a/test/unit/specs/lcdClientMock.spec.js
+++ b/test/unit/specs/lcdClientMock.spec.js
@@ -822,17 +822,15 @@ describe(`LCD Client Mock`, () => {
     expect(txs[0].tx.value.msg[0].type).toBe(`cosmos-sdk/BeginUnbonding`)
   })
 
-  it(`queries for staking parameters`, async () => {
+  it.only(`queries for staking parameters`, async () => {
     let parameters = await client.getStakingParameters()
-    expect(Object.keys(parameters)).toContain(
-      `unbonding_time`,
-      `max_validators`,
-      `bond_denom`
-    )
+    expect(parameters).toBeDefined()
+    expect(parameters).toMatchObject(lcdClientMock.state.stakingParameters)
   })
 
   it(`queries for staking pool`, async () => {
     let pool = await client.getPool()
+    expect(pool).toBeDefined()
     expect(Object.keys(pool)).toContain(`loose_tokens`, `bonded_tokens`)
   })
 
@@ -989,21 +987,21 @@ describe(`LCD Client Mock`, () => {
 
     describe(`Parameters`, () => {
       it(`queries for governance deposit parameters`, async () => {
-        let depositParams = lcdClientMock.state.govParameters.deposit
+        let depositParams = lcdClientMock.state.governanceParameters.deposit
         let res = await client.getGovDepositParameters()
         expect(res).toBeDefined()
         expect(res).toEqual(depositParams)
       })
 
       it(`queries for governance tallying parameters`, async () => {
-        let tallyingParams = lcdClientMock.state.govParameters.tallying
+        let tallyingParams = lcdClientMock.state.governanceParameters.tallying
         let res = await client.getGovTallyingParameters()
         expect(res).toBeDefined()
         expect(res).toEqual(tallyingParams)
       })
 
       it(`queries for governance voting parameters`, async () => {
-        let votingParams = lcdClientMock.state.govParameters.voting
+        let votingParams = lcdClientMock.state.governanceParameters.voting
         let res = await client.getGovVotingParameters()
         expect(res).toBeDefined()
         expect(res).toEqual(votingParams)
diff --git a/test/unit/specs/store/governance/parameters.spec.js b/test/unit/specs/store/governance/parameters.spec.js
index 807cbe6a10..332c275909 100644
--- a/test/unit/specs/store/governance/parameters.spec.js
+++ b/test/unit/specs/store/governance/parameters.spec.js
@@ -1,15 +1,17 @@
 import parametersModule from "renderer/vuex/modules/governance/parameters.js"
 import lcdClientMock from "renderer/connectors/lcdClientMock.js"
-let { govParameters } = lcdClientMock.state
+let { governanceParameters } = lcdClientMock.state
 
 describe(`Module: Governance Parameters`, () => {
   let module, node
 
   beforeEach(() => {
     node = {
-      getGovDepositParameters: () => Promise.resolve(govParameters.deposit),
-      getGovTallyingParameters: () => Promise.resolve(govParameters.tallying),
-      getGovVotingParameters: () => Promise.resolve(govParameters.voting)
+      getGovDepositParameters: () =>
+        Promise.resolve(governanceParameters.deposit),
+      getGovTallyingParameters: () =>
+        Promise.resolve(governanceParameters.tallying),
+      getGovVotingParameters: () => Promise.resolve(governanceParameters.voting)
     }
     module = parametersModule({
       node
@@ -18,15 +20,17 @@ describe(`Module: Governance Parameters`, () => {
 
   it(`adds parameters to state`, () => {
     let { mutations, state } = module
-    mutations.setGovParameters(state, govParameters)
-    expect(state.govParameters).toEqual(govParameters)
+    mutations.setGovParameters(state, governanceParameters)
+    expect(state.parameters).toEqual(governanceParameters)
   })
 
   it(`fetches all governance parameters`, async () => {
     let { actions, state } = module
     let commit = jest.fn()
     await actions.getGovParameters({ state, commit })
-    expect(commit.mock.calls).toEqual([[`setGovParameters`, govParameters]])
+    expect(commit.mock.calls).toEqual([
+      [`setGovParameters`, governanceParameters]
+    ])
   })
 
   it(`should store an error if failed to load governance deposit parameters`, async () => {
diff --git a/test/unit/specs/store/parameters.spec.js b/test/unit/specs/store/parameters.spec.js
index a6c90b3733..cc1f3849db 100644
--- a/test/unit/specs/store/parameters.spec.js
+++ b/test/unit/specs/store/parameters.spec.js
@@ -1,43 +1,39 @@
-import setup from "../../helpers/vuex-setup"
-import lcdClientMock from "renderer/connectors/lcdClientMock.js"
 import parametersModule from "renderer/vuex/modules/parameters.js"
+import lcdClientMock from "renderer/connectors/lcdClientMock.js"
+let { stakingParameters } = lcdClientMock.state
 
-let instance = setup()
-
-const mockParameters = lcdClientMock.state.parameters
-
-describe(`Module: Parameters`, () => {
-  let store
+describe(`Module: Staking Parameters`, () => {
+  let module, node
 
   beforeEach(() => {
-    let test = instance.shallow(null)
-    store = test.store
-  })
-
-  it(`should have no parameters by default`, () => {
-    expect(store.state.parameters.parameters).toEqual({})
+    node = {
+      getStakingParameters: () => Promise.resolve(stakingParameters)
+    }
+    module = parametersModule({ node })
   })
 
-  it(`should query parameters`, async () => {
-    await store.dispatch(`getStakingParameters`)
-    expect(store.state.parameters.parameters).toEqual(mockParameters)
+  it(`should fetch staking parameters`, async () => {
+    let { actions, state } = module
+    let commit = jest.fn()
+    await actions.getStakingParameters({ state, commit })
+    expect(commit.mock.calls).toEqual([
+      [`setStakingParameters`, stakingParameters]
+    ])
   })
 
-  it(`should set parameters`, () => {
-    store.commit(`setStakingParameters`, mockParameters)
-    expect(store.state.parameters.parameters).toEqual(mockParameters)
+  it(`should add staking parameters to state`, () => {
+    let { mutations, state } = module
+    mutations.setStakingParameters(state, stakingParameters)
+    expect(state.parameters).toEqual(stakingParameters)
   })
 
-  it(`should store an error if failed to load parameters`, async () => {
-    const node = lcdClientMock
-    const { state, actions } = parametersModule({ node })
-    jest
-      .spyOn(node, `getStakingParameters`)
-      .mockImplementationOnce(async () => Promise.reject(`Error`))
+  it(`should store an error if failed to load staking parameters`, async () => {
+    node.getStakingParameters = () => Promise.reject(new Error(`Error`))
+    let { actions, state } = module
     await actions.getStakingParameters({
       state,
       commit: jest.fn()
     })
-    expect(state.error).toBe(`Error`)
+    expect(state.error.message).toBe(`Error`)
   })
 })

From 0e8a5d7c561b06126bd2d68480d1f471bf667d10 Mon Sep 17 00:00:00 2001
From: Federico Kunze <fekunze@berkeley.edu>
Date: Mon, 3 Dec 2018 16:41:17 +0100
Subject: [PATCH 03/20] update gov params tab

---
 .../components/governance/TabParameters.vue   | 31 +++++-----
 .../governance/TabParameters.spec.js          | 59 +++++++++++++++++++
 2 files changed, 76 insertions(+), 14 deletions(-)
 create mode 100644 test/unit/specs/components/governance/TabParameters.spec.js

diff --git a/app/src/renderer/components/governance/TabParameters.vue b/app/src/renderer/components/governance/TabParameters.vue
index d3b5c77585..a7165895d6 100644
--- a/app/src/renderer/components/governance/TabParameters.vue
+++ b/app/src/renderer/components/governance/TabParameters.vue
@@ -23,8 +23,8 @@
               </dt>
               <dd>
                 {{
-                  governanceParameters.deposit.min_deposit
-                    ? governanceParameters.deposit.min_deposit
+                  governanceParameters.parameters.deposit.min_deposit
+                    ? governanceParameters.parameters.deposit.min_deposit
                     : `n/a`
                 }}
               </dd>
@@ -42,7 +42,7 @@
               </dt>
               <dd>
                 {{
-                  parameters.parameters.max_deposit_period
+                  governanceParameters.parameters.deposit.max_deposit_period
                     ? depositPeriodInDays + ` days`
                     : `n/a`
                 }}
@@ -75,8 +75,8 @@
               </dt>
               <dd>
                 {{
-                  parameters.parameters.threshold
-                    ? parameters.parameters.threshold
+                  governanceParameters.parameters.tallying.threshold
+                    ? governanceParameters.parameters.tallying.threshold
                     : `n/a`
                 }}
               </dd>
@@ -92,8 +92,8 @@
               </dt>
               <dd>
                 {{
-                  parameters.parameters.veto
-                    ? parameters.parameters.veto
+                  governanceParameters.parameters.tallying.veto
+                    ? governanceParameters.parameters.tallying.veto
                     : `n/a`
                 }}
               </dd>
@@ -111,8 +111,9 @@
               </dt>
               <dd>
                 {{
-                  parameters.parameters.governance_penalty
-                    ? parameters.parameters.governance_penalty
+                  governanceParameters.parameters.tallying.governance_penalty
+                    ? governanceParameters.parameters.tallying
+                        .governance_penalty
                     : `n/a`
                 }}
               </dd>
@@ -144,7 +145,7 @@
               </dt>
               <dd>
                 {{
-                  governanceParameters.voting.voting_period
+                  governanceParameters.parameters.voting.voting_period
                     ? votingPeriodInDays + ` days`
                     : `n/a`
                 }}
@@ -191,24 +192,26 @@ export default {
     ...mapGetters([`config`, `governanceParameters`]),
     // TODO: a minimum deposit may consist of multiple coin denoms
     minumimDeposit() {
-      let coin = this.governanceParameters.deposit.min_deposit[0]
+      let coin = this.governanceParameters.parameters.deposit.min_deposit[0]
       return `${coin.amount} ${coin.denom}`
     },
     depositPeriodInDays() {
       return (
-        parseInt(this.governanceParameters.deposit.max_deposit_period) /
+        parseInt(
+          this.governanceParameters.parameters.deposit.max_deposit_period
+        ) /
         (10 ** 9 * 60 * 60 * 24)
       )
     },
     votingPeriodInDays() {
       return (
-        parseInt(this.governanceParameters.voting.voting_period) /
+        parseInt(this.governanceParameters.parameters.voting.voting_period) /
         (10 ** 9 * 60 * 60 * 24)
       )
     }
   },
   async mounted() {
-    this.$store.dispatch(`getgovernanceParameters`)
+    this.$store.dispatch(`getGovParameters`)
   }
 }
 </script>
diff --git a/test/unit/specs/components/governance/TabParameters.spec.js b/test/unit/specs/components/governance/TabParameters.spec.js
new file mode 100644
index 0000000000..9465fa1d1e
--- /dev/null
+++ b/test/unit/specs/components/governance/TabParameters.spec.js
@@ -0,0 +1,59 @@
+import Vuelidate from "vuelidate"
+import setup from "../../../helpers/vuex-setup"
+import htmlBeautify from "html-beautify"
+import TabParameters from "renderer/components/governance/TabParameters"
+import lcdClientMock from "renderer/connectors/lcdClientMock.js"
+
+let { governanceParameters } = lcdClientMock.state
+
+describe(`TabParameters`, () => {
+  let wrapper, store
+  let { mount, localVue } = setup()
+  localVue.use(Vuelidate)
+
+  const $store = {
+    commit: jest.fn(),
+    dispatch: jest.fn(),
+    getters: {
+      governanceParameters,
+      totalAtoms: 100,
+      user: { atoms: 42 }
+    }
+  }
+
+  beforeEach(() => {
+    let instance = mount(TabParameters, {
+      localVue,
+      doBefore: ({ store }) => {
+        store.commit(`setGovParameters`, governanceParameters)
+      },
+      $store
+    })
+    wrapper = instance.wrapper
+    store = instance.store
+    console.log(store.state.governanceParameters.parameters)
+    store.commit(`setConnected`, true)
+    wrapper.update()
+  })
+
+  it(`has the expected html structure`, async () => {
+    await wrapper.vm.$nextTick()
+    wrapper.update()
+    expect(htmlBeautify(wrapper.html())).toMatchSnapshot()
+  })
+
+  it(`shows the governance parameters`, () => {
+    console.log(store.state.governanceParameters.parameters)
+    expect(store.state.governanceParameters.parameters).toEqual(
+      governanceParameters
+    )
+  })
+
+  it(`displays deposit period in days`, () => {
+    expect(wrapper.vm.depositPeriodInDays).toEqual(2)
+  })
+
+  it(`displays voting period in days`, () => {
+    expect(wrapper.vm.votingPeriodInDays).toEqual(2)
+  })
+})

From f876081bf1d6cff907641c38f7c63b981fbe093f Mon Sep 17 00:00:00 2001
From: Federico Kunze <fekunze@berkeley.edu>
Date: Mon, 3 Dec 2018 16:54:44 +0100
Subject: [PATCH 04/20] update gov params and tabParams tests

---
 .../components/governance/TabParameters.vue   |  4 +-
 app/src/renderer/connectors/lcdClientMock.js  |  6 +-
 .../governance/TabParameters.spec.js          | 11 ++-
 .../__snapshots__/TabParameters.spec.js.snap  | 92 +++++++++++++++++++
 4 files changed, 104 insertions(+), 9 deletions(-)
 create mode 100644 test/unit/specs/components/governance/__snapshots__/TabParameters.spec.js.snap

diff --git a/app/src/renderer/components/governance/TabParameters.vue b/app/src/renderer/components/governance/TabParameters.vue
index a7165895d6..af7d33e00e 100644
--- a/app/src/renderer/components/governance/TabParameters.vue
+++ b/app/src/renderer/components/governance/TabParameters.vue
@@ -24,7 +24,7 @@
               <dd>
                 {{
                   governanceParameters.parameters.deposit.min_deposit
-                    ? governanceParameters.parameters.deposit.min_deposit
+                    ? minimumDeposit
                     : `n/a`
                 }}
               </dd>
@@ -191,7 +191,7 @@ export default {
   computed: {
     ...mapGetters([`config`, `governanceParameters`]),
     // TODO: a minimum deposit may consist of multiple coin denoms
-    minumimDeposit() {
+    minimumDeposit() {
       let coin = this.governanceParameters.parameters.deposit.min_deposit[0]
       return `${coin.amount} ${coin.denom}`
     },
diff --git a/app/src/renderer/connectors/lcdClientMock.js b/app/src/renderer/connectors/lcdClientMock.js
index 1adf144456..bca5a165e3 100644
--- a/app/src/renderer/connectors/lcdClientMock.js
+++ b/app/src/renderer/connectors/lcdClientMock.js
@@ -311,10 +311,10 @@ let state = {
       min_deposit: [
         {
           denom: `steak`,
-          amount: `coin`
+          amount: `10.0000000000`
         }
       ],
-      max_deposit_period: `86400000000`
+      max_deposit_period: `86400000000000`
     },
     tallying: {
       threshold: `0.5000000000`,
@@ -322,7 +322,7 @@ let state = {
       governance_penalty: `0.0100000000`
     },
     voting: {
-      voting_period: `86400000000`
+      voting_period: `86400000000000`
     }
   },
   sendHeight: 2,
diff --git a/test/unit/specs/components/governance/TabParameters.spec.js b/test/unit/specs/components/governance/TabParameters.spec.js
index 9465fa1d1e..a44bf58267 100644
--- a/test/unit/specs/components/governance/TabParameters.spec.js
+++ b/test/unit/specs/components/governance/TabParameters.spec.js
@@ -31,7 +31,6 @@ describe(`TabParameters`, () => {
     })
     wrapper = instance.wrapper
     store = instance.store
-    console.log(store.state.governanceParameters.parameters)
     store.commit(`setConnected`, true)
     wrapper.update()
   })
@@ -43,17 +42,21 @@ describe(`TabParameters`, () => {
   })
 
   it(`shows the governance parameters`, () => {
-    console.log(store.state.governanceParameters.parameters)
     expect(store.state.governanceParameters.parameters).toEqual(
       governanceParameters
     )
   })
 
+  it(`displays the minimum deposit`, () => {
+    let coin = governanceParameters.deposit.min_deposit[0]
+    expect(wrapper.vm.minimumDeposit).toEqual(`${coin.amount} ${coin.denom}`)
+  })
+
   it(`displays deposit period in days`, () => {
-    expect(wrapper.vm.depositPeriodInDays).toEqual(2)
+    expect(wrapper.vm.depositPeriodInDays).toEqual(1)
   })
 
   it(`displays voting period in days`, () => {
-    expect(wrapper.vm.votingPeriodInDays).toEqual(2)
+    expect(wrapper.vm.votingPeriodInDays).toEqual(1)
   })
 })
diff --git a/test/unit/specs/components/governance/__snapshots__/TabParameters.spec.js.snap b/test/unit/specs/components/governance/__snapshots__/TabParameters.spec.js.snap
new file mode 100644
index 0000000000..dc5a9bcd1b
--- /dev/null
+++ b/test/unit/specs/components/governance/__snapshots__/TabParameters.spec.js.snap
@@ -0,0 +1,92 @@
+// Jest Snapshot v1, https://goo.gl/fbAQLP
+
+exports[`TabParameters has the expected html structure 1`] = `
+"<div>
+   <div>
+      <h3>
+         Deposit Parameters      <i class=\\"material-icons info-button\\">info_outline</i>
+      </h3>
+      <div class=\\"parameters__details parameters__section\\">
+         <div class=\\"row\\">
+            <div class=\\"column\\">
+               <dl class=\\"info_dl\\">
+                  <dt>
+                     Minimum Deposit              <i class=\\"material-icons info-button\\">info_outline</i>
+                  </dt>
+                  <dd>
+                     10.0000000000 steak            
+                  </dd>
+</dl>
+</div>
+<div class=\\"column\\">
+   <dl class=\\"info_dl\\">
+      <dt>
+         Maximum Deposit Period              <i class=\\"material-icons info-button\\">info_outline</i>
+      </dt>
+      <dd>
+         1 days            
+      </dd>
+</dl>
+</div>
+</div>
+</div>
+</div>
+<div>
+   <h3>
+      Tally Parameters      <i class=\\"material-icons info-button\\">info_outline</i>
+   </h3>
+   <div class=\\"parameters__details parameters__section\\">
+      <div class=\\"row\\">
+         <div class=\\"column\\">
+            <dl class=\\"info_dl\\">
+               <dt>
+                  Threshold              <i class=\\"material-icons info-button\\">info_outline</i>
+               </dt>
+               <dd>
+                  0.5000000000            
+               </dd>
+</dl>
+            <dl class=\\"info_dl\\">
+               <dt>
+                  Veto              <i class=\\"material-icons info-button\\">info_outline</i>
+               </dt>
+               <dd>
+                  0.3340000000            
+               </dd>
+</dl>
+</div>
+<div class=\\"column\\">
+   <dl class=\\"info_dl\\">
+      <dt>
+         Governance Penalty              <i class=\\"material-icons info-button\\">info_outline</i>
+      </dt>
+      <dd>
+         0.0100000000            
+      </dd>
+</dl>
+</div>
+</div>
+</div>
+</div>
+<div>
+   <h3>
+      Voting Parameters      <i class=\\"material-icons info-button\\">info_outline</i>
+   </h3>
+   <div class=\\"parameters__details parameters__section\\">
+      <div class=\\"row\\">
+         <div class=\\"column\\">
+            <dl class=\\"info_dl\\">
+               <dt>
+                  Voting Period              <i class=\\"material-icons info-button\\">info_outline</i>
+               </dt>
+               <dd>
+                  1 days            
+               </dd>
+</dl>
+</div>
+<div class=\\"column\\"></div>
+</div>
+</div>
+</div>
+</div>"
+`;

From 21df33b301a7748dde815d59d76f25932c35fb1e Mon Sep 17 00:00:00 2001
From: Federico Kunze <fekunze@berkeley.edu>
Date: Mon, 3 Dec 2018 17:12:19 +0100
Subject: [PATCH 05/20] fix unit tests

---
 app/src/renderer/components/governance/TableProposals.vue | 2 +-
 app/src/renderer/connectors/lcdClientMock.js              | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/app/src/renderer/components/governance/TableProposals.vue b/app/src/renderer/components/governance/TableProposals.vue
index 7ffa46044e..56811eb86a 100644
--- a/app/src/renderer/components/governance/TableProposals.vue
+++ b/app/src/renderer/components/governance/TableProposals.vue
@@ -45,7 +45,7 @@ export default {
   },
   props: {
     proposals: {
-      type: Object,
+      type: Array,
       required: true
     },
     loading: {
diff --git a/app/src/renderer/connectors/lcdClientMock.js b/app/src/renderer/connectors/lcdClientMock.js
index bca5a165e3..47367c9bb3 100644
--- a/app/src/renderer/connectors/lcdClientMock.js
+++ b/app/src/renderer/connectors/lcdClientMock.js
@@ -971,7 +971,7 @@ module.exports = {
     return state.pool
   },
   async getStakingParameters() {
-    return state.parameters
+    return state.stakingParameters
   },
   async getProposals() {
     return state.proposals || []

From 96342dd95bf625f2c7b08515c48782dce58f64d4 Mon Sep 17 00:00:00 2001
From: Federico Kunze <fekunze@berkeley.edu>
Date: Mon, 3 Dec 2018 17:27:34 +0100
Subject: [PATCH 06/20] updated lcd and snaps

---
 app/src/renderer/components/governance/TabParameters.vue   | 2 +-
 app/src/renderer/components/staking/TabParameters.vue      | 6 +++---
 app/src/renderer/connectors/lcdClientMock.js               | 2 +-
 app/src/renderer/vuex/modules/parameters.js                | 1 -
 .../unit/specs/components/governance/TabParameters.spec.js | 2 +-
 .../governance/__snapshots__/TabParameters.spec.js.snap    | 2 +-
 test/unit/specs/components/staking/TabParameters.spec.js   | 7 +++----
 .../staking/__snapshots__/TabParameters.spec.js.snap       | 4 ++--
 test/unit/specs/lcdClientMock.spec.js                      | 4 ++--
 9 files changed, 14 insertions(+), 16 deletions(-)

diff --git a/app/src/renderer/components/governance/TabParameters.vue b/app/src/renderer/components/governance/TabParameters.vue
index af7d33e00e..afdab9dec0 100644
--- a/app/src/renderer/components/governance/TabParameters.vue
+++ b/app/src/renderer/components/governance/TabParameters.vue
@@ -193,7 +193,7 @@ export default {
     // TODO: a minimum deposit may consist of multiple coin denoms
     minimumDeposit() {
       let coin = this.governanceParameters.parameters.deposit.min_deposit[0]
-      return `${coin.amount} ${coin.denom}`
+      return `${coin.amount} ${coin.denom}s`
     },
     depositPeriodInDays() {
       return (
diff --git a/app/src/renderer/components/staking/TabParameters.vue b/app/src/renderer/components/staking/TabParameters.vue
index b365f2c1ba..f20941b303 100644
--- a/app/src/renderer/components/staking/TabParameters.vue
+++ b/app/src/renderer/components/staking/TabParameters.vue
@@ -18,7 +18,7 @@
                 {{
                   stakingParameters.parameters.bond_denom
                     ? stakingParameters.parameters.bond_denom
-                    : `atoms`
+                    : bondingDenom
                 }}
                 <i
                   v-tooltip.top="poolTooltips.loose_tokens"
@@ -38,7 +38,7 @@
                 {{
                   stakingParameters.parameters.bond_denom
                     ? stakingParameters.parameters.bond_denom
-                    : `atoms`
+                    : bondingDenom
                 }}
                 <i
                   v-tooltip.top="poolTooltips.bonded_tokens"
@@ -138,7 +138,7 @@ export default {
     }
   }),
   computed: {
-    ...mapGetters([`config`, `stakingParameters`, `pool`]),
+    ...mapGetters([`config`, `stakingParameters`, `pool`, `bondingDenom`]),
     unbondingTimeInDays() {
       return (
         parseInt(this.stakingParameters.parameters.unbonding_time) /
diff --git a/app/src/renderer/connectors/lcdClientMock.js b/app/src/renderer/connectors/lcdClientMock.js
index 47367c9bb3..20bcbc42cc 100644
--- a/app/src/renderer/connectors/lcdClientMock.js
+++ b/app/src/renderer/connectors/lcdClientMock.js
@@ -310,7 +310,7 @@ let state = {
     deposit: {
       min_deposit: [
         {
-          denom: `steak`,
+          denom: `stake`,
           amount: `10.0000000000`
         }
       ],
diff --git a/app/src/renderer/vuex/modules/parameters.js b/app/src/renderer/vuex/modules/parameters.js
index 5cd0b58cdf..6a24ebc93f 100644
--- a/app/src/renderer/vuex/modules/parameters.js
+++ b/app/src/renderer/vuex/modules/parameters.js
@@ -9,7 +9,6 @@ export default ({ node }) => {
 
   const mutations = {
     setStakingParameters(state, parameters) {
-      console.log(parameters)
       state.parameters = parameters
     }
   }
diff --git a/test/unit/specs/components/governance/TabParameters.spec.js b/test/unit/specs/components/governance/TabParameters.spec.js
index a44bf58267..d5fdfe7c77 100644
--- a/test/unit/specs/components/governance/TabParameters.spec.js
+++ b/test/unit/specs/components/governance/TabParameters.spec.js
@@ -49,7 +49,7 @@ describe(`TabParameters`, () => {
 
   it(`displays the minimum deposit`, () => {
     let coin = governanceParameters.deposit.min_deposit[0]
-    expect(wrapper.vm.minimumDeposit).toEqual(`${coin.amount} ${coin.denom}`)
+    expect(wrapper.vm.minimumDeposit).toEqual(`${coin.amount} ${coin.denom}s`)
   })
 
   it(`displays deposit period in days`, () => {
diff --git a/test/unit/specs/components/governance/__snapshots__/TabParameters.spec.js.snap b/test/unit/specs/components/governance/__snapshots__/TabParameters.spec.js.snap
index dc5a9bcd1b..bc5eba48cd 100644
--- a/test/unit/specs/components/governance/__snapshots__/TabParameters.spec.js.snap
+++ b/test/unit/specs/components/governance/__snapshots__/TabParameters.spec.js.snap
@@ -14,7 +14,7 @@ exports[`TabParameters has the expected html structure 1`] = `
                      Minimum Deposit              <i class=\\"material-icons info-button\\">info_outline</i>
                   </dt>
                   <dd>
-                     10.0000000000 steak            
+                     10.0000000000 stakes            
                   </dd>
 </dl>
 </div>
diff --git a/test/unit/specs/components/staking/TabParameters.spec.js b/test/unit/specs/components/staking/TabParameters.spec.js
index 4b0f22c9b9..cd94d54142 100644
--- a/test/unit/specs/components/staking/TabParameters.spec.js
+++ b/test/unit/specs/components/staking/TabParameters.spec.js
@@ -18,7 +18,8 @@ describe(`TabParameters`, () => {
       pool,
       stakingParameters,
       totalAtoms: 100,
-      user: { atoms: 42 }
+      user: { atoms: 42 },
+      bondingDenom: `Stake`
     }
   }
 
@@ -33,7 +34,6 @@ describe(`TabParameters`, () => {
     })
     wrapper = instance.wrapper
     store = instance.store
-    console.log(store.state.stakingParameters.parameters)
     store.commit(`setConnected`, true)
     wrapper.update()
   })
@@ -44,8 +44,7 @@ describe(`TabParameters`, () => {
     expect(htmlBeautify(wrapper.html())).toMatchSnapshot()
   })
 
-  it.only(`shows the staking parameters and pool`, () => {
-    console.log(store.state.stakingParameters.parameters)
+  it(`shows the staking parameters and pool`, () => {
     expect(store.state.stakingParameters.parameters).toEqual(stakingParameters)
     expect(store.state.pool.pool).toEqual(pool)
   })
diff --git a/test/unit/specs/components/staking/__snapshots__/TabParameters.spec.js.snap b/test/unit/specs/components/staking/__snapshots__/TabParameters.spec.js.snap
index 1e6ebcbe6d..d9b9f0f393 100644
--- a/test/unit/specs/components/staking/__snapshots__/TabParameters.spec.js.snap
+++ b/test/unit/specs/components/staking/__snapshots__/TabParameters.spec.js.snap
@@ -11,7 +11,7 @@ exports[`TabParameters has the expected html structure 1`] = `
             <div class=\\"column\\">
                <dl class=\\"info_dl\\">
                   <dt>
-                     Loose steak              <i class=\\"material-icons info-button\\">info_outline</i>
+                     Loose              steak              <i class=\\"material-icons info-button\\">info_outline</i>
                   </dt>
                   <dd id=\\"loose_tokens\\">
                      100.0000000000            
@@ -21,7 +21,7 @@ exports[`TabParameters has the expected html structure 1`] = `
 <div class=\\"column\\">
    <dl class=\\"info_dl\\">
       <dt>
-         Delegated steak              <i class=\\"material-icons info-button\\">info_outline</i>
+         Delegated              steak              <i class=\\"material-icons info-button\\">info_outline</i>
       </dt>
       <dd id=\\"bonded_tokens\\">
          50.0000000000            
diff --git a/test/unit/specs/lcdClientMock.spec.js b/test/unit/specs/lcdClientMock.spec.js
index 0e2a0717a9..49736034fd 100644
--- a/test/unit/specs/lcdClientMock.spec.js
+++ b/test/unit/specs/lcdClientMock.spec.js
@@ -822,7 +822,7 @@ describe(`LCD Client Mock`, () => {
     expect(txs[0].tx.value.msg[0].type).toBe(`cosmos-sdk/BeginUnbonding`)
   })
 
-  it.only(`queries for staking parameters`, async () => {
+  it(`queries for staking parameters`, async () => {
     let parameters = await client.getStakingParameters()
     expect(parameters).toBeDefined()
     expect(parameters).toMatchObject(lcdClientMock.state.stakingParameters)
@@ -831,7 +831,7 @@ describe(`LCD Client Mock`, () => {
   it(`queries for staking pool`, async () => {
     let pool = await client.getPool()
     expect(pool).toBeDefined()
-    expect(Object.keys(pool)).toContain(`loose_tokens`, `bonded_tokens`)
+    expect(pool).toMatchObject(lcdClientMock.state.pool)
   })
 
   it(`queries for validator signing information`, async () => {

From 1b5dead4921155502941f60eae70548612f93356 Mon Sep 17 00:00:00 2001
From: Federico Kunze <fekunze@berkeley.edu>
Date: Mon, 3 Dec 2018 17:28:55 +0100
Subject: [PATCH 07/20] changelog

---
 CHANGELOG.md | 1 +
 1 file changed, 1 insertion(+)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 6809f30c92..04ba6ce17b 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -38,6 +38,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 - [\#1198](https://github.com/cosmos/voyager/pull/1198) added e2e tests for wallet and staking transactions @faboweb
 - [\#1578](https://github.com/cosmos/voyager/issues/1578) added e2e tests for submit governance proposals @fedekunze
 - [\#1672](https://github.com/cosmos/voyager/issues/1672) added e2e tests for staking parameters tab @fedekunze
+- [\#1648](https://github.com/cosmos/voyager/issues/1648) added governance parameters tab @fedekunze
 
 ### Changed
 

From ac4abd203591db97bc825ab9a46579140126dbd1 Mon Sep 17 00:00:00 2001
From: Federico Kunze <fekunze@berkeley.edu>
Date: Mon, 3 Dec 2018 17:50:11 +0100
Subject: [PATCH 08/20] switch to percentages

---
 .../components/governance/PageGovernance.vue     |  7 ++++++-
 .../components/governance/TabParameters.vue      | 16 ++++++++++------
 .../__snapshots__/TabParameters.spec.js.snap     |  4 ++--
 3 files changed, 18 insertions(+), 9 deletions(-)

diff --git a/app/src/renderer/components/governance/PageGovernance.vue b/app/src/renderer/components/governance/PageGovernance.vue
index 59ef8f2fc3..fcf4e60244 100644
--- a/app/src/renderer/components/governance/PageGovernance.vue
+++ b/app/src/renderer/components/governance/PageGovernance.vue
@@ -52,8 +52,13 @@ export default {
     tabs: [
       {
         displayName: `Proposals`,
-        pathName: `Governance Parameters`
+        pathName: `Proposals`
       }
+      // TODO uncomment when updated to latest SDK
+      // {
+      //   displayName: `Parameters`,
+      //   pathName: `Governance Parameters`
+      // }
     ],
     showModalPropose: false
   }),
diff --git a/app/src/renderer/components/governance/TabParameters.vue b/app/src/renderer/components/governance/TabParameters.vue
index afdab9dec0..4a0af8fc8c 100644
--- a/app/src/renderer/components/governance/TabParameters.vue
+++ b/app/src/renderer/components/governance/TabParameters.vue
@@ -76,7 +76,9 @@
               <dd>
                 {{
                   governanceParameters.parameters.tallying.threshold
-                    ? governanceParameters.parameters.tallying.threshold
+                    ? `${parseFloat(
+                        governanceParameters.parameters.tallying.threshold
+                      ) * 100} %`
                     : `n/a`
                 }}
               </dd>
@@ -93,7 +95,9 @@
               <dd>
                 {{
                   governanceParameters.parameters.tallying.veto
-                    ? governanceParameters.parameters.tallying.veto
+                    ? `${parseFloat(
+                        governanceParameters.parameters.tallying.veto
+                      ) * 100} %`
                     : `n/a`
                 }}
               </dd>
@@ -138,7 +142,7 @@
               <dt>
                 Voting Period
                 <i
-                  v-tooltip.top="depositTooltips.voting_period"
+                  v-tooltip.top="votingTooltips.voting_period"
                   class="material-icons info-button"
                   >info_outline</i
                 >
@@ -174,13 +178,13 @@ export default {
   data: () => ({
     depositTooltips: {
       description: `Parameters around proposals' deposits on governance`,
-      min_deposit: `Minimum deposit for a proposal to enter voting period`,
+      min_deposit: `Minimum deposit for a proposal to enter the voting period`,
       max_deposit_period: `Maximum period for token holders to deposit on a proposal`
     },
     tallyingTooltips: {
       description: `Parameters around tallying votes in governance`,
-      threshold: `Minimum propotion of Yes votes for proposal to pass`,
-      veto: `Minimum value of Veto votes to Total votes ratio for proposal to be vetoed`,
+      threshold: `Percentage of Yes votes for proposal to pass`,
+      veto: `Percentage of NoWithVeto votes over the total amount of votes for proposal to be vetoed`,
       governance_penalty: `Penalty if validator does not vote`
     },
     votingTooltips: {
diff --git a/test/unit/specs/components/governance/__snapshots__/TabParameters.spec.js.snap b/test/unit/specs/components/governance/__snapshots__/TabParameters.spec.js.snap
index bc5eba48cd..d3139d342b 100644
--- a/test/unit/specs/components/governance/__snapshots__/TabParameters.spec.js.snap
+++ b/test/unit/specs/components/governance/__snapshots__/TabParameters.spec.js.snap
@@ -43,7 +43,7 @@ exports[`TabParameters has the expected html structure 1`] = `
                   Threshold              <i class=\\"material-icons info-button\\">info_outline</i>
                </dt>
                <dd>
-                  0.5000000000            
+                  50 %            
                </dd>
 </dl>
             <dl class=\\"info_dl\\">
@@ -51,7 +51,7 @@ exports[`TabParameters has the expected html structure 1`] = `
                   Veto              <i class=\\"material-icons info-button\\">info_outline</i>
                </dt>
                <dd>
-                  0.3340000000            
+                  33.4 %            
                </dd>
 </dl>
 </div>

From dbcb02f7dee6e8fad29fd82679c20e0c27b9d97d Mon Sep 17 00:00:00 2001
From: Jordan Bibla <jbibla@gmail.com>
Date: Mon, 3 Dec 2018 21:34:55 +0100
Subject: [PATCH 09/20] Update
 app/src/renderer/components/governance/TabParameters.vue

Co-Authored-By: fedekunze <31522760+fedekunze@users.noreply.github.com>
---
 app/src/renderer/components/governance/TabParameters.vue | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/app/src/renderer/components/governance/TabParameters.vue b/app/src/renderer/components/governance/TabParameters.vue
index 4a0af8fc8c..adb8a8bc2a 100644
--- a/app/src/renderer/components/governance/TabParameters.vue
+++ b/app/src/renderer/components/governance/TabParameters.vue
@@ -179,7 +179,7 @@ export default {
     depositTooltips: {
       description: `Parameters around proposals' deposits on governance`,
       min_deposit: `Minimum deposit for a proposal to enter the voting period`,
-      max_deposit_period: `Maximum period for token holders to deposit on a proposal`
+      max_deposit_period: `Deposits must reach the "minimum deposit" threshold in this period of time`
     },
     tallyingTooltips: {
       description: `Parameters around tallying votes in governance`,

From 8e825b09db6414981fea325609783ef8838de61d Mon Sep 17 00:00:00 2001
From: Jordan Bibla <jbibla@gmail.com>
Date: Mon, 3 Dec 2018 21:35:16 +0100
Subject: [PATCH 10/20] Update
 app/src/renderer/components/governance/TabParameters.vue

Co-Authored-By: fedekunze <31522760+fedekunze@users.noreply.github.com>
---
 app/src/renderer/components/governance/TabParameters.vue | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/app/src/renderer/components/governance/TabParameters.vue b/app/src/renderer/components/governance/TabParameters.vue
index adb8a8bc2a..2a4162ae8f 100644
--- a/app/src/renderer/components/governance/TabParameters.vue
+++ b/app/src/renderer/components/governance/TabParameters.vue
@@ -184,7 +184,7 @@ export default {
     tallyingTooltips: {
       description: `Parameters around tallying votes in governance`,
       threshold: `Percentage of Yes votes for proposal to pass`,
-      veto: `Percentage of NoWithVeto votes over the total amount of votes for proposal to be vetoed`,
+      veto: `Percentage of "No With Veto" votes required for proposal to be vetoed`,
       governance_penalty: `Penalty if validator does not vote`
     },
     votingTooltips: {

From 0481fb3a5835e296f2e24db737b8bc2b18697f4c Mon Sep 17 00:00:00 2001
From: Jordan Bibla <jbibla@gmail.com>
Date: Mon, 3 Dec 2018 21:36:38 +0100
Subject: [PATCH 11/20] Update
 app/src/renderer/components/governance/TabParameters.vue

Co-Authored-By: fedekunze <31522760+fedekunze@users.noreply.github.com>
---
 app/src/renderer/components/governance/TabParameters.vue | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/app/src/renderer/components/governance/TabParameters.vue b/app/src/renderer/components/governance/TabParameters.vue
index 2a4162ae8f..d5e2275230 100644
--- a/app/src/renderer/components/governance/TabParameters.vue
+++ b/app/src/renderer/components/governance/TabParameters.vue
@@ -189,7 +189,7 @@ export default {
     },
     votingTooltips: {
       description: `Parameters around voting on governance proposals`,
-      voting_period: `Length of the voting period`
+      voting_period: `Length of the voting period for proposals on the Cosmos Hub`
     }
   }),
   computed: {

From 71e95f965a892e65e8a59512bd00be07b255e05d Mon Sep 17 00:00:00 2001
From: Jordan Bibla <jbibla@gmail.com>
Date: Mon, 3 Dec 2018 21:36:57 +0100
Subject: [PATCH 12/20] Update
 app/src/renderer/components/governance/TabParameters.vue

Co-Authored-By: fedekunze <31522760+fedekunze@users.noreply.github.com>
---
 app/src/renderer/components/governance/TabParameters.vue | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/app/src/renderer/components/governance/TabParameters.vue b/app/src/renderer/components/governance/TabParameters.vue
index d5e2275230..48e369b783 100644
--- a/app/src/renderer/components/governance/TabParameters.vue
+++ b/app/src/renderer/components/governance/TabParameters.vue
@@ -188,7 +188,7 @@ export default {
       governance_penalty: `Penalty if validator does not vote`
     },
     votingTooltips: {
-      description: `Parameters around voting on governance proposals`,
+      description: `Voting parameters for governance in the Cosmos Hub`,
       voting_period: `Length of the voting period for proposals on the Cosmos Hub`
     }
   }),

From 6c78345d9cf42f63789c73d3e6d73a2266bfa198 Mon Sep 17 00:00:00 2001
From: Jordan Bibla <jbibla@gmail.com>
Date: Mon, 3 Dec 2018 21:38:12 +0100
Subject: [PATCH 13/20] Update
 app/src/renderer/components/governance/TabParameters.vue

Co-Authored-By: fedekunze <31522760+fedekunze@users.noreply.github.com>
---
 app/src/renderer/components/governance/TabParameters.vue | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/app/src/renderer/components/governance/TabParameters.vue b/app/src/renderer/components/governance/TabParameters.vue
index 48e369b783..0b03733e8f 100644
--- a/app/src/renderer/components/governance/TabParameters.vue
+++ b/app/src/renderer/components/governance/TabParameters.vue
@@ -182,7 +182,7 @@ export default {
       max_deposit_period: `Deposits must reach the "minimum deposit" threshold in this period of time`
     },
     tallyingTooltips: {
-      description: `Parameters around tallying votes in governance`,
+      description: `Tally parameters for governance in the Cosmos Hub`,
       threshold: `Percentage of Yes votes for proposal to pass`,
       veto: `Percentage of "No With Veto" votes required for proposal to be vetoed`,
       governance_penalty: `Penalty if validator does not vote`

From f94a6638553bf3a0c72a8ae5dba904e69e88d952 Mon Sep 17 00:00:00 2001
From: Jordan Bibla <jbibla@gmail.com>
Date: Mon, 3 Dec 2018 21:38:34 +0100
Subject: [PATCH 14/20] Update
 app/src/renderer/components/governance/TabParameters.vue

Co-Authored-By: fedekunze <31522760+fedekunze@users.noreply.github.com>
---
 app/src/renderer/components/governance/TabParameters.vue | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/app/src/renderer/components/governance/TabParameters.vue b/app/src/renderer/components/governance/TabParameters.vue
index 0b03733e8f..a03d091473 100644
--- a/app/src/renderer/components/governance/TabParameters.vue
+++ b/app/src/renderer/components/governance/TabParameters.vue
@@ -183,7 +183,7 @@ export default {
     },
     tallyingTooltips: {
       description: `Tally parameters for governance in the Cosmos Hub`,
-      threshold: `Percentage of Yes votes for proposal to pass`,
+      threshold: `Percentage of "Yes" votes required for proposal to pass`,
       veto: `Percentage of "No With Veto" votes required for proposal to be vetoed`,
       governance_penalty: `Penalty if validator does not vote`
     },

From 52ffeb99c7e4f7a1e46f867a86da8c6d23a19775 Mon Sep 17 00:00:00 2001
From: Jordan Bibla <jbibla@gmail.com>
Date: Mon, 3 Dec 2018 21:38:51 +0100
Subject: [PATCH 15/20] Update
 app/src/renderer/components/governance/TabParameters.vue

Co-Authored-By: fedekunze <31522760+fedekunze@users.noreply.github.com>
---
 app/src/renderer/components/governance/TabParameters.vue | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/app/src/renderer/components/governance/TabParameters.vue b/app/src/renderer/components/governance/TabParameters.vue
index a03d091473..833b58c755 100644
--- a/app/src/renderer/components/governance/TabParameters.vue
+++ b/app/src/renderer/components/governance/TabParameters.vue
@@ -185,7 +185,7 @@ export default {
       description: `Tally parameters for governance in the Cosmos Hub`,
       threshold: `Percentage of "Yes" votes required for proposal to pass`,
       veto: `Percentage of "No With Veto" votes required for proposal to be vetoed`,
-      governance_penalty: `Penalty if validator does not vote`
+      governance_penalty: `Penalty for a validator who fails to vote`
     },
     votingTooltips: {
       description: `Voting parameters for governance in the Cosmos Hub`,

From e80995b5a390961c0248e6e49fb3b4cd656a2d4c Mon Sep 17 00:00:00 2001
From: Jordan Bibla <jbibla@gmail.com>
Date: Mon, 3 Dec 2018 21:39:12 +0100
Subject: [PATCH 16/20] Update
 app/src/renderer/components/governance/TabParameters.vue

Co-Authored-By: fedekunze <31522760+fedekunze@users.noreply.github.com>
---
 app/src/renderer/components/governance/TabParameters.vue | 1 -
 1 file changed, 1 deletion(-)

diff --git a/app/src/renderer/components/governance/TabParameters.vue b/app/src/renderer/components/governance/TabParameters.vue
index 833b58c755..038ad843d3 100644
--- a/app/src/renderer/components/governance/TabParameters.vue
+++ b/app/src/renderer/components/governance/TabParameters.vue
@@ -194,7 +194,6 @@ export default {
   }),
   computed: {
     ...mapGetters([`config`, `governanceParameters`]),
-    // TODO: a minimum deposit may consist of multiple coin denoms
     minimumDeposit() {
       let coin = this.governanceParameters.parameters.deposit.min_deposit[0]
       return `${coin.amount} ${coin.denom}s`

From 8dc17a8d58b8b304b264b0ec7515621e1a548ecc Mon Sep 17 00:00:00 2001
From: Jordan Bibla <jbibla@gmail.com>
Date: Mon, 3 Dec 2018 21:40:40 +0100
Subject: [PATCH 17/20] Update
 app/src/renderer/components/governance/TabParameters.vue

Co-Authored-By: fedekunze <31522760+fedekunze@users.noreply.github.com>
---
 app/src/renderer/components/governance/TabParameters.vue | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/app/src/renderer/components/governance/TabParameters.vue b/app/src/renderer/components/governance/TabParameters.vue
index 038ad843d3..5482360773 100644
--- a/app/src/renderer/components/governance/TabParameters.vue
+++ b/app/src/renderer/components/governance/TabParameters.vue
@@ -177,7 +177,7 @@ export default {
   },
   data: () => ({
     depositTooltips: {
-      description: `Parameters around proposals' deposits on governance`,
+      description: `Governance deposit parameters for the Cosmos Hub`,
       min_deposit: `Minimum deposit for a proposal to enter the voting period`,
       max_deposit_period: `Deposits must reach the "minimum deposit" threshold in this period of time`
     },

From 06fe2f5b35d35b79e53a942dc327f35bffe63d9f Mon Sep 17 00:00:00 2001
From: Fabian <frznhope@gmail.com>
Date: Tue, 4 Dec 2018 12:38:12 +0100
Subject: [PATCH 18/20] Update CHANGELOG.md

Co-Authored-By: fedekunze <31522760+fedekunze@users.noreply.github.com>
---
 CHANGELOG.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index ef5d707cac..e1f498d79f 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -40,7 +40,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 - [\#1578](https://github.com/cosmos/voyager/issues/1578) added e2e tests for submit governance proposals @fedekunze
 - [\#1672](https://github.com/cosmos/voyager/issues/1672) added e2e tests for staking parameters tab @fedekunze
 - [\#1648](https://github.com/cosmos/voyager/issues/1648) added governance parameters tab @fedekunze
-- [\#1550](https://github.com/cosmos/voyager/issues/1578) added e2e tests for voting on governance proposals @fedekunze
+- [\#1550](https://github.com/cosmos/voyager/issues/1550) added e2e tests for voting on governance proposals @fedekunze
 - [\#1555](https://github.com/cosmos/voyager/issues/1578) added e2e tests for submitting a deposit on a governance proposal @fedekunze
 
 ### Changed

From 9da45d9a263749c33ab84c7b5bd2afec14a4c468 Mon Sep 17 00:00:00 2001
From: Fabian <frznhope@gmail.com>
Date: Tue, 4 Dec 2018 12:38:35 +0100
Subject: [PATCH 19/20] Update CHANGELOG.md

Co-Authored-By: fedekunze <31522760+fedekunze@users.noreply.github.com>
---
 CHANGELOG.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index e1f498d79f..c5248af611 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -41,7 +41,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 - [\#1672](https://github.com/cosmos/voyager/issues/1672) added e2e tests for staking parameters tab @fedekunze
 - [\#1648](https://github.com/cosmos/voyager/issues/1648) added governance parameters tab @fedekunze
 - [\#1550](https://github.com/cosmos/voyager/issues/1550) added e2e tests for voting on governance proposals @fedekunze
-- [\#1555](https://github.com/cosmos/voyager/issues/1578) added e2e tests for submitting a deposit on a governance proposal @fedekunze
+- [\#1555](https://github.com/cosmos/voyager/issues/1555) added e2e tests for submitting a deposit on a governance proposal @fedekunze
 
 ### Changed
 

From 7fdf112951f3c29119a053f3a711b49f26e50d7b Mon Sep 17 00:00:00 2001
From: Jordan Bibla <jbibla@gmail.com>
Date: Tue, 4 Dec 2018 16:19:19 +0100
Subject: [PATCH 20/20] Update
 app/src/renderer/components/governance/TabParameters.vue

Co-Authored-By: fedekunze <31522760+fedekunze@users.noreply.github.com>
---
 app/src/renderer/components/governance/TabParameters.vue | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/app/src/renderer/components/governance/TabParameters.vue b/app/src/renderer/components/governance/TabParameters.vue
index 5482360773..e1c2b3e455 100644
--- a/app/src/renderer/components/governance/TabParameters.vue
+++ b/app/src/renderer/components/governance/TabParameters.vue
@@ -178,7 +178,7 @@ export default {
   data: () => ({
     depositTooltips: {
       description: `Governance deposit parameters for the Cosmos Hub`,
-      min_deposit: `Minimum deposit for a proposal to enter the voting period`,
+      min_deposit: `Minimum deposit required before for a proposal can enter the voting period`,
       max_deposit_period: `Deposits must reach the "minimum deposit" threshold in this period of time`
     },
     tallyingTooltips: {