2.8.x / 2.9.x release?

[SinisterRectus]

I just noticed that there is a tag for 2.8.0, but no release, and therefore no luvit release that contains luvi 2.8.0. Is this intentional?

[rphillips]

Not intentional. The build machines have been gone for some time. It would be nice to get travis to push images.

[SinisterRectus]

My experience in building C software doesn't extend much further than gcc -o hello hello.c. Wish I could help here.

[rphillips]

@SinisterRectus which platform are you interested in?

[aiverson]

I have a decent amount of experience in compiling and writing C software as well as devops stuff. I can potentially help out here.

[SinisterRectus]

I personally develop on 64-bit Windows, but having my own copy of luvi 2.8.0 would not be helpful for my users, who I instruct to use the get-lit script(s).

Discord supports transport compression with zlib streams, so I was looking to test the new miniz bindings, but they have not made transport compression mandatory in their protocol, so it's not critical that I have access to this at the moment.

[rphillips]

Travis just added beta support for windows... We could potentially leverage that.

[rphillips]

This will help for Linux builds... #181

[joerg-krause]

There are already 46 commits to master since tag 2.8.0. Maybe it is time for 2.9.0?

[SinisterRectus]

2.8.1 or 2.9.0 might be appropriate, depending on what the changes are. Would probably be best to have a reliable build procedure for building 2.8.0 and then worry about the rest.

[joerg-krause]

We are stuck to version 2.7.6 in Buildroot, as it is the latest version which provides a release tarball. Unfortunately, this version does not compile with OpenSSL 1.1.x

I'd be delighted if there was a new release with a downloadable tarball for the source 🙏

Note, that I am not interested in any target binaries, but in a tarball containing all the source files (like luvi-src-v2.7.6.tar.gz).

[SinisterRectus]

This?

[joerg-krause]

No, as the deps folders are all empty.

[joerg-krause]

This.

[joerg-krause]

The Makefile already has the necessary target publish-src to upload a release tarball containing all the source files.

Maybe one of the maintainers can tag a release and run make publish-src, so we can get an updated version of luvi, which can be build with OpenSSL 1.1.1a.

[rphillips]

2.8.1 or 2.9.0?

[joerg-krause]

I tend towards 2.9.0.

[joerg-krause]

After merging #189

[creationix]

Let's get this out. At a minimum we can publish the tarball for builtroot.

The binaries are harder depending on how many we want to support. I had a pile of raspberry pi machines, 64-bit arm boards and virtualbox images that I was using before to manually build all the variants.

[creationix]

@joerg-krause is anything extra needed to support the newer openssl or is it already in the newer luvi commits?

[joerg-krause]

@creationix No, I think everything is prepared. Buildroot uses an external OpenSSL, but still requires the bundled lua-openssl, which has been bumped to the latest version.

Thanks for taking care!

[creationix]

@joerg-krause please test https://github.com/luvit/luvi/releases/tag/v2.9.0

It's been a while and my old scripts/tools aren't working. I created this release manually and uploaded the tarball manually, but I think it will work.

[creationix]

I also manually built and uploaded linux x64 binaries on an ubuntu 14.04 system. The docker-based stuff isn't working for me.

[joerg-krause]

@creationix Thanks for the source tarball! It is working perfectly, but the VERSION is not set to 2.9.0 in the tarball, but to v2.7.6-61-gfe02ab2:

# luvi --version
luvi v2.7.6-61-gfe02ab2
zlib: 1.2.11
libuv: 1.25.0
ssl: OpenSSL 1.1.1a  20 Nov 2018, lua-openssl 0.7.3

[creationix]

Ok, rebuilt the tarball. I think I had built it before creating the new tag in git.

[joerg-krause]

Thanks! That worked:

# luvi --version
luvi v2.9.0
zlib: 1.2.11
libuv: 1.25.0
ssl: OpenSSL 1.1.1a  20 Nov 2018, lua-openssl 0.7.3

[squeek502]

@creationix here's a full set of Windows binaries/libs if you want to add them to the release: https://www.ryanliptak.com/misc/luvi-windows-2.9.0.zip

Built with MSVC 2015 Update 3 on Windows 7 and includes this PR.

> luvi --version
luvi v2.9.0
libuv: 1.25.0
rex: 8.37 2015-04-28
winsvc: 1.0.0
ssl: OpenSSL 1.1.0i  14 Aug 2018, lua-openssl 0.7.3

EDIT: Might want to release a 2.9.1 after merging the PR linked above?

[squeek502]

Here are Windows binaries/libs for 2.9.1 (the same as the 2.9.0 ones above except for the version string):
https://www.ryanliptak.com/misc/luvi-windows-2.9.1.zip

> luvi --version
luvi v2.9.1
libuv: 1.25.0
rex: 8.37 2015-04-28
winsvc: 1.0.0
ssl: OpenSSL 1.1.0i  14 Aug 2018, lua-openssl 0.7.3

[creationix]

I think my linux binaries are wrong. They appear to have dynamically linked libuv.

[squeek502]

I think my linux binaries are wrong. They appear to have dynamically linked libuv.

Yeah, they would have since you built them before #191. @rphillips released v2.9.1 with that fix.

[creationix]

Thanks, I published linux binaries for the v2.9.1 release. They also appear to dynamically link openssl, but I think that's on purpose now for linux?

~/Code/luvi$ ldd build/luvi 
	linux-vdso.so.1 =>  (0x00007ffdb10aa000)
	librt.so.1 => /lib/x86_64-linux-gnu/librt.so.1 (0x00007fa161f53000)
	libpthread.so.0 => /lib/x86_64-linux-gnu/libpthread.so.0 (0x00007fa161d35000)
	libdl.so.2 => /lib/x86_64-linux-gnu/libdl.so.2 (0x00007fa161b31000)
	libm.so.6 => /lib/x86_64-linux-gnu/libm.so.6 (0x00007fa16182b000)
	libssl.so.1.0.0 => /lib/x86_64-linux-gnu/libssl.so.1.0.0 (0x00007fa1615cc000)
	libcrypto.so.1.0.0 => /lib/x86_64-linux-gnu/libcrypto.so.1.0.0 (0x00007fa1611ef000)
	libgcc_s.so.1 => /lib/x86_64-linux-gnu/libgcc_s.so.1 (0x00007fa160fd7000)
	libc.so.6 => /lib/x86_64-linux-gnu/libc.so.6 (0x00007fa160c0e000)
	/lib64/ld-linux-x86-64.so.2 (0x00007fa16215b000)

[squeek502]

Thanks, I published linux binaries for the v2.9.1 release. They also appear to dynamically link openssl, but I think that's on purpose now for linux?

That's the default now, yeah. You can add these Windows binaries to the release too if you'd like: https://www.ryanliptak.com/misc/luvi-windows-2.9.1.zip

[rphillips]

Thanks! Just for sanity, I ran the binaries through clamav.