Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lv2apply uses non-portable Variable Length Arrays (VLA) #64

Closed
dg0yt opened this issue Dec 18, 2024 · 2 comments
Closed

lv2apply uses non-portable Variable Length Arrays (VLA) #64

dg0yt opened this issue Dec 18, 2024 · 2 comments

Comments

@dg0yt
Copy link

dg0yt commented Dec 18, 2024

lilv/tools/lv2apply.c

Lines 324 to 325 in b6496d8

float in_buf[self.n_audio_in > 0 ? self.n_audio_in : 1];
float out_buf[self.n_audio_out > 0 ? self.n_audio_out : 1];

These lines fail to compile with MSVC.

This was noticed while reviewing a regression of the vcpkg port. The issue occurs only for a particular configuration.

  • Feature tools left to default. (Not forced to enabled or disabled.)
  • Dependency sndfile can be found.
@drobilla
Copy link
Collaborator

Fixed in e1e0b34

@dg0yt
Copy link
Author

dg0yt commented Dec 18, 2024

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants