Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Escape key on touch bar does not hide UI #119

Closed
phungtuanhoang1996 opened this issue Jan 20, 2020 · 0 comments
Closed

Escape key on touch bar does not hide UI #119

phungtuanhoang1996 opened this issue Jan 20, 2020 · 0 comments
Labels
bug Something isn't working

Comments

@phungtuanhoang1996
Copy link
Contributor

On my MBP 15 2019 running Catalina, the key down/up event from the Escape key on the TouchBar does not contain the modifierFlags from the keyboard. Therefore isMetaDown flag in the KeyboardHandler is false and hideUI is not called.
@lwouis lwouis added bug Something isn't working S size labels Jan 20, 2020
phungtuanhoang1996 added a commit to phungtuanhoang1996/alt-tab-macos that referenced this issue Jan 20, 2020
@phungtuanhoang1996
fix: touch bar's escape key works on mbp 15 2019 (closes lwouis#119)
9fd0c16
@lwouis lwouis closed this as completed in eda6b7e Jan 21, 2020
lwouis pushed a commit that referenced this issue Jan 21, 2020
@semantic-release-bot
chore(release): 2.3.3 [skip ci]
97798c3 
## [2.3.3](v2.3.2...v2.3.3) (2020-01-21)

### Bug Fixes

* touch bar's escape key works on mbp 15 2019 (closes [#119](#119)) ([eda6b7e](eda6b7e))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lwouis @phungtuanhoang1996