Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firefox fullscreen videos are not listed in AltTab #360

Closed
lwouis opened this issue May 28, 2020 · 3 comments
Closed

Firefox fullscreen videos are not listed in AltTab #360

lwouis opened this issue May 28, 2020 · 3 comments
Labels
bug Something isn't working

Comments

@lwouis
Copy link
Owner

lwouis commented May 28, 2020

From @nathanshelly in #335 (comment):

👋 first off thanks so much for this app! love having Windows alt-tab behavior on macOS

I think I'm seeing a similar bug even on the latest v4.0 (happy to open a separate issue if you'd prefer). For some reason if I fullscreen a video in Firefox the window no longer shows up in the switcher.

Here's a video showing this behavior - https://photos.app.goo.gl/NujoYwHvbBz4pAuL9

Couple potentially interesting things to note:

  • weirdly if I fullscreen the window before fullscreening the video everything works correctly (demonstrated at the end of the linked video)
  • this occurs only in Firefox, have tested Chrome, Edge & Safari without the same results
  • doesn't seem to be Youtube specific as I have reproed on Vimeo as well

thanks in advance for any help you can give and all the amazing work you've put into this app!

@lwouis
Copy link
Owner Author

lwouis commented May 28, 2020

My first reaction, from the other thread:

I could reproduce the issue in Firefox. I will open a new issue for this, as I believe the root cause is completely different from this ticket here. This ticket here was about a complex interaction where a window is spawned already in fullscreen, and we would detect it as a tab, due to the hacky way we have to detect tabs (no API exist to do it cleanly). Here this Firefox issue seems to be Firefox using some custom view to display fullscreen video, instead of using macOS built-in fullscreen APIs. For instance, moving the mouse cursor to the top of the screen doesn't bring the normal fullscreen title bar, and also invoking Expose reveals that they are not fullscreening, as normal fullscreen on macOS uses a dedicated Space.

Interestingly, when you fullscreen Firefox using the top left button, it does native fullscreening. Then when you double-click a video, it shows the fullscreen window within the fullscreen'ed window, which normal native behavior.

I'll see what can be done, but off the bat there is a chance that nothing can be done as we use the Accessibility API to understand what windows are shown to the user. If an app draws hacky custom views instead of using macOS windows (AppKit's NSWindow or NSPanel), then these windows are not reported by the Accessibility API and they basically don't exist as far as AltTab (but also potentially other accessibility software, like a screen reader) is concerned.

@lwouis lwouis added the bug Something isn't working label May 28, 2020
@nathanshelly
Copy link

Thanks for the followup here!

Did some additional digging based on your comments about non-native fullscreen and came across this Firefox bug & the associated fix.

Setting the native fullscreen preference like the photo below fixes this behavior and allows AltTab to find it:

image

Apologies for not doing my due diligence earlier, feel free to close this out anytime.

@lwouis
Copy link
Owner Author

lwouis commented May 28, 2020

@nathanshelly Thanks for sharing this finding. I'm not sure why this is not the default 3 years later, but Mozilla must have their reasons.

I'm fine with whitelisting/hardcoding things to help support major apps. Firefox is a major app. So I'm going to add an exception for Firefox, so its fake-fullscreen windows appear in AltTab. This way noone has to change the obscure flag, and by the way I totally agree with their rationale that the default fullscreen experience is bad UX. It's sluggish, create another Space, and other jank. So it can only be a plus to support both fullscreen mode on Firefox.

@lwouis lwouis closed this as completed in ce63367 May 28, 2020
lwouis pushed a commit that referenced this issue May 28, 2020
## [4.0.1](v4.0.0...v4.0.1) (2020-05-28)

### Bug Fixes

* firefox fullscreen videos are not listed (closes [#360](#360)) ([ce63367](ce63367))
* updated chinese/french/russian localizations ([797ed42](797ed42))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants