Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Close on Esc #44

Closed
eyeds opened this issue Oct 18, 2019 · 3 comments
Closed

Close on Esc #44

eyeds opened this issue Oct 18, 2019 · 3 comments
Labels
enhancement New feature or request

Comments

@eyeds
Copy link

eyeds commented Oct 18, 2019

Not sure, how it is now in Windows 10, but my fingers remember that when looping through windows hitting Esc cancels it, which is pretty useful when you've changed you mind or satisfied with a window preview. Of course Ctr-Shift-Tab is an option to go back but not that useful.
@lwouis
Copy link
Owner

lwouis commented Oct 20, 2019

I think you're right. This sounds very useful! I'll try to do it when I have time. Of course you may want to submit a PR ;p

@lwouis lwouis added enhancement New feature or request S size labels Oct 20, 2019
@lwouis lwouis closed this as completed in b6e4826 Oct 25, 2019
lwouis pushed a commit that referenced this issue Oct 25, 2019
@semantic-release-bot
chore(release): 1.7.0 [skip ci]
e101dda 
# [1.7.0](v1.6.1...v1.7.0) (2019-10-25)

### Bug Fixes

* don't crash when the OS doesn't return an icon ([ce6f6aa](ce6f6aa))

### Features

* close main window when (meta and) escape is pressed (closes [#44](#44)) ([b6e4826](b6e4826))
@lwouis
Copy link
Owner

lwouis commented Oct 25, 2019

@eyeds release 1.7.0 adds this feature. Check it out!

@lwouis lwouis mentioned this issue Oct 25, 2019
Closed
@lwouis
Copy link
Owner

lwouis commented Oct 25, 2019

Update: there was a regression in that release. Please download the latest version instead. Sorry about that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lwouis @eyeds