Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YouTube fullscreen windows in Firefox Developer Edition don't show in AltTab #558

Closed
ghost opened this issue Aug 27, 2020 · 3 comments
Closed
Labels
bug Something isn't working

Comments

@ghost
Copy link

ghost commented Aug 27, 2020

Steps to reproduce the bug

  1. Install Firefox Developer and simply go a a YouTube video and make it full-screen.
  2. Now toggle AltTab. Notice that (current) window is missing. Means you can't alt-tab back to it again either. If I alt-tab away my only way to get back to the window is to find it in Mission Control.

I think it's a buggy behaviour in Firefox Developer, and normal Firefox doesn't do the same thing, but maybe other apps could produce the same scenario so it's worth finding a way to fix it.

@ghost ghost added the bug Something isn't working label Aug 27, 2020
@lwouis
Copy link
Owner

lwouis commented Aug 27, 2020

Hey @mindfulsource, thanks for sharing this issue!

I'm pretty sure I know what the issue is already. I made a fix for Firefox previously in #360. That fix whitelists Firefox bundleIdentifier and allows its fullscreen windows to show up. Firefox Developer has a different bundleIdentifier: org.mozilla.firefoxdeveloperedition.

I can whitelist this app too. These workarounds are a pain. I opened #456 to discuss a better way to handle things, but it needs a breakthrough idea. Nobody has found a better approach that the current one so far, unfortunately.

It's a messy problem. Too permissive, and garbage windows start showing up (#386); too restrictive, and actual windows don't show up, like here.

@lwouis
Copy link
Owner

lwouis commented Aug 27, 2020

I made a fix. It will ship in the next release. If you want to help with the big picture, please look into #456

@lwouis lwouis closed this as completed in 3250d37 Aug 27, 2020
lwouis pushed a commit that referenced this issue Aug 27, 2020
# [6.0.0](v5.3.0...v6.0.0) (2020-08-27)

### Bug Fixes

* alt-tab own windows were not shown in alt-tab (closes [#555](#555)) ([8bcbc04](8bcbc04))
* clicking the main window would steal focus ([de02e5b](de02e5b))
* display firefox develop edition fullscreen windows (closes [#558](#558)) ([3250d37](3250d37))
* guarantee alt-tab window is always up-to-date on display ([be4c5f1](be4c5f1))
* ignore zombie processes ([50c8c82](50c8c82))
* moving some of the preferences sliders was very laggy ([a552c4c](a552c4c))
* shortcuts stop working if active app is quit (closes [#557](#557)) ([023561d](023561d))

### Features

* display quickly even with many open windows (closes [#171](#171)) ([da16a0b](da16a0b))
* improve the 3 colored buttons when hovering (closes [#516](#516)) ([3ddedff](3ddedff))
* update chinese localization ([e150a9a](e150a9a))

### Performance Improvements

* alt-tab appears quicker when summoned ([c2bb896](c2bb896))
* main window appears (a few frames) faster on trigger ([2bc09e6](2bc09e6))

### BREAKING CHANGES

* the window thumbnails are now updated *after* the UI is shown. AltTab will first display its window, with the first 3 thumbnails up-to-date, then asynchronously update the rest of the thumbnails one-by-one. This improves the experience of users with lots of windows open.
@lwouis
Copy link
Owner

lwouis commented Sep 7, 2020

@mindfulsource Please open a new issue for this other app. Let's try to keep ticket focused. Also that way you can use the issue template to provide all the useful information to move forward with the issue 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant