Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[In-app feedback] #792

Closed
alt-tab-macos-bot opened this issue Jan 31, 2021 · 2 comments
Closed

[In-app feedback] #792

alt-tab-macos-bot opened this issue Jan 31, 2021 · 2 comments
Labels
bug Something isn't working

Comments

@alt-tab-macos-bot
Copy link

This issue was opened by a bot after a user submitted feedback through the in-app form.

From: [email protected]

Message:

Hi,

Great work guys!

I have a bug here, Alttab does not show the VLC window (when VLC is in full screen), can you please take a look at that?
If for some reason it is not reproducable, I'm happy to share screenshots or PoC.
@lwouis
Copy link
Owner

lwouis commented Feb 1, 2021

Hi!

It sounds like this could be a duplicate of #794. Could you please check and confirm that changing the preference discussed there makes it show the VLC fullscreen window for you? If that's the case then it's the same issue. I'll release a fix soon 👍

@lwouis lwouis closed this as completed Feb 1, 2021
@lwouis lwouis added duplicate This issue or pull request already exists bug Something isn't working and removed duplicate This issue or pull request already exists labels Feb 1, 2021
@lwouis
Copy link
Owner

lwouis commented Feb 2, 2021

The user shared a video showing that the issue is specific to VLC in fullscreen. I was able to reproduce the issue on my machine. It seems that VLC uses a non-native fullscreen mode by default:

image

This is similar to what Firefox was doing, for which I already shipped a workaround. I'll probably implement a similar one for VLC.

@lwouis lwouis reopened this Feb 2, 2021
lwouis added a commit that referenced this issue Feb 2, 2021
@lwouis
fix: show vlc fullscreen video (closes #792)
a366d72
@lwouis lwouis closed this as completed in e675fab Feb 2, 2021
lwouis pushed a commit that referenced this issue Feb 2, 2021
@semantic-release-bot
chore(release): 6.15.0 [skip ci]
21f1a9c 
# [6.15.0](v6.14.0...v6.15.0) (2021-02-02)

### Bug Fixes

* show vlc fullscreen video (closes [#792](#792)) ([e675fab](e675fab))

### Features

* update russian localization ([909c123](909c123))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lwouis @alt-tab-macos-bot