Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remaining window controls #925

Closed
decodism opened this issue Apr 18, 2021 · 5 comments
Closed

Remaining window controls #925

decodism opened this issue Apr 18, 2021 · 5 comments
Labels
bug Something isn't working

Comments

@decodism
Copy link
Contributor

Describe the bug

In some cases, when a window is closed by the UI button in AltTab, the window controls move to another element.

Steps to reproduce the bug

  • Open a single window
  • Close the window with the button in AltTab
  • Open another window
  • Invoke AltTab

Or

  • Open 3+ windows
  • Close one of the central windows with the button in AltTab

Possible solution

Add showOrHideWindowControls(false) in "updateRecycledCellWithNewContent".

@decodism decodism added the bug Something isn't working label Apr 18, 2021
@lwouis
Copy link
Owner

lwouis commented Apr 20, 2021

Hi @decodism, thanks for sharing this issue

I'm not understanding the scenario completely. Especially "the window controls move to another element". There is no animations, so what do you mean by "move"?

I tried to follow the steps you provided, but what I see seems correct to me.

Could you please share a video of the issue in motion? It would really help visualize the problem 👍

@lwouis lwouis added unclear Need help from the author to provide more information to flesh out the issue unreproducible Need help from the author to reproduce the issue labels Apr 20, 2021
@decodism
Copy link
Contributor Author

Done:

alt-tab.mov

@lwouis
Copy link
Owner

lwouis commented Apr 20, 2021

The video shows correct behavior to me.

  • Untitled 2 is selected (black background)
  • Untitled 2 is closed
  • Untitled 3 gets selected since it takes the second position in the list now that Untitled 2 doesn't exist anymore
  • The mouse has not moved at all since clicking the red button, so there is no selection of the window under the mouse

In short, the mouse needs to move to trigger re-selection of what's under it. This is very much on purpose, to avoid users moving the mouse by mistake when they use the keyboard shortcuts to move around. You can see #286 for more in-depth discussion around these mouse + keyboard scenarios.

For now I'll close the ticket as this is working correctly.

@lwouis lwouis closed this as completed Apr 20, 2021
@lwouis lwouis added support/question The author was looking for help, or didn't understand something and though it was a bug and removed bug Something isn't working unclear Need help from the author to provide more information to flesh out the issue unreproducible Need help from the author to reproduce the issue labels Apr 20, 2021
@decodism
Copy link
Contributor Author

I am not questioning the selection behavior, but the fact that the window control buttons get "recycled" to the newly selected window. You can even see that they are in a "pressed" state.

@lwouis lwouis reopened this Apr 20, 2021
@lwouis
Copy link
Owner

lwouis commented Apr 20, 2021

Oh I missed the point indeed!

The buttons are supposed to only appear on mouse hover, so they shouldn't show after the click. I'll look into it!

Thank you for insisting and helping me understand the issue 👍

@lwouis lwouis added bug Something isn't working and removed support/question The author was looking for help, or didn't understand something and though it was a bug labels Apr 20, 2021
@lwouis lwouis closed this as completed in ba9d675 Aug 30, 2021
lwouis pushed a commit that referenced this issue Aug 30, 2021
# [6.23.0](v6.22.1...v6.23.0) (2021-08-30)

### Bug Fixes

* fix situations from some crash reports ([c18aa4d](c18aa4d))
* ghost popup windows in android studio (closes [#1056](#1056)) ([6f33e3a](6f33e3a))
* hide window controls after a window is closed (closes [#925](#925)) ([0dad739](0dad739))
* highlight right thumbnail when no window is focused (closes [#1044](#1044)) ([f4d3db7](f4d3db7))
* showing windows of other screens when it shouldn't (closes [#1052](#1052)) ([b5b3c38](b5b3c38))

### Features

* add vietnamese and luxembourgish localizations ([749db12](749db12))
* improve french, portuguese and chinese localizations ([a7026a4](a7026a4))
* remove "active space" from filter list ([4623e5b](4623e5b))
* support voiceover + "speak items under the cursor" (closes [#1070](#1070)) ([c7911f3](c7911f3))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants