fix: incorrect display of submenu items when multiple menu dropdowns are implemented #354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for anatole-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
lxndrblz
reviewed
May 5, 2022
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe the issue fixed here
When having two dropdown menus in the navigating bar, clicking on the second menu displays the first dropdown menu. The reason for that was that dropdown was connected to an id which initially was implemented with a static value - "menuoptionpicker". This results in an issue when you implement more than 1 menu dropdown - since id is static, all dropdowns will point to the first submenu list with "menuoptionpicker" id defined.
I've resolved this by implementing a pseudorandom uid for every menu dropdown. After multiple investigations on how generation of unique IDs can be implemented in Hugo, I've landed on current implementation. Since it's a functionality which will not require hundreds or thousands of unique IDs the range defined in current implementation should suffice.
Issue Number:
Navigating dropdown menu displaying error #352
Additional Information (Optional)
Checklist
Yes, I included all necessary artefacts, including:
Testing Checklist
Yes, I ensured that all of the following scenarios were tested:
Notify the following users