fix: back navigation from version details view (#219)

Signed-off-by: csirius <[email protected]>
flyteorg · Sep 28, 2021 · 003d6ca · 003d6ca
1 parent 6b83d2d
commit 003d6ca
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 2 deletions.
diff --git a/src/components/Entities/EntityDetails.tsx b/src/components/Entities/EntityDetails.tsx
@@ -68,6 +68,7 @@ function getLaunchProps(id: ResourceIdentifier) {
  * for use with all entities (not all entities have schedules, for example).
  * @param id
  * @param versionView
+ * @param showStaticGraph
  */
 export const EntityDetails: React.FC<EntityDetailsProps> = ({
     id,
@@ -88,6 +89,7 @@ export const EntityDetails: React.FC<EntityDetailsProps> = ({
                 project={project.value}
                 id={id}
                 launchable={!!sections.launch}
+                versionView={versionView}
                 onClickLaunch={onLaunch}
             />
             {!versionView && (

diff --git a/src/components/Entities/EntityDetailsHeader.tsx b/src/components/Entities/EntityDetailsHeader.tsx
@@ -8,6 +8,7 @@ import { Project } from 'models/Project/types';
 import { getProjectDomain } from 'models/Project/utils';
 import * as React from 'react';
 import { Link } from 'react-router-dom';
+import { Routes } from 'routes/routes';
 import { launchStrings } from './constants';
 import { backUrlGenerator } from './generators';
 
@@ -34,14 +35,24 @@ interface EntityDetailsHeaderProps {
     project: Project;
     id: ResourceIdentifier;
     launchable?: boolean;
+    versionView: boolean;
     onClickLaunch?(): void;
 }
 
-/** Renders the entity name and any applicable actions.  */
+/**
+ * Renders the entity name and any applicable actions.
+ * @param id
+ * @param onClickLaunch
+ * @param launchable
+ * @param versionView
+ * @param project
+ * @constructor
+ */
 export const EntityDetailsHeader: React.FC<EntityDetailsHeaderProps> = ({
     id,
     onClickLaunch,
     launchable = false,
+    versionView,
     project
 }) => {
     const styles = useStyles();
@@ -58,7 +69,15 @@ export const EntityDetailsHeader: React.FC<EntityDetailsHeaderProps> = ({
             >
                 <Link
                     className={commonStyles.linkUnstyled}
-                    to={backUrlGenerator[id.resourceType](id)}
+                    to={
+                        versionView
+                            ? Routes.WorkflowDetails.makeUrl(
+                                  id.project,
+                                  id.domain,
+                                  id.name
+                              )
+                            : backUrlGenerator[id.resourceType](id)
+                    }
                 >
                     <ArrowBack color="inherit" />
                 </Link>