Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change from Lynx to Stockfish #4

Closed
FatFritz2 opened this issue Oct 13, 2023 · 7 comments
Closed

Change from Lynx to Stockfish #4

FatFritz2 opened this issue Oct 13, 2023 · 7 comments

Comments

@FatFritz2
Copy link

Can you help me to get Stockfish in this repo ?
I have already looked at docker-publish.yml and docker-compose.yml to merge lichess-bot here but I am stucking
Thanks

@eduherminio
Copy link
Member

At which point of the process did you get stuck?
As commented in #2, you first need to generate a docker image that contains both Stockfish binaries and a clone of lichess-bot pointing at them. The content of docker-publish.yml can serve as an example of how to do it using GH actions

you would need to first replicate what I do in docker-publish.yml but using Stockfish binaries to mix them with lichess-bot-devs/lichess-bot in an image.

@FatFritz2
Copy link
Author

Yeah i am stucking at that
I mean i cant get the sf binary in the yml

@eduherminio
Copy link
Member

  • You bot config file defines the path where the binary is expected to be found (in this case we're talking about the path inside of the docker container).
    i.e. lynx_bot-config.yml.

  • You need to make sure Stockfish binaries end up being copied there during the image build process. You do that in your Dockerfile

  • What I do in docker-publish.yml is downloading the right version of Lynx, and place it where my Dockerfile expects it.

    If you're trying to build the image locally, you can just put it in the right directory locally and forget about that file

@FatFritz2
Copy link
Author

  • You bot config file defines the path where the binary is expected to be found (in this case we're talking about the path inside of the docker container).
    i.e. lynx_bot-config.yml.
  • You need to make sure Stockfish binaries end up being copied there during the image build process. You do that in your Dockerfile
  • What I do in docker-publish.yml is downloading the right version of Lynx, and place it where my Dockerfile expects it.
    If you're trying to build the image locally, you can just put it in the right directory locally and forget about that file

I dont do it locally, I wanna put it up to the cloud

@eduherminio
Copy link
Member

I'm talking about where to build the image, not about where to run it.

But the procedure would be the same if you wanted to build it using GH actions as I do: make sure that the right stockfish binaries are placed in the right locations where the dockerfile expects them, and in the dockerfile make sure you copy them wherever your bot config file expects it.

@FatFritz2
Copy link
Author

FatFritz2 commented Oct 15, 2023

It seems like your Dockerfile has some problems ? NB: I used your default Lynx engine
image

@eduherminio
Copy link
Member

I'm going to need some more context about that screenshot to be able to help you further, but this does not look like an issue with my Dockerfile 😃
image

@eduherminio eduherminio closed this as not planned Won't fix, can't repro, duplicate, stale Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants