Add jr, sr, and ph.d to punkt abbreviations #1053
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've noticed some cases of the
large-v3-turbomodel outputting text likeRichard Jr.'s favorite toy. In my testing this has caused a mismatch between the sentence spans (punkt considersJr.to be the end of a sentence) and the aligned words (Jr.'is a separate word after alignment). This means searching for the aligned word in the sentence text will fail due to the missing'. This PR simply configures a few extra abbreviations in the punkt parameters, namelyJr.,Sr., andPh.D., which should avoid these unexpected sentence splits.Open to suggestions on other abbreviations to add.