Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GUI state management for interactive arguments #2624

Open
SimonRenblad opened this issue Nov 22, 2024 · 3 comments · May be fixed by #2674
Open

GUI state management for interactive arguments #2624

SimonRenblad opened this issue Nov 22, 2024 · 3 comments · May be fixed by #2674
Assignees
Milestone

Comments

@SimonRenblad
Copy link
Contributor

ARTIQ Feature Request

See: https://forum.m-labs.hk/d/843-group-closes-after-clicking-submit-button-in-interactive-window

Problem this request addresses

Groups are not expanded by default in interactive arguments, and do not save GUI state across submissions.

Describe the solution you'd like

A way to save state / programmatically set the expanded state of the groups in interactive argument widgets.

Context / First Thoughts

My first thought was to expand the interactive context manager with an additional interface like interactive.set_expanded("<group_name>"). As I discussed in the forum post, there are some hurdles that make using the existing GUI state system for this a bit more complex (but not impossible ofc).

@sbourdeauducq
Copy link
Member

The expanded/closed status is very much a GUI thing and I don't think it should be in the experiment code. What about remembering, say, the status of the last 100 requests (identified just by experiment, request, and/or group name) and expanding accordingly?

@SimonRenblad
Copy link
Contributor Author

It would be possible, of course. There is still the case of how to handle interactive arguments from the same experiment running at the same time in different pipelines, as it may lead to some confusing behavior. That being said I'll spend some time working on this so we can see more concretely what behavior is desirable.

@sbourdeauducq
Copy link
Member

That's easy to handle, just make the key a tuple with the pipeline name as one of the elements.

@sbourdeauducq sbourdeauducq added this to the ARTIQ-9 milestone Nov 24, 2024
@fsagbuya fsagbuya linked a pull request Feb 7, 2025 that will close this issue
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants