Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADR: architecture for fast groupby behavior #135

Closed
machow opened this issue Oct 20, 2019 · 0 comments
Closed

ADR: architecture for fast groupby behavior #135

machow opened this issue Oct 20, 2019 · 0 comments
Labels
time:5 Half a day or more

Comments

@machow
Copy link
Owner

machow commented Oct 20, 2019

  1. When should it fail, vs fall back to apply? Should it emit a warning? How could this be customized?

  2. How could singledispatch be used with CallTreeVisitor? Can we demo using a vector function (e.g. row_number, n, cumsum)

  3. Could type annotations be leveraged here? E.g. automatically wrap a vector function based on it's return type, or some other function annotation.

  4. How can a user audit the behaviors siuba will take before executing e.g. a grouped mutate?

  5. Premortem: pretend we're looking back 3 months from now, and the process is not working--what are the main reasons that is (e.g. user perspective, dev, perspective, person who has been programming for 1 day perspective)?

@machow machow added the time:5 Half a day or more label Oct 20, 2019
@machow machow mentioned this issue Oct 29, 2019
@machow machow closed this as completed Oct 29, 2019
@machow machow added this to siuba Jan 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
time:5 Half a day or more
Projects
Status: No status
Development

No branches or pull requests

1 participant