Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly testing dependency versions supported on travis #162

Closed
machow opened this issue Nov 30, 2019 · 1 comment
Closed

Explicitly testing dependency versions supported on travis #162

machow opened this issue Nov 30, 2019 · 1 comment

Comments

@machow
Copy link
Owner

machow commented Nov 30, 2019

Some key questions:

  • Should we support pandas~=0.23.0? Likely not too hard, requires patching (1) ser.shift which is missing the fill_value argument, (2) no ser.dt.timetz property, (3) what appears to be a small bug in ser.pct_change?

  • Should we test pip install ./ and tests on all supported python versions? (3.6, 3.7, 3.8)

  • What about testing mac, windows, etc..?

I've got this 90% of the way on https://github.com/machow/siuba/tree/travis-py38

@machow
Copy link
Owner Author

machow commented Nov 30, 2019

Supporting v0.23.0 is probably not worth it right now. This is unfortunate, since v0.24.0 was released Jan 2019, so we depend on a version released a year ago.

(But this is probably the least of siuba's problems)

@machow machow closed this as completed Nov 30, 2019
@machow machow added this to siuba Jan 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

1 participant