From c40d9b40589e3ecd58854a905929b81d12a04e98 Mon Sep 17 00:00:00 2001 From: Yee Cheng Chin Date: Tue, 14 Mar 2023 22:17:23 -0700 Subject: [PATCH] Fix qlstephen project warnings Part of this was originally part of #1178 but we removed the qlstephen parts to prepare for eventual removal. Couple years later and we haven't removed qlstephen yet, so just fix the warnings for now first. From #1178: - Fix the project localization name from English to "en" - Set ALWAYS_SEARCH_USER_PATHS to "NO" Also: - Remove the hard-coded macOS 10.8 deployment target which actually isn't supported by modern Xcode versions. Just unset it as our CI usually sets that for us. - The post-build script is now tagged properly to always run. - Ignore all deprecation warnings. These were exposed because we removed the 10.8 deployment target. Since we aren't going to be fixing them (we are either just going to grab newer versions from upsteram, or delete this), there's no point in having these warnings. --- .../QuickLookStephen.xcodeproj/project.pbxproj | 14 +++++++++----- .../{English.lproj => en.lproj}/InfoPlist.strings | Bin 2 files changed, 9 insertions(+), 5 deletions(-) rename src/MacVim/qlstephen/{English.lproj => en.lproj}/InfoPlist.strings (100%) diff --git a/src/MacVim/qlstephen/QuickLookStephen.xcodeproj/project.pbxproj b/src/MacVim/qlstephen/QuickLookStephen.xcodeproj/project.pbxproj index c7de7370d6..db39c3f982 100644 --- a/src/MacVim/qlstephen/QuickLookStephen.xcodeproj/project.pbxproj +++ b/src/MacVim/qlstephen/QuickLookStephen.xcodeproj/project.pbxproj @@ -24,13 +24,13 @@ 0107ABFC15C76F2900C65F1A /* QLSFileAttributes.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = QLSFileAttributes.h; sourceTree = ""; }; 0107ABFD15C76F2900C65F1A /* QLSFileAttributes.m */ = {isa = PBXFileReference; fileEncoding = 4; indentWidth = 2; lastKnownFileType = sourcecode.c.objc; path = QLSFileAttributes.m; sourceTree = ""; tabWidth = 2; usesTabs = 0; }; 0149EB3D15F2E9A3003AB298 /* libicucore.dylib */ = {isa = PBXFileReference; lastKnownFileType = "compiled.mach-o.dylib"; name = libicucore.dylib; path = usr/lib/libicucore.dylib; sourceTree = SDKROOT; }; - 089C167EFE841241C02AAC07 /* English */ = {isa = PBXFileReference; fileEncoding = 10; lastKnownFileType = text.plist.strings; name = English; path = English.lproj/InfoPlist.strings; sourceTree = ""; }; 08FB77B6FE84183AC02AAC07 /* main.c */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.c; path = main.c; sourceTree = ""; }; 0AA1909FFE8422F4C02AAC07 /* CoreFoundation.framework */ = {isa = PBXFileReference; lastKnownFileType = wrapper.framework; name = CoreFoundation.framework; path = /System/Library/Frameworks/CoreFoundation.framework; sourceTree = ""; }; 2C05A19B06CAA52B00D84F6F /* GeneratePreviewForURL.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = GeneratePreviewForURL.m; sourceTree = ""; usesTabs = 0; }; 61E3BCFA0870B4F2002186A0 /* GenerateThumbnailForURL.m */ = {isa = PBXFileReference; fileEncoding = 30; lastKnownFileType = sourcecode.c.objc; path = GenerateThumbnailForURL.m; sourceTree = ""; }; 8D576316048677EA00EA77CD /* QLStephen.qlgenerator */ = {isa = PBXFileReference; explicitFileType = wrapper.cfbundle; includeInIndex = 0; path = QLStephen.qlgenerator; sourceTree = BUILT_PRODUCTS_DIR; }; 8D576317048677EA00EA77CD /* Info.plist */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text.plist; path = Info.plist; sourceTree = ""; }; + 95241CDF2573D584001E3711 /* en */ = {isa = PBXFileReference; lastKnownFileType = text.plist.strings; name = en; path = en.lproj/InfoPlist.strings; sourceTree = ""; }; AE02F6EA0EDDFA6400CBA17D /* Cocoa.framework */ = {isa = PBXFileReference; lastKnownFileType = wrapper.framework; name = Cocoa.framework; path = /System/Library/Frameworks/Cocoa.framework; sourceTree = ""; }; C86B05260671AA6E00DD9006 /* CoreServices.framework */ = {isa = PBXFileReference; lastKnownFileType = wrapper.framework; name = CoreServices.framework; path = /System/Library/Frameworks/CoreServices.framework; sourceTree = ""; }; F28CFBFC0A3EC0AF000ABFF5 /* ApplicationServices.framework */ = {isa = PBXFileReference; lastKnownFileType = wrapper.framework; name = ApplicationServices.framework; path = /System/Library/Frameworks/ApplicationServices.framework; sourceTree = ""; }; @@ -138,10 +138,11 @@ }; buildConfigurationList = 2CA326220896AD4900168862 /* Build configuration list for PBXProject "QuickLookStephen" */; compatibilityVersion = "Xcode 3.2"; - developmentRegion = English; + developmentRegion = en; hasScannedForEncodings = 1; knownRegions = ( en, + Base, ); mainGroup = 089C166AFE841209C02AAC07 /* QuickLookStephen */; projectDirPath = ""; @@ -166,6 +167,7 @@ /* Begin PBXShellScriptBuildPhase section */ 698210201CC62DD000504BBF /* ShellScript */ = { isa = PBXShellScriptBuildPhase; + alwaysOutOfDate = 1; buildActionMask = 2147483647; files = ( ); @@ -197,7 +199,7 @@ 8D5B49A704867FD3000E48DA /* InfoPlist.strings */ = { isa = PBXVariantGroup; children = ( - 089C167EFE841241C02AAC07 /* English */, + 95241CDF2573D584001E3711 /* en */, ); name = InfoPlist.strings; sourceTree = ""; @@ -240,12 +242,13 @@ 2CA326230896AD4900168862 /* Debug */ = { isa = XCBuildConfiguration; buildSettings = { + ALWAYS_SEARCH_USER_PATHS = NO; ENABLE_TESTABILITY = YES; GCC_C_LANGUAGE_STANDARD = c99; GCC_PREPROCESSOR_DEFINITIONS = "RKL_PREPEND_TO_METHODS=rkl_"; + GCC_WARN_ABOUT_DEPRECATED_FUNCTIONS = NO; GCC_WARN_ABOUT_RETURN_TYPE = YES; GCC_WARN_UNUSED_VARIABLE = YES; - MACOSX_DEPLOYMENT_TARGET = 10.8; ONLY_ACTIVE_ARCH = YES; SDKROOT = macosx; WARNING_CFLAGS = ( @@ -259,11 +262,12 @@ 2CA326240896AD4900168862 /* Release */ = { isa = XCBuildConfiguration; buildSettings = { + ALWAYS_SEARCH_USER_PATHS = NO; GCC_C_LANGUAGE_STANDARD = c99; GCC_PREPROCESSOR_DEFINITIONS = "RKL_PREPEND_TO_METHODS=rkl_"; + GCC_WARN_ABOUT_DEPRECATED_FUNCTIONS = NO; GCC_WARN_ABOUT_RETURN_TYPE = YES; GCC_WARN_UNUSED_VARIABLE = YES; - MACOSX_DEPLOYMENT_TARGET = 10.8; SDKROOT = macosx; WARNING_CFLAGS = ( "-Wextra", diff --git a/src/MacVim/qlstephen/English.lproj/InfoPlist.strings b/src/MacVim/qlstephen/en.lproj/InfoPlist.strings similarity index 100% rename from src/MacVim/qlstephen/English.lproj/InfoPlist.strings rename to src/MacVim/qlstephen/en.lproj/InfoPlist.strings