Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add postcss-aspect-ratio #42

Open
dbox opened this issue Sep 5, 2016 · 10 comments
Open

add postcss-aspect-ratio #42

dbox opened this issue Sep 5, 2016 · 10 comments
Labels
Milestone

Comments

@dbox
Copy link

dbox commented Sep 5, 2016

Seems perfect for Rucksack.. something everyone has to have in their responsive toolkit.
https://github.com/arccoza/postcss-aspect-ratio

Happy to attempt a PR if you want it.

@dbox
Copy link
Author

dbox commented Oct 21, 2016

@seaneking would you accept a PR with this?

@madeleineostoja
Copy link
Owner

madeleineostoja commented Oct 21, 2016

whoops sorry missed this. Not sure if aspect ratio us a good fit for rucksack or not, it's quite heavy handed it what it does. As a developer looking through code with that declaration in it, I wouldn't expect the children of the element to be absolutely positioned etc etc.

More than happy to get feedback from the community on this one though, if there's demand for it then would definitely consider it.

@dbox
Copy link
Author

dbox commented Dec 12, 2016

It's a very standard (and crucial imho) technique, but obviously it's your call. :)

@madeleineostoja
Copy link
Owner

The padding hack is, but all the other assumptions postcss-aspect ratio make aren't (abspos children etc). That said haven't looked at it for a while.

@dbox
Copy link
Author

dbox commented Dec 12, 2016

There's no other way to do content inside it without it.

@jescalan
Copy link
Contributor

Would love to see this functionality added, its a nice shortcut for a common css code pattern 👬

@covingtondoan
Copy link

+1 for aspect ratios!

I find myself needing to do that more often that I would have thought.

@madeleineostoja
Copy link
Owner

Okay, sounds like I'm the minority on this one. Would accept a PR.

While we're all here - what do we think of #47?

FWIW postcss-alias is pretty buggy, and the bugs are pretty fundamental (regexing aliases out of both property names and values).

@dbox
Copy link
Author

dbox commented Jun 21, 2017

sweet. I'll PR this

@mwickett
Copy link

Excited that this will be added - another vote for it!

@madeleineostoja madeleineostoja added this to the 1.0 milestone Jun 21, 2017
@madeleineostoja madeleineostoja changed the title add postcss-aspect-ratio? add postcss-aspect-ratio Jun 21, 2017
@madeleineostoja madeleineostoja modified the milestones: 1.0, 2.0 Nov 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants