You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The "mage:import" directive comment looks very much like it falls in the family of directive comments used by the compiler and other tools, for example linters (see golang/go#43776).
However it specifies in the documentation that a leading space should be included. The code specifically does not require this, so I would like to suggest that the documentation be changed to exclude the space.
This would have no backward incompatibility issues due to the current acceptance of the no-space variant, but over time would allow the Go community to converge on a consensus approach to using directive comments.
The text was updated successfully, but these errors were encountered:
There is also the issue of the move to bug resistant build tags which should be finalised by 1.18 according to the issue. I will send a PR in two commit, the first handling the original issue and the second adjusting docs for the //go:build tags, but leaving ~all the code alone, I can back out the second commit if you don't want it.
The "mage:import" directive comment looks very much like it falls in the family of directive comments used by the compiler and other tools, for example linters (see golang/go#43776).
However it specifies in the documentation that a leading space should be included. The code specifically does not require this, so I would like to suggest that the documentation be changed to exclude the space.
This would have no backward incompatibility issues due to the current acceptance of the no-space variant, but over time would allow the Go community to converge on a consensus approach to using directive comments.
The text was updated successfully, but these errors were encountered: