Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP Fatal error: Redefinition of parameter $logger in src/Migration/Step/ConfigurablePrices/Volume.php on line 45 #21

Closed
csdougliss opened this issue Dec 14, 2015 · 3 comments

Comments

@csdougliss
Copy link

Nice jobs guys, duplicate param in constructor, logger is there twice (PS that is sarcasm!)

PHP Fatal error: Redefinition of parameter $logger in /Users/ccarnell/Sites/xxx/vendor/magento/data-migration-tool-ee/src/Migration/Step/ConfigurablePrices/Volume.php on line 45

public function __construct(
        Logger $logger,
        ResourceModel\Source $source,
        ResourceModel\Destination $destination,
        ProgressBar\LogLevelProcessor $progressBar,
        Helper $helper,
        Logger $logger
    )

I would post this in the EE repo, but since no one ever replies.. Same issue on CE anyway

@csdougliss csdougliss changed the title PHP Fatal error: Redefinition of parameter $logger in /Users/ccarnell/Sites/vax-uk2/vendor/magento/data-migration-tool-ee/src/Migration/Step/ConfigurablePrices/Volume.php on line 45 Fatal error: Redefinition of parameter $logger in /Users/ccarnell/Sites/vax-uk2/vendor/magento/data-migration-tool-ee/src/Migration/Step/ConfigurablePrices/Volume.php on line 45 PHP Fatal error: Redefinition of parameter $logger in magento/data-migration-tool-ee/src/Migration/Step/ConfigurablePrices/Volume.php on line 45 Fatal error: Redefinition of parameter $logger in /Users/ccarnell/Sites/vax-uk2/vendor/magento/data-migration-tool-ee/src/Migration/Step/ConfigurablePrices/Volume.php on line 45 Dec 14, 2015
@csdougliss csdougliss changed the title PHP Fatal error: Redefinition of parameter $logger in magento/data-migration-tool-ee/src/Migration/Step/ConfigurablePrices/Volume.php on line 45 Fatal error: Redefinition of parameter $logger in /Users/ccarnell/Sites/vax-uk2/vendor/magento/data-migration-tool-ee/src/Migration/Step/ConfigurablePrices/Volume.php on line 45 PHP Fatal error: Redefinition of parameter $logger in src/Migration/Step/ConfigurablePrices/Volume.php on line 45 Dec 14, 2015
@codigoaberto
Copy link

Change it to

public function __construct(
    Logger $logger,
    ResourceModel\Source $source,
    ResourceModel\Destination $destination,
    ProgressBar\LogLevelProcessor $progressBar,
    Helper $helper
)

@ilol
Copy link

ilol commented Jan 12, 2016

@craigcarnell does it work for you?

@csdougliss
Copy link
Author

@ilol It worked for me, I already made that change a while ago (i've had to edit a few things to get it to work)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants