Skip to content
This repository has been archived by the owner on Dec 19, 2019. It is now read-only.

Test coverage: nonExistentCart #429

Closed
naydav opened this issue Mar 4, 2019 · 2 comments
Closed

Test coverage: nonExistentCart #429

naydav opened this issue Mar 4, 2019 · 2 comments
Assignees
@atwixfirster
Labels
Contribution Day Tickets is good for start on Contribution Day good first issue Good for newcomers test-coverage
Milestone
Release: 2.3.2

Comments

@naydav
Copy link
Contributor

naydav commented Mar 4, 2019 •
edited by atwixfirster
Loading

Need to add case when a user tries to work with a non-existent shopping cart to:

\Magento\GraphQl\Quote\Customer\SetPaymentMethodOnCartTest
\Magento\GraphQl\Quote\Guest\SetPaymentMethodOnCartTest
\Magento\GraphQl\Quote\Customer\SetBillingAddressOnCartTest
\Magento\GraphQl\Quote\Guest\SetBillingAddressOnCartTest

Examples you could find in
https://github.com/magento/graphql-ce/tree/2.3-develop/dev/tests/api-functional/testsuite/Magento/GraphQl/Quote/Customer

https://github.com/magento/graphql-ce/tree/2.3-develop/dev/tests/api-functional/testsuite/Magento/GraphQl/Quote/Guest
@naydav naydav added good first issue Good for newcomers test-coverage Contribution Day Tickets is good for start on Contribution Day labels Mar 4, 2019
@naydav naydav added this to the Release: 2.3.2 milestone Mar 4, 2019
@atwixfirster atwixfirster self-assigned this Mar 6, 2019
@atwixfirster atwixfirster mentioned this issue Mar 6, 2019
Merged
@atwixfirster
Copy link
Contributor

Pull request: #444

Thank you!

@naydav
Copy link
Contributor Author

naydav commented Mar 13, 2019

#444

@naydav naydav closed this as completed Mar 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@atwixfirster atwixfirster

Labels
Contribution Day Tickets is good for start on Contribution Day good first issue Good for newcomers test-coverage
Projects
None yet
Milestone
Release: 2.3.2
Development

No branches or pull requests
2 participants
@naydav @atwixfirster