From f03e784b52a23e8d66f14570a10df5da2cbbf59d Mon Sep 17 00:00:00 2001 From: Cristian Partica Date: Wed, 16 May 2018 14:32:04 -0500 Subject: [PATCH 1/6] MAGETWO-91575: Print page of compare page is not correctly aligned - creating a class to hide from printing needed elements --- .../view/frontend/templates/product/compare/list.phtml | 6 +++--- app/design/frontend/Magento/blank/web/css/print.less | 4 ++++ 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/app/code/Magento/Catalog/view/frontend/templates/product/compare/list.phtml b/app/code/Magento/Catalog/view/frontend/templates/product/compare/list.phtml index 6a2dd1f27d4a9..f1d4b32031e49 100644 --- a/app/code/Magento/Catalog/view/frontend/templates/product/compare/list.phtml +++ b/app/code/Magento/Catalog/view/frontend/templates/product/compare/list.phtml @@ -10,7 +10,7 @@ ?> getItems()->getSize() ?> - +
@@ -29,7 +29,7 @@ - + helper('Magento\Catalog\Helper\Product\Compare');?> @@ -59,7 +59,7 @@ getReviewsSummaryHtml($_item, 'short') ?> getProductPrice($_item, '-compare-list-top') ?> -
+
isSaleable()): ?>
diff --git a/app/design/frontend/Magento/blank/web/css/print.less b/app/design/frontend/Magento/blank/web/css/print.less index 474bc27b0751b..ebfc6ce4300b7 100644 --- a/app/design/frontend/Magento/blank/web/css/print.less +++ b/app/design/frontend/Magento/blank/web/css/print.less @@ -132,4 +132,8 @@ .footer.content { padding: 0; } + + .hidden-print { + display: none !important; + } } From 730d0c96b7797e48b4971b2b6379de7f7cc89285 Mon Sep 17 00:00:00 2001 From: Cristian Partica Date: Wed, 16 May 2018 17:38:20 -0500 Subject: [PATCH 2/6] MAGETWO-90569: Empty product attributes of dropdown/swatch types display as "No" of the storefront - type check safety added for boolean vs string/int on dropdown that was causing this bug --- .../Entity/Attribute/Frontend/AbstractFrontend.php | 2 +- .../Magento/Catalog/_files/dropdown_attribute.php | 4 ++-- .../Attribute/Frontend/DefaultFrontendTest.php | 12 ++++++++++++ 3 files changed, 15 insertions(+), 3 deletions(-) diff --git a/app/code/Magento/Eav/Model/Entity/Attribute/Frontend/AbstractFrontend.php b/app/code/Magento/Eav/Model/Entity/Attribute/Frontend/AbstractFrontend.php index 67a0bbefe7510..3d4c9e89a035f 100644 --- a/app/code/Magento/Eav/Model/Entity/Attribute/Frontend/AbstractFrontend.php +++ b/app/code/Magento/Eav/Model/Entity/Attribute/Frontend/AbstractFrontend.php @@ -165,7 +165,7 @@ public function getValue(\Magento\Framework\DataObject $object) $options = $opt->getAllOptions(); if ($options) { foreach ($options as $option) { - if ($option['value'] == $value) { + if ($option['value'] === $value) { $valueOption = $option['label']; } } diff --git a/dev/tests/integration/testsuite/Magento/Catalog/_files/dropdown_attribute.php b/dev/tests/integration/testsuite/Magento/Catalog/_files/dropdown_attribute.php index f55afc8c6a211..bb7e241d972e5 100644 --- a/dev/tests/integration/testsuite/Magento/Catalog/_files/dropdown_attribute.php +++ b/dev/tests/integration/testsuite/Magento/Catalog/_files/dropdown_attribute.php @@ -32,8 +32,8 @@ 'is_filterable_in_search' => 0, 'is_used_for_promo_rules' => 0, 'is_html_allowed_on_front' => 1, - 'is_visible_on_front' => 0, - 'used_in_product_listing' => 0, + 'is_visible_on_front' => 1, + 'used_in_product_listing' => 1, 'used_for_sort_by' => 0, 'frontend_label' => ['Drop-Down Attribute'], 'backend_type' => 'varchar', diff --git a/dev/tests/integration/testsuite/Magento/Eav/Model/Entity/Attribute/Frontend/DefaultFrontendTest.php b/dev/tests/integration/testsuite/Magento/Eav/Model/Entity/Attribute/Frontend/DefaultFrontendTest.php index 7d5cb55ec2f96..3b889c39dca36 100644 --- a/dev/tests/integration/testsuite/Magento/Eav/Model/Entity/Attribute/Frontend/DefaultFrontendTest.php +++ b/dev/tests/integration/testsuite/Magento/Eav/Model/Entity/Attribute/Frontend/DefaultFrontendTest.php @@ -77,6 +77,18 @@ public function testGetSelectOptions() $this->cache->load($this->getCacheKey()) ); } + /** + * @magentoDataFixture Magento/Catalog/_files/dropdown_attribute.php + */ + public function testNotSetAttributeEntityValue() + { + $entity = $this->objectManager->create(\Magento\Catalog\Model\Product::class); + $entity->setStoreId(0); + $entity->load(1); + $frontEnd = $this->attribute->loadByCode('catalog_product', 'dropdown_attribute'); + $value = $frontEnd->getFrontend()->getValue($entity); + $this->assertFalse($value); + } /** * Cache key generation From 86aa6e3850cd6c56ca59b4a9016e7bc237544c36 Mon Sep 17 00:00:00 2001 From: Cristian Partica Date: Thu, 17 May 2018 09:30:12 -0500 Subject: [PATCH 3/6] MAGETWO-90569: Empty product attributes of dropdown/swatch types display as "No" of the storefront - static fix --- .../Model/Entity/Attribute/Frontend/DefaultFrontendTest.php | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/dev/tests/integration/testsuite/Magento/Eav/Model/Entity/Attribute/Frontend/DefaultFrontendTest.php b/dev/tests/integration/testsuite/Magento/Eav/Model/Entity/Attribute/Frontend/DefaultFrontendTest.php index 3b889c39dca36..5e8239586d76b 100644 --- a/dev/tests/integration/testsuite/Magento/Eav/Model/Entity/Attribute/Frontend/DefaultFrontendTest.php +++ b/dev/tests/integration/testsuite/Magento/Eav/Model/Entity/Attribute/Frontend/DefaultFrontendTest.php @@ -77,10 +77,11 @@ public function testGetSelectOptions() $this->cache->load($this->getCacheKey()) ); } + /** * @magentoDataFixture Magento/Catalog/_files/dropdown_attribute.php */ - public function testNotSetAttributeEntityValue() + public function testAttributeEntityValueNotSet() { $entity = $this->objectManager->create(\Magento\Catalog\Model\Product::class); $entity->setStoreId(0); From 6c799ecbb82c9ef66a5db5e3006beda99fc0597c Mon Sep 17 00:00:00 2001 From: Deepty Thampy Date: Fri, 18 May 2018 09:57:22 -0500 Subject: [PATCH 4/6] MAGETWO-91893: Verify the product attribute is not visible on storefront if it is empty for the Product - added test --- .../Catalog/Data/ProductAttributeData.xml | 2 +- .../Catalog/Data/ProductData.xml | 1 + ...torefrontProductWithEmptyAttributeTest.xml | 61 +++++++++++++++++++ 3 files changed, 63 insertions(+), 1 deletion(-) create mode 100644 dev/tests/acceptance/tests/functional/Magento/FunctionalTest/Catalog/Test/StorefrontProductWithEmptyAttributeTest.xml diff --git a/dev/tests/acceptance/tests/functional/Magento/FunctionalTest/Catalog/Data/ProductAttributeData.xml b/dev/tests/acceptance/tests/functional/Magento/FunctionalTest/Catalog/Data/ProductAttributeData.xml index 0adf1e91ae853..946a3f614c1e1 100644 --- a/dev/tests/acceptance/tests/functional/Magento/FunctionalTest/Catalog/Data/ProductAttributeData.xml +++ b/dev/tests/acceptance/tests/functional/Magento/FunctionalTest/Catalog/Data/ProductAttributeData.xml @@ -32,7 +32,7 @@ ProductAttributeFrontendLabel - attribute + testattribute select global false diff --git a/dev/tests/acceptance/tests/functional/Magento/FunctionalTest/Catalog/Data/ProductData.xml b/dev/tests/acceptance/tests/functional/Magento/FunctionalTest/Catalog/Data/ProductData.xml index 70e15717142d9..cc6a32e7223f9 100644 --- a/dev/tests/acceptance/tests/functional/Magento/FunctionalTest/Catalog/Data/ProductData.xml +++ b/dev/tests/acceptance/tests/functional/Magento/FunctionalTest/Catalog/Data/ProductData.xml @@ -51,6 +51,7 @@ 4 1 1000 + simpleproduct 1 EavStockItem CustomAttributeCategoryIds diff --git a/dev/tests/acceptance/tests/functional/Magento/FunctionalTest/Catalog/Test/StorefrontProductWithEmptyAttributeTest.xml b/dev/tests/acceptance/tests/functional/Magento/FunctionalTest/Catalog/Test/StorefrontProductWithEmptyAttributeTest.xml new file mode 100644 index 0000000000000..c80025c299885 --- /dev/null +++ b/dev/tests/acceptance/tests/functional/Magento/FunctionalTest/Catalog/Test/StorefrontProductWithEmptyAttributeTest.xml @@ -0,0 +1,61 @@ + + + + + + + + <description value="Product attribute should not be visible on storefront if it is empty"/> + <severity value="MAJOR"/> + <testCaseId value="MAGETWO-91893"/> + <group value="product"/> + </annotations> + <before> + <!--<actionGroup ref="LoginAsAdmin" stepKey="loginAsAdmin"/>--> + <createData entity="_defaultCategory" stepKey="createPreReqCategory"/> + <!--<createData entity="productAttributeWithTwoOptions" stepKey="createProductAttribute"/>--> + </before> + <after> + <actionGroup ref="deleteProductUsingProductGrid" stepKey="deleteSimpleProduct"> + <argument name="product" value="SimpleProduct"/> + </actionGroup> + <deleteData createDataKey="createPreReqCategory" stepKey="deletePreReqCategory"/> + <!--<deleteData createDataKey="createProductAttribute" stepKey="deleteProductAttribute"/>--> + <actionGroup ref="logout" stepKey="logoutOfAdmin"/> + </after> + <actionGroup ref="LoginAsAdmin" stepKey="loginAsAdmin1"/> + <amOnPage url="{{ProductAttributePage.url}}" stepKey="navigateToProductAttribute"/> + <waitForPageLoad stepKey="wait1"/> + <!--<click selector="#add" stepKey="addNewAttribute"/>--> + <fillField selector="{{AttributePropertiesSection.DefaultLabel}}" userInput="testattribute" stepKey="fillAttributeLabel"/> + <selectOption selector="{{AttributePropertiesSection.InputType}}" userInput="Dropdown" stepKey="selectCatalogAttributeInputType"/> + <click selector="{{StorefrontPropertiesSection.StoreFrontPropertiesTab}}" stepKey="clickStorefrontPropertiesTab"/> + <selectOption selector="#is_visible_on_front" userInput="Yes" stepKey="isVisibleOnStoreFront"/> + <selectOption selector="#used_in_product_listing" userInput="Yes" stepKey="usedInProductListing"/> + <click selector="{{AttributePropertiesSection.Save}}" stepKey="saveAttribute"/> + <waitForPageLoad stepKey="waitForSaveAttribute"/> + <amOnPage url="{{AdminProductAttributeSetGridPage.url}}" stepKey="amOnAttributeSetPage"/> + <click selector="{{AdminProductAttributeSetGridSection.AttributeSetName('Default')}}" stepKey="chooseDefaultAttributeSet"/> + <waitForPageLoad stepKey="waitForAttributeSetPageLoad"/> + <dragAndDrop selector1="{{UnassignedAttributes.ProductAttributeName('testattribute')}}" selector2="{{Group.FolderName('Product Details')}}" stepKey="moveProductAttributeToGroup"/> + <click selector="{{AttributeSetSection.Save}}" stepKey="saveAttributeSet"/> + <waitForLoadingMaskToDisappear stepKey="waitForLoadingMaskToDisappear" /> + <seeElement selector=".message-success" stepKey="assertSuccess"/> + <actionGroup ref="FillAdminSimpleProductForm" stepKey="fillProductFieldsInAdmin"> + <argument name="category" value="$$createPreReqCategory$$"/> + <argument name="simpleProduct" value="SimpleProduct"/> + </actionGroup> + <actionGroup ref="ClearCacheActionGroup" stepKey="clearCache"/> + <amOnPage url="{{StorefrontProductPage.url(SimpleProduct.urlKey)}}" stepKey="goProductPageOnStorefront"/> + <waitForPageLoad stepKey="waitForProductPageToLoad"/> + <!--<see selector="#product-attribute-specs-table tr th:nth-of-type(1)" stepKey="seeAttribute"/>--> + <!--<scrollTo selector=".additional-attributes tbody td:nth-of-type(1)" stepKey="seeAttribute1"/>--> + <dontSeeElement selector="//table[@id='product-attribute-specs-table']/tbody/tr/th[contains(text(),'testattribute')]" stepKey="seeAttribute2"/> + </test> + </tests> From 527fbbb9957dd99e5a5ebc86d73c84853e5c7b2a Mon Sep 17 00:00:00 2001 From: Deepty Thampy <dthampy@magento.com> Date: Fri, 18 May 2018 10:28:40 -0500 Subject: [PATCH 5/6] MAGETWO-91409: Rush theme not available on Themes Grid with clean 2.3 installation - added functional test --- .../FunctionalTest/Theme/Page/ThemesPage.xml | 14 +++++++++ .../Theme/Section/AdminThemeSection.xml | 21 +++++++++++++ .../FunctionalTest/Theme/Test/ThemeTest.xml | 31 +++++++++++++++++++ 3 files changed, 66 insertions(+) create mode 100644 dev/tests/acceptance/tests/functional/Magento/FunctionalTest/Theme/Page/ThemesPage.xml create mode 100644 dev/tests/acceptance/tests/functional/Magento/FunctionalTest/Theme/Section/AdminThemeSection.xml create mode 100644 dev/tests/acceptance/tests/functional/Magento/FunctionalTest/Theme/Test/ThemeTest.xml diff --git a/dev/tests/acceptance/tests/functional/Magento/FunctionalTest/Theme/Page/ThemesPage.xml b/dev/tests/acceptance/tests/functional/Magento/FunctionalTest/Theme/Page/ThemesPage.xml new file mode 100644 index 0000000000000..358d88875d02f --- /dev/null +++ b/dev/tests/acceptance/tests/functional/Magento/FunctionalTest/Theme/Page/ThemesPage.xml @@ -0,0 +1,14 @@ +<?xml version="1.0" encoding="UTF-8"?> +<!-- + /** + * Copyright © Magento, Inc. All rights reserved. + * See COPYING.txt for license details. + */ +--> + +<pages xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" + xsi:noNamespaceSchemaLocation="../../../../../../vendor/magento/magento2-functional-testing-framework/src/Magento/FunctionalTestingFramework/Page/etc/PageObject.xsd"> + <page name="ThemesPageIndex" url="admin/system_design_theme/" area="admin" module="Magento_Theme"> + <section name="AdminThemeSection"/> + </page> +</pages> diff --git a/dev/tests/acceptance/tests/functional/Magento/FunctionalTest/Theme/Section/AdminThemeSection.xml b/dev/tests/acceptance/tests/functional/Magento/FunctionalTest/Theme/Section/AdminThemeSection.xml new file mode 100644 index 0000000000000..281cc290b4f39 --- /dev/null +++ b/dev/tests/acceptance/tests/functional/Magento/FunctionalTest/Theme/Section/AdminThemeSection.xml @@ -0,0 +1,21 @@ +<?xml version="1.0" encoding="UTF-8"?> +<!-- + /** + * Copyright © Magento, Inc. All rights reserved. + * See COPYING.txt for license details. + */ +--> + +<sections xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" + xsi:noNamespaceSchemaLocation="../../../../../../vendor/magento/magento2-functional-testing-framework/src/Magento/FunctionalTestingFramework/Page/etc/SectionObject.xsd"> + <section name="AdminThemeSection"> + <!--All rows in a specific Column e.g. {{Section.rowsInColumn('columnName')}}--> + <element name="rowsInColumn" type="text" selector="//tr/td[contains(@class, '{{column}}')]" parameterized="true"/> + <!--selector for Theme Title column since it needs to be handled separately--> + <element name="rowsInThemeTitleColumn" type="text" selector="//tbody/tr/td[contains(@class, 'parent_theme')]/preceding-sibling::td"/> + <element name="rowsInColumn" type="text" selector="//tbody/tr/td[contains(@class, '{{column}}')]" parameterized="true"/> + <!--Specific cell e.g. {{Section.gridCell('Name')}}--> + <element name="gridCell" type="text" selector="//table[@id='theme_grid_table']//td[contains(text(), '{{gridCellText}}')]" parameterized="true"/> + <element name="columnHeader" type="text" selector="//thead/tr/th[contains(@class, 'data-grid-th')]/span[text() = '{{label}}']" parameterized="true" timeout="30"/> + </section> +</sections> \ No newline at end of file diff --git a/dev/tests/acceptance/tests/functional/Magento/FunctionalTest/Theme/Test/ThemeTest.xml b/dev/tests/acceptance/tests/functional/Magento/FunctionalTest/Theme/Test/ThemeTest.xml new file mode 100644 index 0000000000000..8764750d473c3 --- /dev/null +++ b/dev/tests/acceptance/tests/functional/Magento/FunctionalTest/Theme/Test/ThemeTest.xml @@ -0,0 +1,31 @@ +<?xml version="1.0" encoding="UTF-8"?> +<!-- + /** + * Copyright © Magento, Inc. All rights reserved. + * See COPYING.txt for license details. + */ +--> + +<tests xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" + xsi:noNamespaceSchemaLocation="../../../../../../vendor/magento/magento2-functional-testing-framework/src/Magento/FunctionalTestingFramework/Test/etc/testSchema.xsd"> + <test name="ThemeTest"> + <annotations> + <features value="Theme Test"/> + <title value="Magento Rush theme should not be available in Themes grid"/> + <description value="Magento Rush theme should not be available in Themes grid"/> + <severity value="MAJOR"/> + <testCaseId value="MAGETWO-91409"/> + <group value="theme"/> + </annotations> + <after> + <actionGroup ref="logout" stepKey="logoutOfAdmin"/> + </after> + <!--Login to Admin Area--> + <actionGroup ref="LoginAsAdmin" stepKey="loginToAdminArea"/> + <!--Navigate to Themes page--> + <amOnPage url="{{ThemesPageIndex.url}}" stepKey="navigateToThemesIndexPage" /> + <waitForPageLoad stepKey="wait1"/> + <dontSee selector="{{AdminThemeSection.gridCell('Magento Rush')}}" stepKey="dontSeeRushThemeInTitleColumn"/> + <seeNumberOfElements selector="{{AdminThemeSection.rowsInColumn('theme_path')}}" userInput="2" stepKey="see2RowsOnTheGrid"/> + </test> +</tests> From aad511131b1406666dbe3fab1ab09378632d2f3b Mon Sep 17 00:00:00 2001 From: Deepty Thampy <dthampy@magento.com> Date: Fri, 18 May 2018 11:45:57 -0500 Subject: [PATCH 6/6] MAGETWO-91893: Verify the product attribute is not visible on storefront if it is empty for the Product - added clean up steps and updated Data file --- .../Catalog/Data/ProductAttributeData.xml | 23 ++++++++++++++++++- ...torefrontProductWithEmptyAttributeTest.xml | 17 ++------------ 2 files changed, 24 insertions(+), 16 deletions(-) diff --git a/dev/tests/acceptance/tests/functional/Magento/FunctionalTest/Catalog/Data/ProductAttributeData.xml b/dev/tests/acceptance/tests/functional/Magento/FunctionalTest/Catalog/Data/ProductAttributeData.xml index 946a3f614c1e1..ab0eac4960dc6 100644 --- a/dev/tests/acceptance/tests/functional/Magento/FunctionalTest/Catalog/Data/ProductAttributeData.xml +++ b/dev/tests/acceptance/tests/functional/Magento/FunctionalTest/Catalog/Data/ProductAttributeData.xml @@ -32,7 +32,7 @@ <requiredEntity type="FrontendLabel">ProductAttributeFrontendLabel</requiredEntity> </entity> <entity name="productAttributeWithTwoOptions" type="ProductAttribute"> - <data key="attribute_code" unique="suffix">testattribute</data> + <data key="attribute_code" unique="suffix">attribute</data> <data key="frontend_input">select</data> <data key="scope">global</data> <data key="is_required">false</data> @@ -73,4 +73,25 @@ <data key="used_for_sort_by">true</data> <requiredEntity type="FrontendLabel">ProductAttributeFrontendLabel</requiredEntity> </entity> + <entity name="productAttributeWithDropdownTwoOptions" type="ProductAttribute"> + <data key="attribute_code">testattribute</data> + <data key="frontend_input">select</data> + <data key="scope">global</data> + <data key="is_required">false</data> + <data key="is_unique">false</data> + <data key="is_searchable">true</data> + <data key="is_visible">true</data> + <data key="is_visible_in_advanced_search">true</data> + <data key="is_visible_on_front">true</data> + <data key="is_filterable">true</data> + <data key="is_filterable_in_search">true</data> + <data key="used_in_product_listing">true</data> + <data key="is_used_for_promo_rules">true</data> + <data key="is_comparable">true</data> + <data key="is_used_in_grid">true</data> + <data key="is_visible_in_grid">true</data> + <data key="is_filterable_in_grid">true</data> + <data key="used_for_sort_by">true</data> + <requiredEntity type="FrontendLabel">ProductAttributeFrontendLabel</requiredEntity> + </entity> </entities> diff --git a/dev/tests/acceptance/tests/functional/Magento/FunctionalTest/Catalog/Test/StorefrontProductWithEmptyAttributeTest.xml b/dev/tests/acceptance/tests/functional/Magento/FunctionalTest/Catalog/Test/StorefrontProductWithEmptyAttributeTest.xml index c80025c299885..f858340bc09fa 100644 --- a/dev/tests/acceptance/tests/functional/Magento/FunctionalTest/Catalog/Test/StorefrontProductWithEmptyAttributeTest.xml +++ b/dev/tests/acceptance/tests/functional/Magento/FunctionalTest/Catalog/Test/StorefrontProductWithEmptyAttributeTest.xml @@ -17,29 +17,18 @@ <group value="product"/> </annotations> <before> - <!--<actionGroup ref="LoginAsAdmin" stepKey="loginAsAdmin"/>--> <createData entity="_defaultCategory" stepKey="createPreReqCategory"/> - <!--<createData entity="productAttributeWithTwoOptions" stepKey="createProductAttribute"/>--> + <createData entity="productAttributeWithDropdownTwoOptions" stepKey="createProductAttribute"/> </before> <after> <actionGroup ref="deleteProductUsingProductGrid" stepKey="deleteSimpleProduct"> <argument name="product" value="SimpleProduct"/> </actionGroup> <deleteData createDataKey="createPreReqCategory" stepKey="deletePreReqCategory"/> - <!--<deleteData createDataKey="createProductAttribute" stepKey="deleteProductAttribute"/>--> + <deleteData createDataKey="createProductAttribute" stepKey="deleteProductAttribute"/> <actionGroup ref="logout" stepKey="logoutOfAdmin"/> </after> <actionGroup ref="LoginAsAdmin" stepKey="loginAsAdmin1"/> - <amOnPage url="{{ProductAttributePage.url}}" stepKey="navigateToProductAttribute"/> - <waitForPageLoad stepKey="wait1"/> - <!--<click selector="#add" stepKey="addNewAttribute"/>--> - <fillField selector="{{AttributePropertiesSection.DefaultLabel}}" userInput="testattribute" stepKey="fillAttributeLabel"/> - <selectOption selector="{{AttributePropertiesSection.InputType}}" userInput="Dropdown" stepKey="selectCatalogAttributeInputType"/> - <click selector="{{StorefrontPropertiesSection.StoreFrontPropertiesTab}}" stepKey="clickStorefrontPropertiesTab"/> - <selectOption selector="#is_visible_on_front" userInput="Yes" stepKey="isVisibleOnStoreFront"/> - <selectOption selector="#used_in_product_listing" userInput="Yes" stepKey="usedInProductListing"/> - <click selector="{{AttributePropertiesSection.Save}}" stepKey="saveAttribute"/> - <waitForPageLoad stepKey="waitForSaveAttribute"/> <amOnPage url="{{AdminProductAttributeSetGridPage.url}}" stepKey="amOnAttributeSetPage"/> <click selector="{{AdminProductAttributeSetGridSection.AttributeSetName('Default')}}" stepKey="chooseDefaultAttributeSet"/> <waitForPageLoad stepKey="waitForAttributeSetPageLoad"/> @@ -54,8 +43,6 @@ <actionGroup ref="ClearCacheActionGroup" stepKey="clearCache"/> <amOnPage url="{{StorefrontProductPage.url(SimpleProduct.urlKey)}}" stepKey="goProductPageOnStorefront"/> <waitForPageLoad stepKey="waitForProductPageToLoad"/> - <!--<see selector="#product-attribute-specs-table tr th:nth-of-type(1)" stepKey="seeAttribute"/>--> - <!--<scrollTo selector=".additional-attributes tbody td:nth-of-type(1)" stepKey="seeAttribute1"/>--> <dontSeeElement selector="//table[@id='product-attribute-specs-table']/tbody/tr/th[contains(text(),'testattribute')]" stepKey="seeAttribute2"/> </test> </tests>