Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using a " in product title causes jquery error #17967

Closed
MartinAarts opened this issue Sep 7, 2018 · 8 comments
Closed

Using a " in product title causes jquery error #17967

MartinAarts opened this issue Sep 7, 2018 · 8 comments
Labels
Component: Catalog Fixed in 2.3.x The issue has been fixed in 2.3 release line good first issue Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release

Comments

@MartinAarts
Copy link

MartinAarts commented Sep 7, 2018

Preconditions:
Magento 2.2.5

Steps to reproduce:
Use a " in a product title

Expected result:
" being displayed.

Actual result:
Page javascript not loaded correctly, because " is not being escaped.

schermafbeelding 2018-09-07 om 14 34 55

@magento-engcom-team
Copy link
Contributor

Hi @MartinAarts. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me {$VERSION} instance

where {$VERSION} is version tags (starting from 2.2.0+) or develop branches (2.2-develop +).
For more details, please, review the Magento Contributor Assistant documentation.

@MartinAarts do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Sep 7, 2018
@MartinAarts
Copy link
Author

@magento-engcom-team give me 2.2.5 instance

@magento-engcom-team
Copy link
Contributor

Hi @MartinAarts. Thank you for your request. I'm working on Magento 2.2.5 instance for you

@magento-engcom-team
Copy link
Contributor

Hi @MartinAarts, here is your Magento instance.
Admin access: https://i-17967-2-2-5.engcom.dev.magento.com/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@MartinAarts
Copy link
Author

I'm able to reproduce the issue in the given instance. See attached screenshots. Now visible at this url:
https://i-17967-2-2-5.engcom.dev.magento.com/test-product.html

For example, image keeps loading, JS gives error.
schermafbeelding 2018-09-07 om 14 41 19
schermafbeelding 2018-09-07 om 14 41 13

@ghost ghost self-assigned this Sep 7, 2018
@ghost ghost added Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Fixed in 2.3.x The issue has been fixed in 2.3 release line Component: Catalog and removed Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed labels Sep 7, 2018
@ghost ghost removed their assignment Sep 7, 2018
@hostep
Copy link
Contributor

hostep commented Sep 7, 2018

This is a known problem and is already fixed on the 2.2-develop branch.
Let's close it as a duplicate of #15631 & #15037 & #15491 & probably some others.

@hostep hostep closed this as completed Sep 7, 2018
@DanielRuf
Copy link
Contributor

Preconditions:
Magento 2.2.5

@DanielRuf
Copy link
Contributor

This is a known problem and is already fixed on the 2.2-develop branch.

I see no fix there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Catalog Fixed in 2.3.x The issue has been fixed in 2.3 release line good first issue Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release
Projects
None yet
Development

No branches or pull requests

5 participants