-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Elastic search not working if sku is like 42-315 #20689
Comments
Hi @arijit-codilar. Thank you for your report.
Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:
where @arijit-codilar do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?
|
Hi @LuciferStrome. Thank you for working on this issue.
|
Hi @engcom-backlog-nazar. Thank you for working on this issue.
|
@arijit-codilar hmm.. strange i'm getting exception on clean 2.3-dev instance |
@engcom-backlog-nazar I have installed the Magento from magento's site but still it should not get into two directions. |
@engcom-backlog-nazar Thank you for verifying the issue. Based on the provided information internal tickets |
@magento-engcom-team give me 2.3-develop instance |
Hi @engcom-backlog-nazar. Thank you for your request. I'm working on Magento 2.3-develop instance for you |
@magento-engcom-team give me 2.3-develop instance |
Hi @amol2jcommerce. Thank you for your request. I'm working on Magento 2.3-develop instance for you |
Hi @amol2jcommerce, here is your Magento instance. |
@arijit-codilar on vanilla |
@engcom-backlog-nazar But I am getting something different which I have shared above. And, my instance has been downloaded from magento's site. Are you using Elastic search or MySql? |
@arijit-codilar no this only appears on Mysql, but perfectly works with Elastic |
@magento give me 2.4-develop instance |
Hi @denchev. Thank you for your request. I'm working on Magento instance for you. |
Hi @denchev, here is your Magento Instance: https://3d513cb939271cbe4dafb677116d790f-2-4-develop.instances.magento-community.engineering |
This behavior continues to appear in 2.4 Not quite sure if this is a bug but I will spend some time to investigate a bit deeper. I created 3 products with the mentioned skus 42-315, 42-317 and 42-318. When I search for the first one 42-315 I got all the 3 products + 3 more than have SKUs like 24-WG080, 24-WG088 and 24-WG084. Since 24 is the reverse of 42 and there is a dash in the SKU I assume that Elasticsearch is doing some "magic" when storing the results. I will try to see if there are any settings that can be tweaked. @magento I am working on this |
I've been investigating this and it looks like the problem is with Elasticsearch tokenizer. I would not count this is a bug per-say as this is how Elasticsearch is supposed to work. I found this to be a merchant-facing issue as I had clients that complain about this same behavior. I am working on a potential solution - a non-core module (for now) that will allow merchants to turn on/off tokenization for certain attributes (sku). This should fix this type of issue. I don't think this is something that belongs to Magento 2 core code. As soon as I have it I will post it here and maybe then a discussion can start on what to do with the whole problem in general. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 14 days if no further activity occurs. Is this issue still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? Thank you for your contributions! |
Hi @arijit-codilar, @denchev. Thank you for your report and collaboration! The related internal Jira ticket The fix will be available with the upcoming |
Preconditions (*)
Steps to reproduce (*)
Expected result (*)
Actual result (*)
The text was updated successfully, but these errors were encountered: