Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advanced Search layout not proper #20809

Closed
amol2jcommerce opened this issue Jan 30, 2019 · 13 comments
Closed

Advanced Search layout not proper #20809

amol2jcommerce opened this issue Jan 30, 2019 · 13 comments
Assignees
Labels
Component: Ui Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Progress: PR Created Indicates that Pull Request has been created to fix issue Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Comments

@amol2jcommerce
Copy link
Contributor

Preconditions (*)

  1. Magento 2.3.0

Steps to reproduce (*)

  1. Click Advanced Search link in footer

Expected result (*)

advanced search - 2

Actual result (*)

advanced search - 1

@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Jan 30, 2019

Hi @amol2jcommerce. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me 2.3-develop instance - upcoming 2.3.x release

For more details, please, review the Magento Contributor Assistant documentation.

@amol2jcommerce do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Jan 30, 2019
@amol2jcommerce amol2jcommerce self-assigned this Jan 30, 2019
@amol2jcommerce amol2jcommerce added Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Component: Ui Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Jan 30, 2019
@magento-engcom-team
Copy link
Contributor

@amol2jcommerce Thank you for verifying the issue. Based on the provided information internal tickets MAGETWO-97987 were created

Issue Available: @amol2jcommerce, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@magento-engcom-team magento-engcom-team added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Jan 30, 2019
@amol2jcommerce amol2jcommerce self-assigned this Jan 30, 2019
@amol2jcommerce amol2jcommerce added the Progress: PR Created Indicates that Pull Request has been created to fix issue label Jan 30, 2019
@milindsingh
Copy link
Member

@amol2jcommerce What's not proper in the full page design?
@engcom-backlog-nazar I think a issue must be verified by more 1 contributor, to make sure that's it's actually a issue.

@amol2jcommerce
Copy link
Contributor Author

amol2jcommerce commented Jan 30, 2019

Hi @milindsingh, @engcom-backlog-nazar when you check customer registration page and contact us page design are same but not advance search page design.

Customer Registration page
2019-01-30_22-30_create new customer account

Contact Us page
2019-01-30_22-31_contact us

Hence we create a Issue and this page design also same as per both design.
Like:
2019-01-30_22-37_advanced search

Thanks

@cedarvinda
Copy link
Member

@amol2jcommerce You doing same changes in same file with different PR
f12116e

604ab26

If you have done in PR #20810, Then no need for #20817 PR.

@engcom-backlog-nazar Please check, Right now I am closing #20817
@amol2jcommerce If you have any query please reach with me Thankyou.

@amol2jcommerce
Copy link
Contributor Author

amol2jcommerce commented Jan 30, 2019

@cedarvinda why you close PR ?
Are you sure both PR changes are same? No different?
@engcom-backlog-nazar please check.

@ghost ghost self-assigned this Jan 31, 2019
@magento-engcom-team
Copy link
Contributor

Hi @engcom-backlog-nazar. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if your want to validate it one more time, please, go though the following instruction:

  • 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 2. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 3. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • 4. If the issue is not relevant or is not reproducible any more, feel free to close it.

@ghost ghost removed their assignment Jan 31, 2019
@rogyar
Copy link
Contributor

rogyar commented Mar 7, 2019

I believe it's a good idea to have the same layout for all basic forms

@magento-engcom-team
Copy link
Contributor

Hi @amol2jcommerce. Thank you for your report.
The issue has been fixed in #21611 by @amol2jcommerce in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming 2.3.2 release.

@magento-engcom-team magento-engcom-team added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Mar 14, 2019
@dmytro-ch
Copy link
Contributor

@magento-engcom-team give me 2.2-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch. Thank you for your request. I'm working on Magento 2.2-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch, here is your Magento instance.
Admin access: https://i-20809-2-2-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@dmytro-ch dmytro-ch added the Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release label Mar 22, 2019
@magento-engcom-team
Copy link
Contributor

Hi @amol2jcommerce. Thank you for your report.
The issue has been fixed in #21892 by @amol2jcommerce in 2.2-develop branch
Related commit(s):

The fix will be available with the upcoming 2.2.9 release.

@magento-engcom-team magento-engcom-team added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Apr 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Ui Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Progress: PR Created Indicates that Pull Request has been created to fix issue Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Development

No branches or pull requests

6 participants