Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.3.0 Watermark not showing on images #21154

Closed
travis5491811 opened this issue Feb 12, 2019 · 12 comments
Closed

2.3.0 Watermark not showing on images #21154

travis5491811 opened this issue Feb 12, 2019 · 12 comments
Assignees
Labels
Component: Catalog Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line help wanted Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Comments

@travis5491811
Copy link

Preconditions (*)

  1. v2.3.0
  2. Fresh installation, no third party modules

Steps to reproduce (*)

  1. Create categories
  2. Create products
  3. Modify buggy image uploader to work around bug so you actually can upload a watermark.
  4. Upload a watermark (use watermark in this issue as a watermark example)
  5. set image opacity to 10, image size to 40x50, image position to tile, and saved configuration.
  6. tap the Cache Management link in the system message. Then, refresh the invalid cache.

Expected result (*)

  1. Expect to see watermark on product images.

Actual result (*)

  1. No watermark
@magento-engcom-team
Copy link
Contributor

Hi @travis5491811. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me 2.3-develop instance - upcoming 2.3.x release

For more details, please, review the Magento Contributor Assistant documentation.

@travis5491811 do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Feb 12, 2019
@travis5491811
Copy link
Author

Hi @travis5491811. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me 2.3-develop instance - upcoming 2.3.x release

For more details, please, review the Magento Contributor Assistant documentation.

@travis5491811 do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@magento-engcom-team
Copy link
Contributor

Hi @travis5491811. Thank you for your request. I'm working on Magento 2.3-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @travis5491811, here is your Magento instance.
Admin access: https://i-21154-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@travis5491811
Copy link
Author

@magento-engcom-team same problem in your instance. Thumbnails show in the admin area Catalog > products list. But don't show on front-end.

magenotbug_screenshot from 2019-02-12 10-23-23
magentobug_screenshot from 2019-02-12 10-23-48
magentobug_screenshot from 2019-02-12 10-24-29
magentobug_screenshot from 2019-02-12 10-26-49
magentobug_screenshot from 2019-02-12 10-27-22

Try flushing magento cache and catalog images cache, still same results.

@ghost ghost self-assigned this Feb 13, 2019
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Feb 13, 2019

Hi @engcom-backlog-nazar. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • Next steps are available in case you are a member of Community Maintainers.

  • 6. Add label Issue: Confirmed once verification is complete.

  • 7. Make sure that automatic system confirms that report has been added to the backlog.

@ghost ghost added Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Component: Catalog Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release Fixed in 2.2.x The issue has been fixed in 2.2 release line help wanted Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Feb 13, 2019
@progreg progreg self-assigned this Feb 14, 2019
@magento-engcom-team
Copy link
Contributor

Hi @progreg. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

  • 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 2. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 3. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • 4. If the issue is not relevant or is not reproducible any more, feel free to close it.

@magento-engcom-team magento-engcom-team added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Mar 4, 2019
@magento-engcom-team
Copy link
Contributor

Hi @travis5491811. Thank you for your report.
The issue has been fixed in #21338 by @progreg in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming 2.3.2 release.

@maartenwolfsen
Copy link

maartenwolfsen commented May 9, 2019

I created a patch file for this:
https://gist.github.com/maartenatmarissen/14b48e1de6629dcccae10d75fbde6a19

Which can be installed using cweagans/composer-patches

@onepack
Copy link

onepack commented Nov 9, 2019

I wrote that it was not working but I just discovered that the default value from the global theme settings under Content design config is not automatically copied to the website level.
I had to manually set "use default" under website.

@vishalpatel19862
Copy link

vishalpatel19862 commented Jun 18, 2020

I have placed file ImageResize.php at app/code/Magento/MediaStorage/Service/ still water mark is not showing and images on list page disappears.

I have taken file from here.
c7930eb

@ashvinimarwal
Copy link

This issue is still coming on Magento CE 2.3.1 even after applying fixes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Catalog Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line help wanted Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Development

No branches or pull requests

7 participants