Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update sharp v0.17 #61

Closed
slavikse opened this issue Dec 19, 2016 · 8 comments · Fixed by #88
Closed

update sharp v0.17 #61

slavikse opened this issue Dec 19, 2016 · 8 comments · Fixed by #88

Comments

@slavikse
Copy link

slavikse commented Dec 19, 2016

previous settings issue:

vips warning: VipsJpeg: error reading resolution
(node:22753) DeprecationWarning: quality: use jpeg({ quality: ... }), webp({ quality: ... }) and/or tiff({ quality: ... }) instead
(node:22753) DeprecationWarning: progressive: use jpeg({ progressive: ... }) and/or png({ progressive: ... }) instead
(node:22753) DeprecationWarning: withoutChromaSubsampling: use jpeg({ chromaSubsampling: "4:4:4" }) instead
vips warning: VipsJpeg: error reading resolution
(node:22753) DeprecationWarning: compressionLevel: use png({ compressionLevel: ... }) instead
vips warning: VipsJpeg: error reading resolution

I tried to correct the settings on the:

param.jpeg = {progressive: true};
param.png = {progressive: true};

warnings remained.
how to fix?

@mahnunchik
Copy link
Owner

Hi @slavikse

I've faced with the same issue: lovell/sharp#657

Will fix asap.

@slavikse
Copy link
Author

@mahnunchik this error is understandable.
I will wait. Thank you :)

@mahnunchik
Copy link
Owner

Hi @slavikse

Warnings like:

vips warning: VipsJpeg: error reading resolution

can be ignored, more info here lovell/sharp#657

DeprecationWarning I will fix in the next major release.

@slavikse
Copy link
Author

Hi @mahnunchik
Thank you!
Cool utility do! :)

@strarsis
Copy link

strarsis commented Apr 1, 2017

Will this be fixed in near future?

@developer239
Copy link

I can still see the errors :)

@michaeljota
Copy link

Can be sharp made peerDependecy? This way we wouldn't have to wait for this to update sharp, and can use the latest version. If you are worried about compatibility errors, you could use version range, but even then, we could use test with the latest to see if that works.

@marcospgp
Copy link

marcospgp commented Apr 9, 2018

Bump! @mahnunchik are you monitoring these?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants