fix(firebase): fix nx not installing packages on generate

mainawycliffe · Feb 8, 2023 · fba1c37 · fba1c37
1 parent 4662c3f
commit fba1c37
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 6 deletions.
diff --git a/packages/firebase/src/generators/functions/generator.ts b/packages/firebase/src/generators/functions/generator.ts
@@ -54,6 +54,6 @@ export default async function (tree: Tree, options: FirebaseGeneratorSchema) {
 
   await formatFiles(tree);
 
-  // install dependencies
-  addDependencies(tree);
+  // add dependencies for firebase functions
+  return addDependencies(tree);
 }
diff --git a/packages/firebase/src/generators/functions/utilities/addDependencies.ts b/packages/firebase/src/generators/functions/utilities/addDependencies.ts
@@ -5,7 +5,7 @@ export default function addDependencies(tree: Tree) {
   const nxWorkspaceVersion = JSON.parse(tree.read('package.json').toString())
     .devDependencies['@nrwl/workspace'];
 
-  const installDependencies = addDependenciesToPackageJson(
+  return addDependenciesToPackageJson(
     tree,
     {
       'firebase-admin': '^11.4.1',
@@ -17,7 +17,4 @@ export default function addDependencies(tree: Tree) {
       esbuild: '^0.15.7',
     }
   );
-
-  // install all dependencies
-  installDependencies();
 }