Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable *mandatory* fastboot tests in CI #1719

Closed
mike-north opened this issue Nov 24, 2018 · 1 comment · Fixed by #2209
Closed

Re-enable *mandatory* fastboot tests in CI #1719

mike-north opened this issue Nov 24, 2018 · 1 comment · Fixed by #2209
Labels

Comments

@mike-north
Copy link
Collaborator

mike-north commented Nov 24, 2018

The fastboot CI job has been failing on master for about a month, probably due to a combination of

  • ember-data#master being incompatible with recent releases of ember (you'll get a rollup build error when attempting to build)
  • ember-fetch's custom rollup stuff not working nicely with fastboot testing infrastructure

To address this, I've improved our CI configuration (#1718) to detect this kind of breakage in nightly builds, by ensuring that tests are run both with and without taking the lockfile into account.

Unfortunately, getting fastboot testing passing again will take some non-trivial digging. Here's what I've found in my limited time

In the mean time, to allow meaningful development to continue while some of this infrastructure is updated/repaired, I've marked the CI job as an allowed failure.

@mike-north
Copy link
Collaborator Author

mike-north commented Nov 27, 2018

Good news! the fastboot testing job stopped hanging as of this commit dc6be17.

We may be good to put this job back on the critical path again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants