Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

writing material name in OpenMC material file #19

Closed
shimwell opened this issue Jul 10, 2019 · 2 comments
Closed

writing material name in OpenMC material file #19

shimwell opened this issue Jul 10, 2019 · 2 comments

Comments

@shimwell
Copy link
Collaborator

Currently it looks like the OpenMC material writer only writes the material id in the materials.xml file

It would be handy if the material name was also included

I have created a new branch that can do this

Unfortunately I based it on the Serpent additions so I shall make a PR once those serpent additions are merged

@shimwell
Copy link
Collaborator Author

I have added some code to write openmc material names out along with the material ID. It appears OpenMC is case sensitive so I was thinking about retaining the case when files are read in and converted. What do you think would this cause to much trouble.

for example reading in a serpent material card when materials have capital letters in them and writing to OpenMC, should we retain the capitalisation?

@makeclean
Copy link
Owner

This was addressed by #18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants